Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 4d4f310979380ec1826a0c7f5bd3026bd0f4bac8
https://github.com/WebKit/WebKit/commit/4d4f310979380ec1826a0c7f5bd3026bd0f4bac8
Author: Sammy Gill <[email protected]>
Date: 2026-09-29 (Tue, 29 Sep 2026)
Changed paths:
M Source/WebCore/layout/formattingContexts/grid/TrackSizingAlgorithm.cpp
Log Message:
-----------
[GFC] Apply the space distributed to non-affected tracks when distributing
extra space.
https://bugs.webkit.org/show_bug.cgi?id=325588
rdar://problem/188663376
Reviewed by Alan Baradlay.
https://drafts.csswg.org/css-grid-2/#extra-space
When an item spans both affected and non-affected tracks, step 2.3,
"Distribute space to non-affected tracks", distributes any space left after
the affected tracks reach their limits "as for the previous step, but into the
non-affected tracks instead".
We implemented this in GFC by following it to the letter which means we
distributed the space into a helper function. However, since the spec
did not say what to do with that extra space like the affected tracks
this didn't really end up doing anything besides taking away space from
the rest of the algorithm.
In this patch we take that space that was distributed to the non-affected
tracks and actually apply them to the base sizes/growth limits of the
track. I think this needs some editing from the spec side but otherwise
without this change the resolution in which this step was added would be
pointless.
Canonical link: https://commits.webkit.org/322168@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
