Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: dfd2908e544302d9d717cb0598b135a366cc41d5
https://github.com/WebKit/WebKit/commit/dfd2908e544302d9d717cb0598b135a366cc41d5
Author: Chris Dumez <[email protected]>
Date: 2026-09-29 (Tue, 29 Sep 2026)
Changed paths:
M Source/WebCore/SaferCPPExpectations/ForwardDeclCheckerExpectations
M Source/WebCore/SaferCPPExpectations/MemoryUnsafeCastCheckerExpectations
M
Source/WebCore/SaferCPPExpectations/NoUncheckedPtrMemberCheckerExpectations
M Source/WebCore/SaferCPPExpectations/NoUncountedMemberCheckerExpectations
M Source/WebCore/SaferCPPExpectations/NoUnretainedMemberCheckerExpectations
M Source/WebCore/SaferCPPExpectations/RetainPtrCtorAdoptCheckerExpectations
M Source/WebCore/SaferCPPExpectations/UncheckedCallArgsCheckerExpectations
M Source/WebCore/SaferCPPExpectations/UncheckedLocalVarsCheckerExpectations
M Source/WebCore/SaferCPPExpectations/UncountedCallArgsCheckerExpectations
M Source/WebCore/SaferCPPExpectations/UnretainedCallArgsCheckerExpectations
M
Source/WebCore/SaferCPPExpectations/UnretainedLambdaCapturesCheckerExpectations
M Source/WebCore/SaferCPPExpectations/UnretainedLocalVarsCheckerExpectations
M Source/WebCore/platform/ios/ColorIOS.mm
M Source/WebCore/platform/ios/DeviceMotionClientIOS.h
M Source/WebCore/platform/ios/DeviceMotionClientIOS.mm
M Source/WebCore/platform/ios/DeviceOrientationClientIOS.h
M Source/WebCore/platform/ios/DeviceOrientationClientIOS.mm
M Source/WebCore/platform/ios/DragImageIOS.mm
M Source/WebCore/platform/ios/LegacyTileCache.h
M Source/WebCore/platform/ios/LegacyTileCache.mm
M Source/WebCore/platform/ios/LegacyTileGrid.mm
M Source/WebCore/platform/ios/LegacyTileGridTile.mm
M Source/WebCore/platform/ios/LocalCurrentTraitCollection.mm
M Source/WebCore/platform/ios/PasteboardIOS.mm
M Source/WebCore/platform/ios/PlatformPasteboardIOS.mm
M Source/WebCore/platform/ios/PlatformScreenIOS.mm
M Source/WebCore/platform/ios/PlaybackSessionInterfaceAVKitLegacy.mm
M Source/WebCore/platform/ios/PlaybackSessionInterfaceIOS.mm
M Source/WebCore/platform/ios/PreviewConverterIOS.mm
M Source/WebCore/platform/ios/QuickLook.h
M Source/WebCore/platform/ios/QuickLook.mm
M Source/WebCore/platform/ios/ScrollViewIOS.mm
M Source/WebCore/platform/ios/TileControllerMemoryHandlerIOS.cpp
M Source/WebCore/platform/ios/UIViewControllerUtilities.mm
M Source/WebCore/platform/ios/ValidationBubbleIOS.mm
M Source/WebCore/platform/ios/VideoPresentationInterfaceAVKitLegacy.mm
M Source/WebCore/platform/ios/VideoPresentationInterfaceIOS.h
M Source/WebCore/platform/ios/VideoPresentationInterfaceIOS.mm
M Source/WebCore/platform/ios/WebCoreMotionManager.mm
M Source/WebCore/platform/ios/WebItemProviderPasteboard.mm
M Source/WebCore/platform/ios/WebVideoFullscreenControllerAVKit.mm
M Source/WebCore/platform/ios/WidgetIOS.mm
M Source/WebCore/platform/ios/wak/WAKClipView.mm
M Source/WebCore/platform/ios/wak/WAKScrollView.h
M Source/WebCore/platform/ios/wak/WAKScrollView.mm
M Source/WebCore/platform/ios/wak/WAKView.mm
M Source/WebCore/platform/ios/wak/WAKViewInternal.h
M Source/WebCore/platform/ios/wak/WAKWindow.h
M Source/WebCore/platform/ios/wak/WAKWindow.mm
M Source/WebCore/platform/ios/wak/WKView.mm
M Source/WebCore/platform/ios/wak/WebCoreThread.mm
M Source/WebCore/platform/ios/wak/WebCoreThreadRun.cpp
M Source/WebKitLegacy/WebKitLegacy-iOS.exp
M Source/WebKitLegacy/mac/WebView/WebView.mm
Log Message:
-----------
[Safer CPP] Address most static analysis warnings in WebCore/platform/iOS
https://bugs.webkit.org/show_bug.cgi?id=325480
Reviewed by Anne van Kesteren and David Kilzer.
* Source/WebCore/platform/ios/ColorIOS.mm:
(WebCore::colorFromCocoaColor):
* Source/WebCore/platform/ios/DeviceMotionClientIOS.h:
* Source/WebCore/platform/ios/DeviceMotionClientIOS.mm:
(WebCore::DeviceMotionClientIOS::deviceMotionControllerDestroyed):
(WebCore::DeviceMotionClientIOS::motionChanged):
* Source/WebCore/platform/ios/DeviceOrientationClientIOS.h:
* Source/WebCore/platform/ios/DeviceOrientationClientIOS.mm:
(WebCore::DeviceOrientationClientIOS::deviceOrientationControllerDestroyed):
(WebCore::DeviceOrientationClientIOS::orientationChanged):
* Source/WebCore/platform/ios/DragImageIOS.mm:
(WebCore::createDragImageForRange):
(WebCore::createDragImageForColor):
* Source/WebCore/platform/ios/LegacyTileCache.h:
* Source/WebCore/platform/ios/LegacyTileCache.mm:
(WebCore::LegacyTileCache::ref const):
(WebCore::LegacyTileCache::deref const):
(WebCore::LegacyTileCache::LegacyTileCache):
(WebCore::LegacyTileCache::screenScale const):
(WebCore::LegacyTileCache::hostLayer const):
(WebCore::LegacyTileCache::visibleRectInLayer const):
(WebCore::LegacyTileCache::commitScaleChange):
(WebCore::LegacyTileCache::bringActiveTileGridToFront):
(WebCore::LegacyTileCache::adjustTileGridTransforms):
(WebCore::LegacyTileCache::layoutTiles):
(WebCore::LegacyTileCache::drawWindowContent):
(WebCore::LegacyTileCache::drawLayer):
(WebCore::LegacyTileCache::scheduleRenderingUpdateForPendingRepaint):
(WebCore::LegacyTileCache::updateTilingMode):
(WebCore::LegacyTileCache::setTilingMode):
(WebCore::LegacyTileCache::prepareToDraw):
* Source/WebCore/platform/ios/LegacyTileGrid.mm:
(WebCore::LegacyTileGrid::bounds const):
(WebCore::LegacyTileGrid::updateTileOpacity):
(WebCore::LegacyTileGrid::updateTileBorderVisibility):
(WebCore::LegacyTileGrid::updateHostLayerSize):
(WebCore::LegacyTileGrid::dumpTiles):
* Source/WebCore/platform/ios/LegacyTileGridTile.mm:
(WebCore::LegacyTileGridTile::LegacyTileGridTile):
(WebCore::LegacyTileGridTile::~LegacyTileGridTile):
(WebCore::LegacyTileGridTile::invalidateRect):
(WebCore::LegacyTileGridTile::setRect):
(WebCore::LegacyTileGridTile::showBorder):
* Source/WebCore/platform/ios/LocalCurrentTraitCollection.mm:
(WebCore::LocalCurrentTraitCollection::LocalCurrentTraitCollection):
* Source/WebCore/platform/ios/PasteboardIOS.mm:
(WebCore::isTypeAllowedByReadingPolicy):
(WebCore::Pasteboard::readPasteboardWebContentDataForType):
(WebCore::shouldTreatAsAttachmentByDefault):
* Source/WebCore/platform/ios/PlatformPasteboardIOS.mm:
(WebCore::platformTypeConformsToWebArchivePBoardType):
(WebCore::PlatformPasteboard::informationForItemAtIndex):
(WebCore::PlatformPasteboard::color):
(WebCore::PlatformPasteboard::setColor):
(WebCore::PlatformPasteboard::write):
(WebCore::PlatformPasteboard::typesSafeForDOMToReadAndWrite const):
(WebCore::createItemProviderRegistrationList):
(WebCore::PlatformPasteboard::readURL const):
* Source/WebCore/platform/ios/PlatformScreenIOS.mm:
(WebCore::screenRect):
(WebCore::screenAvailableRect):
* Source/WebCore/platform/ios/PlaybackSessionInterfaceAVKitLegacy.mm:
(WebCore::PlaybackSessionInterfaceAVKitLegacy::durationChanged):
(WebCore::PlaybackSessionInterfaceAVKitLegacy::bufferedTimeChanged):
(WebCore::PlaybackSessionInterfaceAVKitLegacy::externalPlaybackChanged):
* Source/WebCore/platform/ios/PlaybackSessionInterfaceIOS.mm:
(WebCore::PlaybackSessionInterfaceIOS::invalidate):
(WebCore::PlaybackSessionInterfaceIOS::logIdentifier const):
(WebCore::PlaybackSessionInterfaceIOS::loggerPtr const):
* Source/WebCore/platform/ios/PreviewConverterIOS.mm:
(WebCore::PreviewConverter::platformUnlockWithPassword):
* Source/WebCore/platform/ios/QuickLook.mm:
(WebCore::WTF_REQUIRES_LOCK):
(WebCore::QLContentDictionary):
(WebCore::removeQLPreviewConverterForURL):
(WebCore::addQLPreviewConverterWithFileForURL):
(WebCore::registerQLPreviewConverterIfNeeded):
(WebCore::createTemporaryFileForQuickLook):
* Source/WebCore/platform/ios/ScrollViewIOS.mm:
(WebCore::ScrollView::documentView const):
(WebCore::ScrollView::platformAddChild):
(WebCore::ScrollView::platformSetScrollbarModes):
(WebCore::ScrollView::platformScrollbarModes const):
(WebCore::ScrollView::platformSetCanBlitOnScroll):
(WebCore::ScrollView::platformCanBlitOnScroll const):
(WebCore::ScrollView::platformUnobscuredContentRect const):
(WebCore::ScrollView::platformExposedContentRect const):
(WebCore::ScrollView::setActualScrollPosition):
(WebCore::ScrollView::platformVisibleContentRect const):
(WebCore::ScrollView::platformVisibleContentSize const):
(WebCore::ScrollView::legacyTileCache):
(WebCore::ScrollView::platformSetContentsSize):
(WebCore::ScrollView::platformSetScrollbarsSuppressed):
(WebCore::ScrollView::platformSetScrollPosition):
(WebCore::ScrollView::platformRepaintContentRectangle):
(WebCore::ScrollView::platformContentsToScreen const):
(WebCore::ScrollView::platformScreenToContents const):
(WebCore::ScrollView::platformIsOffscreen const):
(WebCore::ScrollView::platformSetScrollOrigin):
* Source/WebCore/platform/ios/TileControllerMemoryHandlerIOS.cpp:
(WebCore::TileControllerMemoryHandler::trimUnparentedTilesToTarget):
* Source/WebCore/platform/ios/UIViewControllerUtilities.mm:
(WebCore::viewController):
* Source/WebCore/platform/ios/ValidationBubbleIOS.mm:
(updateLabelFrame):
(WebCore::ValidationBubble::ValidationBubble):
(WebCore::ValidationBubble::show):
(WebCore::ValidationBubble::setAnchorRect):
(allocWebValidationBubbleViewControllerInstance): Deleted.
* Source/WebCore/platform/ios/VideoPresentationInterfaceAVKitLegacy.mm:
(-[WebAVPlayerViewController initWithFullscreenInterface:]):
(-[WebAVPlayerViewController playerViewControllerShouldHandleDoneButtonTap:]):
(WebCore::VideoPresentationInterfaceAVKitLegacy::~VideoPresentationInterfaceAVKitLegacy):
(WebCore::VideoPresentationInterfaceAVKitLegacy::setupFullscreen):
(WebCore::VideoPresentationInterfaceAVKitLegacy::fullscreenPlayerLayer const):
(WebCore::VideoPresentationInterfaceAVKitLegacy::hasVideoChanged):
(WebCore::VideoPresentationInterfaceAVKitLegacy::mayAutomaticallyShowVideoPictureInPicture
const):
(WebCore::VideoPresentationInterfaceAVKitLegacy::setupPlayerViewController):
(WebCore::VideoPresentationInterfaceAVKitLegacy::isPlayingVideoInPictureInPicture
const):
(WebCore::VideoPresentationInterfaceAVKitLegacy::setContentDimensions):
(WebCore::VideoPresentationInterfaceAVKitLegacy::isExternalPlaybackActive
const):
(WebCore::VideoPresentationInterfaceAVKitLegacy::transferVideoViewToFullscreen):
(WebCore::VideoPresentationInterfaceAVKitLegacy::returnVideoView):
(WebCore::VideoPresentationInterfaceAVKitLegacy::setupCaptionsLayer):
* Source/WebCore/platform/ios/VideoPresentationInterfaceIOS.mm:
(WebCore::fallbackViewController):
(WebCore::VideoPresentationInterfaceIOS::presentingViewController):
(WebCore::VideoPresentationInterfaceIOS::ensurePipPlacardIsShowing):
(WebCore::VideoPresentationInterfaceIOS::requestHideAndExitFullscreen):
(WebCore::VideoPresentationInterfaceIOS::preparedToReturnToInline):
(WebCore::VideoPresentationInterfaceIOS::doSetup):
(WebCore::VideoPresentationInterfaceIOS::videoDimensionsChanged):
(WebCore::VideoPresentationInterfaceIOS::externalPlaybackChanged):
(WebCore::VideoPresentationInterfaceIOS::setInlineRect):
(WebCore::VideoPresentationInterfaceIOS::doEnterFullscreen):
(WebCore::VideoPresentationInterfaceIOS::exitFullscreenHandler):
(WebCore::VideoPresentationInterfaceIOS::willStartPictureInPicture):
(WebCore::VideoPresentationInterfaceIOS::didStartPictureInPicture):
(WebCore::VideoPresentationInterfaceIOS::didStopPictureInPicture):
(WebCore::VideoPresentationInterfaceIOS::prepareForPictureInPictureStopWithCompletionHandler):
(WebCore::VideoPresentationInterfaceIOS::shouldExitFullscreenWithReason):
(WebCore::VideoPresentationInterfaceIOS::watchdogTimerFired):
* Source/WebCore/platform/ios/WebCoreMotionManager.mm:
(+[WebCoreMotionManager sharedManager]):
* Source/WebCore/platform/ios/WebItemProviderPasteboard.mm:
(-[NSItemProvider web_fileUploadContentTypes]):
(-[WebItemProviderRegistrationInfoList suggestedName]):
(-[WebItemProviderRegistrationInfoList setSuggestedName:]):
(-[WebItemProviderRegistrationInfoList teamData]):
(-[WebItemProviderRegistrationInfoList setTeamData:]):
(-[WebItemProviderPasteboard setItemProviders:dropSession:]):
(-[WebItemProviderPasteboard
_preLoadedDataConformingToType:forItemProviderAtIndex:]):
(-[WebItemProviderPasteboard dataForPasteboardType:inItemSet:]):
(-[WebItemProviderPasteboard valuesForPasteboardType:inItemSet:]):
(linkTemporaryItemProviderFilesToDropStagingDirectory):
(-[WebItemProviderPasteboard typeIdentifiersToLoad:]):
(-[WebItemProviderPasteboard
doAfterLoadingProvidedContentIntoFileURLs:synchronousTimeout:]):
(-[WebItemProviderRegistrationInfoList dealloc]): Deleted.
* Source/WebCore/platform/ios/WebVideoFullscreenControllerAVKit.mm:
(elementRectInWindow):
(VideoFullscreenControllerContext::~VideoFullscreenControllerContext):
* Source/WebCore/platform/ios/WidgetIOS.mm:
(WebCore::Widget::paint):
(WebCore::Widget::convertFromRootToContainingWindow):
(WebCore::Widget::convertFromContainingWindowToRoot):
* Source/WebCore/platform/ios/wak/WAKClipView.mm:
(-[WAKClipView documentView]):
(-[WAKClipView _setDocumentView:]):
(-[WAKClipView dealloc]): Deleted.
* Source/WebCore/platform/ios/wak/WAKScrollView.h:
* Source/WebCore/platform/ios/wak/WAKScrollView.mm:
(-[WAKScrollView initWithFrame:]):
(-[WAKScrollView dealloc]):
(-[WAKScrollView setDocumentView:]):
(-[WAKScrollView unobscuredContentRect]):
(-[WAKScrollView exposedContentRect]):
(-[WAKScrollView setActualScrollPosition:]):
(-[WAKScrollView description]):
* Source/WebCore/platform/ios/wak/WAKView.mm:
(enclosingScrollView):
(invocationForPostNotification):
(notificationCallback):
(-[WAKView handleEvent:]):
(willRemoveSubviewCallback):
(invalidateGStateCallback):
(-[WAKView dealloc]):
(-[WAKView _subviewReferences]):
(_WAKCopyWrapper):
(-[WAKView subviews]):
(-[WAKView lastScrollableAncestor]):
(-[WAKView displayRect:]):
(-[WAKView displayRectIgnoringOpacity:inContext:]):
(-[WAKView lockFocus]):
(-[WAKView unlockFocus]):
(-[WAKView scrollPoint:]):
* Source/WebCore/platform/ios/wak/WAKViewInternal.h:
(WAKViewForWKViewRef):
* Source/WebCore/platform/ios/wak/WAKWindow.h:
* Source/WebCore/platform/ios/wak/WAKWindow.mm:
(-[WAKWindow initWithLayer:]):
(-[WAKWindow dealloc]):
(-[WAKWindow setContentView:]):
(-[WAKWindow close]):
(-[WAKWindow _newFirstResponderAfterResigning]):
(-[WAKWindow convertBaseToScreen:]):
(-[WAKWindow convertScreenToBase:]):
(-[WAKWindow convertRectToScreen:]):
(-[WAKWindow convertRectFromScreen:]):
(-[WAKWindow resignFirstResponder]):
(-[WAKWindow makeFirstResponder:]):
(-[WAKWindow rootLayer]):
(-[WAKWindow _visibleRectRespectingMasksToBounds:]):
(-[WAKWindow tileCache]):
(-[WAKWindow description]):
* Source/WebCore/platform/ios/wak/WKView.mm:
(WKViewRemoveFromSuperview):
(WKViewFirstChild):
(WKViewNextSibling):
(WKViewTraverseNext):
* Source/WebCore/platform/ios/wak/WebCoreThread.mm:
(webThreadRunLoop):
(SendDelegateMessage):
(WebThreadAdoptAndRelease):
(MainRunLoopAutoUnlock):
(_WebThreadAutoLock):
(_WebRunLoopEnableNestedFromMainThread):
(_WebRunLoopDisableNestedFromMainThread):
(RunWebThread):
(StartWebThread):
(WebThreadUnlockGuardForMail):
(WebThreadRunLoop):
* Source/WebCore/platform/ios/wak/WebCoreThreadRun.cpp:
Canonical link: https://commits.webkit.org/322136@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
