Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 5d67c7e574f6fee7e8cb45739e35006acbb3d97d
https://github.com/WebKit/WebKit/commit/5d67c7e574f6fee7e8cb45739e35006acbb3d97d
Author: Claudio Saavedra <[email protected]>
Date: 2026-09-29 (Tue, 29 Sep 2026)
Changed paths:
M Source/WebKit/UIProcess/API/glib/WebKitDownload.cpp
M Source/WebKit/UIProcess/API/glib/WebKitUserContentFilterStore.cpp
M Source/WebKit/UIProcess/API/glib/WebKitWebsiteDataManager.cpp
Log Message:
-----------
[GLib] Use GMallocString for the directory and path members cached by the API
https://bugs.webkit.org/show_bug.cgi?id=325400
Reviewed by Carlos Garcia Campos.
WebKitWebsiteDataManager's deprecated per-directory overrides, WebKitDownload's
destination and WebKitUserContentFilterStore's storage path were held as
GUniquePtr<char>, an owner that says nothing about the encoding of its bytes.
They are filled by GLib, from g_value_dup_string(), g_build_filename() and
g_filename_to_uri(), so GMallocString is the matching typed owner: it adopts
those results without a copy, its utf8() is the const char* the getters and
GLib calls need, and stringFromFileSystemRepresentation() reads it directly.
The lazily filled defaults are duplicated from the String::utf8() result once,
as g_strdup() did.
WebKitDownload compares and stores the destination as a typed string instead of
juggling a raw pointer between the file-URI and path branches of
webkit_download_set_destination().
No change in behavior.
Canonical link: https://commits.webkit.org/322144@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
