Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: f962f9ef82ac0f3abbd8261fcb98a5148eea2431
https://github.com/WebKit/WebKit/commit/f962f9ef82ac0f3abbd8261fcb98a5148eea2431
Author: Claudio Saavedra <[email protected]>
Date: 2026-09-29 (Tue, 29 Sep 2026)
Changed paths:
M Tools/CISupport/ews-build/steps.py
M Tools/CISupport/ews-build/steps_unittest.py
Log Message:
-----------
EWS should not excuse a failing test that the change itself modifies
https://bugs.webkit.org/show_bug.cgi?id=325174
Reviewed by Ryan Haddad.
When layout tests fail, RunWebKitTests asks the results database whether each
failing test is already failing on main, and drops the ones that are. This keeps
a change from being blamed for breakage it did not cause. If every failure is
dropped, the step succeeds.
The database only knows how a test behaves on main, without the change. That
says nothing about a test the change modifies, or whose expectations it changes.
Removing an expectation claims that the test now passes. If the claim is wrong
the test keeps failing, the database still calls it a pre-existing failure, and
EWS reports success. So a change that claims to fix a long-broken test is the
one case this check cannot catch.
321662@main was such a change. It removed an expectation and added an alias to a
copy of coreipc.js that the layout test does not load. The test kept failing and
EWS stayed green.
Tests the change touches are now left out of both database excuses, pre-existing
failure and known flake. FindModifiedLayoutTests already collects those tests,
from the files the change edits and from the diff of run-webkit-tests
--print-expectations taken before and after it. Removing an expectation shows up
in that diff as a changed line, because tests expected to pass are printed too.
* Tools/CISupport/ews-build/steps.py:
(RunWebKitTests.__init__):
(RunWebKitTests.modified_test_names):
(RunWebKitTests.filter_failures_using_results_db):
* Tools/CISupport/ews-build/steps_unittest.py:
Canonical link: https://commits.webkit.org/322185@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
