Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 417a09c4f271fd7fee16050addfcd4e05c5f093d
https://github.com/WebKit/WebKit/commit/417a09c4f271fd7fee16050addfcd4e05c5f093d
Author: Brent Fulgham <[email protected]>
Date: 2026-09-29 (Tue, 29 Sep 2026)
Changed paths:
M
LayoutTests/fast/forms/ios/form-control-refresh/search/search-decoration-appearance-expected-mismatch.html
M
LayoutTests/fast/forms/ios/form-control-refresh/search/search-decoration-appearance.html
M LayoutTests/fast/forms/search-vertical-alignment.html
A
LayoutTests/fast/forms/search/search-results-attribute-appearance-none-expected.html
A
LayoutTests/fast/forms/search/search-results-attribute-appearance-none.html
M
LayoutTests/fast/forms/search/search-results-attribute-disabled-by-default-expected.txt
M
LayoutTests/fast/forms/search/search-results-attribute-disabled-by-default.html
M LayoutTests/pdf/crash-with-embed-hidden.html
M
LayoutTests/platform/gtk/fast/css/focus-ring-exists-for-search-field-expected.txt
M LayoutTests/platform/gtk/fast/css/input-search-padding-expected.txt
M
LayoutTests/platform/gtk/fast/css/text-input-with-webkit-border-radius-expected.txt
M LayoutTests/platform/gtk/fast/css/text-overflow-input-expected.txt
M
LayoutTests/platform/gtk/fast/forms/control-restrict-line-height-expected.txt
M LayoutTests/platform/gtk/fast/forms/input-appearance-height-expected.txt
M LayoutTests/platform/gtk/fast/forms/placeholder-pseudo-style-expected.txt
M
LayoutTests/platform/gtk/fast/forms/search-cancel-button-style-sharing-expected.txt
M
LayoutTests/platform/gtk/fast/forms/search-display-none-cancel-button-expected.txt
M LayoutTests/platform/gtk/fast/forms/search-vertical-alignment-expected.txt
M LayoutTests/platform/gtk/fast/forms/searchfield-heights-expected.txt
M
LayoutTests/platform/ios/fast/css/focus-ring-exists-for-search-field-expected.txt
M LayoutTests/platform/ios/fast/css/input-search-padding-expected.txt
M
LayoutTests/platform/ios/fast/css/text-input-with-webkit-border-radius-expected.txt
M LayoutTests/platform/ios/fast/css/text-overflow-input-expected.txt
M
LayoutTests/platform/ios/fast/forms/control-restrict-line-height-expected.txt
M
LayoutTests/platform/ios/fast/forms/datalist/datalist-searchinput-appearance-expected.txt
M LayoutTests/platform/ios/fast/forms/input-appearance-height-expected.txt
M LayoutTests/platform/ios/fast/forms/placeholder-pseudo-style-expected.txt
M
LayoutTests/platform/ios/fast/forms/search-cancel-button-style-sharing-expected.txt
M
LayoutTests/platform/ios/fast/forms/search-display-none-cancel-button-expected.txt
M
LayoutTests/platform/mac-sequoia-wk2/fast/css/focus-ring-exists-for-search-field-expected.txt
M
LayoutTests/platform/mac-sequoia-wk2/fast/css/text-input-with-webkit-border-radius-expected.txt
M
LayoutTests/platform/mac-sequoia-wk2/fast/css/text-overflow-input-expected.txt
M
LayoutTests/platform/mac-sequoia-wk2/fast/forms/control-restrict-line-height-expected.txt
M
LayoutTests/platform/mac-sequoia-wk2/fast/forms/datalist/datalist-searchinput-appearance-expected.txt
M
LayoutTests/platform/mac-sequoia-wk2/fast/forms/input-appearance-height-expected.txt
M
LayoutTests/platform/mac-sequoia-wk2/fast/forms/placeholder-pseudo-style-expected.txt
M
LayoutTests/platform/mac-sequoia-wk2/fast/forms/search-cancel-button-style-sharing-expected.txt
M
LayoutTests/platform/mac-sequoia-wk2/fast/forms/search-display-none-cancel-button-expected.txt
M
LayoutTests/platform/mac-sequoia-wk2/fast/forms/search-vertical-alignment-expected.txt
M
LayoutTests/platform/mac-sequoia-wk2/fast/repaint/search-field-cancel-expected.txt
M
LayoutTests/platform/mac-wk2/fast/css/focus-ring-exists-for-search-field-expected.txt
M
LayoutTests/platform/mac-wk2/fast/css/text-input-with-webkit-border-radius-expected.txt
M LayoutTests/platform/mac-wk2/fast/css/text-overflow-input-expected.txt
M
LayoutTests/platform/mac-wk2/fast/forms/datalist/datalist-searchinput-appearance-expected.txt
M
LayoutTests/platform/mac-wk2/fast/forms/input-appearance-height-expected.txt
M
LayoutTests/platform/mac-wk2/fast/forms/placeholder-pseudo-style-expected.txt
M
LayoutTests/platform/mac-wk2/fast/forms/search-cancel-button-style-sharing-expected.txt
M
LayoutTests/platform/mac-wk2/fast/forms/search-display-none-cancel-button-expected.txt
M
LayoutTests/platform/mac-wk2/fast/forms/search-vertical-alignment-expected.txt
M LayoutTests/platform/mac-wk2/fast/repaint/search-field-cancel-expected.txt
M
LayoutTests/platform/mac/fast/forms/control-restrict-line-height-expected.txt
M
LayoutTests/platform/wpe/fast/css/focus-ring-exists-for-search-field-expected.txt
M
LayoutTests/platform/wpe/fast/css/input-search-padding-expected.txt
M
LayoutTests/platform/wpe/fast/css/text-input-with-webkit-border-radius-expected.txt
M LayoutTests/platform/wpe/fast/css/text-overflow-input-expected.txt
M
LayoutTests/platform/wpe/fast/forms/control-restrict-line-height-expected.txt
M LayoutTests/platform/wpe/fast/forms/input-appearance-height-expected.txt
M LayoutTests/platform/wpe/fast/forms/placeholder-pseudo-style-expected.txt
M
LayoutTests/platform/wpe/fast/forms/search-cancel-button-style-sharing-expected.txt
M
LayoutTests/platform/wpe/fast/forms/search-display-none-cancel-button-expected.txt
M LayoutTests/platform/wpe/fast/forms/search-vertical-alignment-expected.txt
M LayoutTests/platform/wpe/fast/forms/searchfield-heights-expected.txt
M Source/WebCore/html/SearchInputType.cpp
M Source/WebKit/UIProcess/Inspector/gtk/RemoteWebInspectorUIProxyGtk.cpp
M
Source/WebKit/UIProcess/Inspector/gtk/WebInspectorUIProxyGtk.cpp
M Source/WebKit/UIProcess/Inspector/mac/WKInspectorViewController.mm
M Source/WebKit/UIProcess/Inspector/win/RemoteWebInspectorUIProxyWin.cpp
M Source/WebKit/UIProcess/Inspector/win/WebInspectorUIProxyWin.cpp
M Source/WebKit/UIProcess/Inspector/wpe/WebInspectorUIProxyWPE.cpp
Log Message:
-----------
REGRESSION (316837@main): Icons missing in search fields, affects the Web and
Web Inspector
https://bugs.webkit.org/show_bug.cgi?id=325165
rdar://188297101
Reviewed by Tim Nguyen.
316837@main stopped creating SearchFieldResultsButtonElement unless
SearchInputResultsAttributeEnabled
is on, which it is not in full web browsers. That element is also the
::-webkit-search-decoration
element when there is no results attribute, so every search field lost it:
default search fields
no longer paint their magnifying glass, and Web Inspector's filter fields lost
the glyph they draw
on
::-webkit-search-decoration.
The shadow tree gate was not needed for the roland.com fix.
HTMLInputElement::attributeChanged
already ignores the results attribute when the setting is off, which leaves
maxResults at -1 and
gives the element the ::-webkit-search-decoration part. With the host at
appearance: none, that
part gets no native appearance and paints nothing. So we always create the
element again, and keep
only the attribute gate.
Web Inspector's Find banner and Search sidebar use results=5 for recent
searches, so we turn the
setting on for the frontend page on every port, for both local and remote
inspectors.
This restores the baselines that 316837@main changed only because the
decoration went away, and
opts fast/forms/search-vertical-alignment.html into the setting, since it tests
the results
decoration. Three test files that 316837@main opted into the setting only
because the
decoration went away no longer need it.
Tests:
fast/forms/search/search-results-attribute-appearance-none.html
fast/forms/search/search-results-attribute-disabled-by-default.html
* Source/WebCore/html/SearchInputType.cpp:
(WebCore::SearchInputType::createShadowSubtree): Always create the results
button element.
* Source/WebKit/UIProcess/Inspector/mac/WKInspectorViewController.mm:
(-[WKInspectorViewController webViewConfiguration]): Enable
SearchInputResultsAttributeEnabled.
* Source/WebKit/UIProcess/Inspector/gtk/RemoteWebInspectorUIProxyGtk.cpp:
(WebKit::RemoteWebInspectorUIProxy::platformCreateFrontendPageAndWindow): Ditto.
* Source/WebKit/UIProcess/Inspector/gtk/WebInspectorUIProxyGtk.cpp:
(WebKit::WebInspectorUIProxy::platformCreateFrontendPage): Ditto.
* Source/WebKit/UIProcess/Inspector/win/RemoteWebInspectorUIProxyWin.cpp:
(WebKit::RemoteWebInspectorUIProxy::platformCreateFrontendPageAndWindow): Ditto.
*
Source/WebKit/UIProcess/Inspector/win/WebInspectorUIProxyWin.cpp:
(WebKit::WebInspectorUIProxy::platformCreateFrontendPage): Ditto.
* Source/WebKit/UIProcess/Inspector/wpe/WebInspectorUIProxyWPE.cpp:
(WebKit::WebInspectorUIProxy::platformCreateFrontendPage): Ditto.
*
LayoutTests/fast/forms/search/search-results-attribute-appearance-none-expected.html:
Added.
* LayoutTests/fast/forms/search/search-results-attribute-appearance-none.html:
Added.
*
LayoutTests/fast/forms/search/search-results-attribute-disabled-by-default-expected.txt:
*
LayoutTests/fast/forms/search/search-results-attribute-disabled-by-default.html:
Expect the ::-webkit-search-decoration element to exist.
* LayoutTests/fast/forms/search-vertical-alignment.html:
*
LayoutTests/fast/forms/ios/form-control-refresh/search/search-decoration-appearance-expected-mismatch.html:
*
LayoutTests/fast/forms/ios/form-control-refresh/search/search-decoration-appearance.html:
* LayoutTests/pdf/crash-with-embed-hidden.html:
*
LayoutTests/platform/gtk/fast/css/focus-ring-exists-for-search-field-expected.txt:
* LayoutTests/platform/gtk/fast/css/input-search-padding-expected.txt:
*
LayoutTests/platform/gtk/fast/css/text-input-with-webkit-border-radius-expected.txt:
* LayoutTests/platform/gtk/fast/css/text-overflow-input-expected.txt:
* LayoutTests/platform/gtk/fast/forms/control-restrict-line-height-expected.txt:
* LayoutTests/platform/gtk/fast/forms/input-appearance-height-expected.txt:
* LayoutTests/platform/gtk/fast/forms/placeholder-pseudo-style-expected.txt:
*
LayoutTests/platform/gtk/fast/forms/search-cancel-button-style-sharing-expected.txt:
*
LayoutTests/platform/gtk/fast/forms/search-display-none-cancel-button-expected.txt:
* LayoutTests/platform/gtk/fast/forms/search-vertical-alignment-expected.txt:
* LayoutTests/platform/gtk/fast/forms/searchfield-heights-expected.txt:
*
LayoutTests/platform/mac-sequoia-wk2/fast/css/focus-ring-exists-for-search-field-expected.txt:
*
LayoutTests/platform/mac-sequoia-wk2/fast/css/text-input-with-webkit-border-radius-expected.txt:
*
LayoutTests/platform/mac-sequoia-wk2/fast/css/text-overflow-input-expected.txt:
*
LayoutTests/platform/mac-sequoia-wk2/fast/forms/datalist/datalist-searchinput-appearance-expected.txt:
*
LayoutTests/platform/mac-sequoia-wk2/fast/forms/input-appearance-height-expected.txt:
*
LayoutTests/platform/mac-sequoia-wk2/fast/forms/placeholder-pseudo-style-expected.txt:
*
LayoutTests/platform/mac-sequoia-wk2/fast/forms/search-cancel-button-style-sharing-expected.txt:
*
LayoutTests/platform/mac-sequoia-wk2/fast/forms/search-display-none-cancel-button-expected.txt:
*
LayoutTests/platform/mac-sequoia-wk2/fast/forms/search-vertical-alignment-expected.txt:
*
LayoutTests/platform/mac-sequoia-wk2/fast/repaint/search-field-cancel-expected.txt:
*
LayoutTests/platform/mac-wk2/fast/css/focus-ring-exists-for-search-field-expected.txt:
*
LayoutTests/platform/mac-wk2/fast/css/text-input-with-webkit-border-radius-expected.txt:
* LayoutTests/platform/mac-wk2/fast/css/text-overflow-input-expected.txt:
*
LayoutTests/platform/mac-wk2/fast/forms/datalist/datalist-searchinput-appearance-expected.txt:
* LayoutTests/platform/mac-wk2/fast/forms/input-appearance-height-expected.txt:
* LayoutTests/platform/mac-wk2/fast/forms/placeholder-pseudo-style-expected.txt:
*
LayoutTests/platform/mac-wk2/fast/forms/search-cancel-button-style-sharing-expected.txt:
*
LayoutTests/platform/mac-wk2/fast/forms/search-display-none-cancel-button-expected.txt:
*
LayoutTests/platform/mac-wk2/fast/forms/search-vertical-alignment-expected.txt:
* LayoutTests/platform/mac-wk2/fast/repaint/search-field-cancel-expected.txt:
* LayoutTests/platform/mac/fast/forms/control-restrict-line-height-expected.txt:
*
LayoutTests/platform/wpe/fast/css/focus-ring-exists-for-search-field-expected.txt:
*
LayoutTests/platform/wpe/fast/css/input-search-padding-expected.txt:
*
LayoutTests/platform/wpe/fast/css/text-input-with-webkit-border-radius-expected.txt:
* LayoutTests/platform/wpe/fast/css/text-overflow-input-expected.txt:
* LayoutTests/platform/wpe/fast/forms/control-restrict-line-height-expected.txt:
* LayoutTests/platform/wpe/fast/forms/input-appearance-height-expected.txt:
* LayoutTests/platform/wpe/fast/forms/placeholder-pseudo-style-expected.txt:
*
LayoutTests/platform/wpe/fast/forms/search-cancel-button-style-sharing-expected.txt:
*
LayoutTests/platform/wpe/fast/forms/search-display-none-cancel-button-expected.txt:
* LayoutTests/platform/wpe/fast/forms/search-vertical-alignment-expected.txt:
* LayoutTests/platform/wpe/fast/forms/searchfield-heights-expected.txt:
*
LayoutTests/platform/ios/fast/css/focus-ring-exists-for-search-field-expected.txt:
* LayoutTests/platform/ios/fast/css/input-search-padding-expected.txt:
*
LayoutTests/platform/ios/fast/css/text-input-with-webkit-border-radius-expected.txt:
* LayoutTests/platform/ios/fast/css/text-overflow-input-expected.txt:
* LayoutTests/platform/ios/fast/forms/control-restrict-line-height-expected.txt:
*
LayoutTests/platform/ios/fast/forms/datalist/datalist-searchinput-appearance-expected.txt:
* LayoutTests/platform/ios/fast/forms/input-appearance-height-expected.txt:
* LayoutTests/platform/ios/fast/forms/placeholder-pseudo-style-expected.txt:
*
LayoutTests/platform/ios/fast/forms/search-cancel-button-style-sharing-expected.txt:
*
LayoutTests/platform/ios/fast/forms/search-display-none-cancel-button-expected.txt:
*
LayoutTests/platform/mac-sequoia-wk2/fast/forms/control-restrict-line-height-expected.txt:
Canonical link:
https://flagged.apple.com:443/proxy?t2=Dg6e0i9PK5&o=aHR0cHM6Ly9jb21taXRzLndlYmtpdC5vcmcvMzIyMjE5QG1haW4=&emid=40894dc9-3304-417e-82b7-94d5c449ae38&c=11
To unsubscribe from these emails, change your notification
settings at https://github.com/WebKit/WebKit/settings/notifications
