Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 8315689934f7e2df8dd0ab13db1ae2bc9921cf46
      
https://github.com/WebKit/WebKit/commit/8315689934f7e2df8dd0ab13db1ae2bc9921cf46
  Author: Anne van Kesteren <[email protected]>
  Date:   2026-09-29 (Tue, 29 Sep 2026)

  Changed paths:
    M 
LayoutTests/fast/forms/select/base/select-option-base-appearance-styles-expected.txt
    M 
LayoutTests/fast/forms/select/base/select-option-base-appearance-styles.html
    M 
LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/the-select-element/customizable-select/base-appearance-inheritance-expected.txt
    R 
LayoutTests/platform/ios/fast/forms/select/base/select-option-base-appearance-styles-expected.txt
    M 
LayoutTests/platform/ios/imported/w3c/web-platform-tests/html/rendering/widgets/the-select-element/select-as-listbox-default-styles.tentative-expected.txt
    M Source/WebCore/css/html.css
    M Source/WebCore/css/selectMultipleAndListBox.css

  Log Message:
  -----------
  Options of a native select dropdown box pick up base appearance styles
https://bugs.webkit.org/show_bug.cgi?id=325407

Reviewed by Antoine Quint and Elika Etemad.

The option rules html.css adds for base appearance applied to every select, so 
a native
dropdown box's options reported flex layout, base appearance padding and 
not-allowed
cursors for disabled options.

Now that -internal-auto-base() can follow what lays out an option 
(322153@main), make
them revert outside base appearance, as the rules in 
selectMultipleAndListBox.css
already do. white-space: nowrap applies to both. box-sizing and align-items stay
unconditional per the CSS WG resolutions in w3c/csswg-drafts#14249 and #14319; 
the WPTs
that still expect content-box and normal for options need updating to match. The
::checkmark rules need no condition, as only base appearance generates 
::checkmark.

This makes base-appearance-inheritance.html pass. On iOS, where every native 
select is a
dropdown box, it also fixes the padding and border results in
select-as-listbox-default-styles.tentative.html and lets
select-option-base-appearance-styles.html share the generic expectations.

Canonical link: https://commits.webkit.org/322235@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications

Reply via email to