Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 0b1ef1771317ef3fc923dfd67eb3fc25d3bc1ed8
https://github.com/WebKit/WebKit/commit/0b1ef1771317ef3fc923dfd67eb3fc25d3bc1ed8
Author: Brady Eidson <[email protected]>
Date: 2026-09-30 (Wed, 30 Sep 2026)
Changed paths:
M Source/WebKit/UIProcess/WebPageProxy.cpp
M Source/WebKit/UIProcess/WebPageProxy.h
M Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm
M Source/WebKit/UIProcess/ios/WebPageProxyIOS.mm
M Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm
M Tools/TestWebKitAPI/Tests/WebKit/WKWebView/SiteIsolation-1.mm
Log Message:
-----------
[Site Isolation] On iOS, autocorrection, text context, and accessibility text
rects are empty or mispositioned for editable content in cross-origin iframes
rdar://188713635
https://bugs.webkit.org/show_bug.cgi?id=325658
Reviewed by Anne van Kesteren.
Classic site isolation cleanup - Not always messaging the right processes, and
not always translating
geometry into process-local coordinates.
Do more of both, with tests.
Test: Tools/TestWebKitAPI/Tests/WebKit/WKWebView/SiteIsolation-1.mm
* Source/WebKit/UIProcess/WebPageProxy.cpp:
* Source/WebKit/UIProcess/WebPageProxy.h:
* Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView _internalRequestAutocorrectionContextWithCompletionHandler:]):
* Source/WebKit/UIProcess/ios/WebPageProxyIOS.mm:
(WebKit::WebPageProxy::requestFocusedElementInformation):
(WebKit::WebPageProxy::requestAutocorrectionData):
(WebKit::WebPageProxy::requestAutocorrectionContext):
(WebKit::WebPageProxy::requestAutocorrectionContextAndWaitForReply):
(WebKit::WebPageProxy::requestRectsForGranularityWithSelectionOffset):
(WebKit::WebPageProxy::requestRectsAtSelectionOffsetWithText):
(WebKit::WebPageProxy::requestDocumentEditingContext):
* Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::convertContentToMainFrameView):
(WebKit::WebPage::getRectsForGranularityWithSelectionOffset):
(WebKit::WebPage::getRectsAtSelectionOffsetWithText):
(WebKit::WebPage::requestAutocorrectionData):
(WebKit::WebPage::requestDocumentEditingContext):
* Tools/TestWebKitAPI/Tests/WebKit/WKWebView/SiteIsolation-1.mm:
(TestWebKitAPI::expectRectInPositionedCrossOriginIframe):
(TestWebKitAPI::startInputSessionInCrossOriginIframe):
(TestWebKitAPI::TEST(SiteIsolation, AutocorrectionContextInCrossOriginIframe)):
(TestWebKitAPI::TEST(SiteIsolation, AutocorrectionRectsInCrossOriginIframe)):
(TestWebKitAPI::TEST(SiteIsolation,
AccessibilityRectsAtSelectionOffsetInCrossOriginIframe)):
(TestWebKitAPI::TEST(SiteIsolation, DocumentEditingContextInCrossOriginIframe)):
Canonical link: https://commits.webkit.org/322280@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
