Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: a51624926894020f4edb58d37cf9be69d8ae1aa6
https://github.com/WebKit/WebKit/commit/a51624926894020f4edb58d37cf9be69d8ae1aa6
Author: Dan Hecht <[email protected]>
Date: 2026-09-30 (Wed, 30 Sep 2026)
Changed paths:
M Source/JavaScriptCore/heap/Collector.cpp
M Source/JavaScriptCore/heap/GCRequest.cpp
M Source/JavaScriptCore/heap/GCRequest.h
Log Message:
-----------
[JSC] Remove GCRequest's unused didFinishEndPhase callback
https://bugs.webkit.org/show_bug.cgi?id=325776
rdar://188787440
Reviewed by Marcus Plutowski and Tadeu Zagallo.
A Collector that marks more than one Heap will take collection requests from
each of them, and a request will likely need to say which Heap it comes from: to
decide the scope from that Heap's state, and to let a Heap that goes away drop
its own pending requests. Let's clean up an unused field first.
GCRequest carried a callback for Collector::runEndPhase() to run once the
request was served. Nothing has ever set it: it came with GCRequest in
188598@main (2017), for a WebCore change that never used it. It still shaped how
requests are deduplicated, since GCRequest::subsumedBy() never treated a request
with a callback as covered by a queued one, so any change to what a request
carries would have had to keep that rule. Removing it leaves a request that is
only a scope.
No change in behavior.
* Source/JavaScriptCore/heap/Collector.cpp:
(JSC::Collector::runEndPhase):
* Source/JavaScriptCore/heap/GCRequest.cpp:
(JSC::GCRequest::subsumedBy const):
(JSC::GCRequest::dump const):
* Source/JavaScriptCore/heap/GCRequest.h:
Canonical link: https://commits.webkit.org/322293@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
