Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 4959b1648b53a46bf4702d58abaea17b81a7757c
https://github.com/WebKit/WebKit/commit/4959b1648b53a46bf4702d58abaea17b81a7757c
Author: Pascoe <[email protected]>
Date: 2026-09-30 (Wed, 30 Sep 2026)
Changed paths:
M Source/ThirdParty/ANGLE/ANGLE.xcodeproj/project.pbxproj
Log Message:
-----------
Fix Xcode null build regression caused by an unreachable group in
ANGLE.xcodeproj
rdar://problem/188763544
https://bugs.webkit.org/show_bug.cgi?id=325737
Reviewed by Elliott Williams, Megan Gardner, Richard Robinson, and Kimmo
Kinnunen.
321880@main added the "ANGLE wgpu backend" group to ANGLE.xcodeproj, but never
added it as a child of
another group. Xcode moves unreachable file references that are used by a build
phase into a
"Recovered References" group, and gives that group a new random identifier
every time the project is
loaded. This means Xcode's model of the ANGLE project is different in every
xcodebuild invocation, so
every build, including a null build, has to create a new build description and
rerun the tasks that
depend on it.
This regressed the Debug null build on the build-time bots by about 32%, from
12.9s to 17.1s and from
21.6s to 28.6s. CMake builds do not use Xcode's project model and were not
affected.
To fix this, add the group to the main group of the project. The group's file
references are relative
to the project root, which is where Xcode already placed them, so all files
resolve to the same paths.
Verified that ANGLE.xcodeproj now loads with the same project model in every
xcodebuild invocation.
* Source/ThirdParty/ANGLE/ANGLE.xcodeproj/project.pbxproj:
Canonical link: https://commits.webkit.org/322308@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
