Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: bcc6f0884172d76527d39aaabcd1b3369da04e46
https://github.com/WebKit/WebKit/commit/bcc6f0884172d76527d39aaabcd1b3369da04e46
Author: Tim Horton <[email protected]>
Date: 2026-09-30 (Wed, 30 Sep 2026)
Changed paths:
M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml
M Source/WebCore/page/Page.cpp
M Source/WebCore/page/Page.h
M Source/WebCore/page/QuirkBehaviors.h
M Source/WebCore/page/QuirkTable.cpp
M Source/WebCore/page/Quirks.cpp
M Source/WebCore/page/Quirks.h
M Source/WebCore/style/StyleAdjuster.cpp
M Source/WebCore/testing/Internals.cpp
M Source/WebCore/testing/Internals.h
M Source/WebCore/testing/Internals.idl
M Tools/TestWebKitAPI/Helpers/cocoa/WebPageConfiguration+Extras.swift
M Tools/TestWebKitAPI/Resources/cocoa/manipulation-surface.html
M Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj
M Tools/TestWebKitAPI/Tests/WebKit/WebPage/AppKit Gesture
Tests/BasicAppKitGesturesTests.swift
A Tools/TestWebKitAPI/Tests/WebKit/WebPage/AppKit Gesture
Tests/ManipulationSurfaceAppKitGesturesTests.swift
Log Message:
-----------
[AppKit Gestures] Reduce the scope of the manipulation surface quirks to only
apply to Google Maps embeds
https://bugs.webkit.org/show_bug.cgi?id=325829
rdar://187342282
Reviewed by Abrar Rahman Protyasha and Richard Robinson.
Tests: Tools/TestWebKitAPI/Tests/WebKit/WebPage/AppKit Gesture
Tests/ManipulationSurfaceAppKitGesturesTests.swift
* Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml:
Remove the global switch.
* Source/WebCore/page/Page.cpp:
(WebCore::Page::setQuirksSubframeURLForTesting):
* Source/WebCore/page/Page.h:
* Source/WebCore/testing/Internals.cpp:
(WebCore::Internals::resetToConsistentState):
(WebCore::Internals::setSubframeURLForQuirks):
* Source/WebCore/testing/Internals.h:
* Source/WebCore/testing/Internals.idl:
Add a mechanism to set a testing override URL that *subframes* resolve their
quirks against.
* Source/WebCore/page/QuirkBehaviors.h:
* Source/WebCore/page/QuirkTable.cpp:
* Source/WebCore/page/Quirks.cpp:
(WebCore::Quirks::needsGoogleMapsEmbedManipulationSurfaceQuirk const):
Add a quirk bit for Google Maps embeds.
(WebCore::Quirks::documentURL const):
(WebCore::Quirks::determineRelevantQuirks):
* Source/WebCore/page/Quirks.h:
Add a mechanism to set a testing override URL that *subframes* resolve their
quirks against.
* Source/WebCore/style/StyleAdjuster.cpp:
(WebCore::Style::adjustForManipulationSurfaceQuirk):
(WebCore::Style::Adjuster::adjustForSiteSpecificQuirks const):
Adjust style as needed if the quirk is enabled.
* Tools/TestWebKitAPI/Helpers/cocoa/WebPageConfiguration+Extras.swift:
(WebPage.withInternals(_:)):
Remove an incorrect comment, as tests themselves are linked into a binary that
doesn't have access to WebProcessPlugInWithInternals.
Add a method that actually works for getting Internals (since these extras are
built into a place that does).
* Tools/TestWebKitAPI/Resources/cocoa/manipulation-surface.html:
* Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* Tools/TestWebKitAPI/Tests/WebKit/WebPage/AppKit Gesture
Tests/BasicAppKitGesturesTests.swift:
* Tools/TestWebKitAPI/Tests/WebKit/WebPage/AppKit Gesture
Tests/ManipulationSurfaceAppKitGesturesTests.swift: Added.
(verticalDragOverManipulationSurface(_:reachesContent:)):
(horizontalDragOverManipulationSurface):
(loadManipulationSurface(_:)):
(manipulationSurfaceEvents() async throws -> (down:
Int:move:up:wheel:translation:)):
Adjust and expand these tests, make them fall into the quirk, and move them
into their own file.
Canonical link: https://commits.webkit.org/322315@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
