Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 12dd44cb41c55c5671ba6161e1e9251f84a786d6
https://github.com/WebKit/WebKit/commit/12dd44cb41c55c5671ba6161e1e9251f84a786d6
Author: Keith Miller <[email protected]>
Date: 2026-09-30 (Wed, 30 Sep 2026)
Changed paths:
M CMakeLists.txt
M Source/JavaScriptCore/JavaScriptCorePrefix.h
M Source/ThirdParty/libwebrtc/CMakeLists.txt
M Source/WebCore/testing/js/WebCoreTestSupportPrefix.h
M Source/WebKitLegacy/WebKitLegacyPrefix.h
M Source/cmake/OptionsCocoa.cmake
M Source/cmake/WebKitMacros.cmake
Log Message:
-----------
[CMake] Enable warnings in prefix headers
https://bugs.webkit.org/show_bug.cgi?id=325757
rdar://188773607
Reviewed by Elliott Williams.
CMake starts every generated cmake_pch.hxx with "#pragma clang system_header",
which hides warnings from
our prefix headers and makes the CMake build more lenient than the Xcode build.
Add WEBKIT_ENABLE_LANGUAGE,
which calls enable_language() and then sets CMAKE_PCH_PROLOGUE back to empty,
because enabling a C-family
language restores CMake's default.
Because a macro runs with the policies in effect where it was defined, this
change moves
the CMP0157 setting to right after cmake_minimum_required(), ahead of
include(WebKitCommon). Otherwise
Swift is enabled with CMP0157 treated as OLD, which creates a WebGPU
swiftmodule dependency cycle.
Without the pragma, the C definition of NULL in WebKitLegacyPrefix.h triggered
-Wmacro-redefined against clang's
<stddef.h>. That NULL block dates from 2003 and isn't needed anymore, this
patch removes it from the various
prefix headers.
Canonical link: https://commits.webkit.org/322347@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
