Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: b1cd9e0448185e4b4816b7ab551bc24698108f0f
https://github.com/WebKit/WebKit/commit/b1cd9e0448185e4b4816b7ab551bc24698108f0f
Author: Richard Robinson <[email protected]>
Date: 2026-09-30 (Wed, 30 Sep 2026)
Changed paths:
M LayoutTests/fast/quirks/active-quirks-by-domain-expected.txt
M LayoutTests/fast/quirks/active-quirks-by-domain.html
M LayoutTests/platform/glib/fast/quirks/active-quirks-by-domain-expected.txt
M LayoutTests/platform/ios/fast/quirks/active-quirks-by-domain-expected.txt
M LayoutTests/platform/ipad/fast/quirks/active-quirks-by-domain-expected.txt
M
LayoutTests/platform/mac-sequoia/fast/quirks/active-quirks-by-domain-expected.txt
M
LayoutTests/platform/mac-tahoe/fast/quirks/active-quirks-by-domain-expected.txt
M Source/WebCore/page/QuirkBehaviors.h
M Source/WebCore/page/QuirkSelectors.h
M Source/WebCore/page/QuirkTable.cpp
M Source/WebCore/page/Quirks.cpp
M Source/WebCore/page/Quirks.h
M Source/WebKit/Shared/Cocoa/InteractionInformationAtPosition.h
M Source/WebKit/Shared/Cocoa/InteractionInformationAtPosition.mm
M
Source/WebKit/Shared/Cocoa/InteractionInformationAtPosition.serialization.in
M Source/WebKit/UIProcess/mac/AppKitGestures/WKAppKitGestureController.mm
M Source/WebKit/WebProcess/WebPage/Cocoa/PositionInformationForWebPage.mm
A Tools/TestWebKitAPI/Resources/cocoa/unselectable-mail-list-item.html
M Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj
R Tools/TestWebKitAPI/Tests/WebKit/WebPage/AppKit Gesture
Tests/ManipulationSurfaceAppKitGesturesTests.swift
A Tools/TestWebKitAPI/Tests/WebKit/WebPage/AppKit Gesture
Tests/QuirksAppKitGesturesTests.swift
Log Message:
-----------
[AppKit Gestures] Sometimes can't invoke context menu on Outlook
https://bugs.webkit.org/show_bug.cgi?id=325872
rdar://187832523
Reviewed by Tim Horton.
Outlook's message list rows are `user-select: none`, and show the site's own
context menu from a
`contextmenu` handler. A long click only synthesizes the secondary click that
dispatches `contextmenu`
over selectable content, video, or a standalone image, so over these rows it
never does, and the menu
cannot be opened.
A long click over other unselectable content should still not open a context
menu in general, so fix
this with a quirk that lets a long click synthesize a secondary click over
Outlook's message list rows
even though they are unselectable.
Test: Tools/TestWebKitAPI/Tests/WebKit/WebPage/AppKit Gesture
Tests/QuirksAppKitGesturesTests.swift
* LayoutTests/fast/quirks/active-quirks-by-domain-expected.txt:
* Source/WebCore/page/QuirkBehaviors.h:
* Source/WebCore/page/QuirkSelectors.h:
* Source/WebCore/page/QuirkTable.cpp:
* Source/WebCore/page/Quirks.cpp:
(WebCore::Quirks::shouldTreatLongClickAsSecondaryClick const):
* Source/WebCore/page/Quirks.h:
* Source/WebKit/Shared/Cocoa/InteractionInformationAtPosition.h:
* Source/WebKit/Shared/Cocoa/InteractionInformationAtPosition.mm:
(WebKit::InteractionInformationAtPosition::InteractionInformationAtPosition):
* Source/WebKit/Shared/Cocoa/InteractionInformationAtPosition.serialization.in:
* Source/WebKit/UIProcess/mac/AppKitGestures/WKAppKitGestureController.mm:
(representsSecondaryClickableElement):
* Source/WebKit/WebProcess/WebPage/Cocoa/PositionInformationForWebPage.mm:
(WebKit::selectionPositionInformation):
* Tools/TestWebKitAPI/Resources/cocoa/unselectable-mail-list-item.html: Added.
* Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* Tools/TestWebKitAPI/Tests/WebKit/WebPage/AppKit Gesture
Tests/QuirksAppKitGesturesTests.swift: Renamed from
Tools/TestWebKitAPI/Tests/WebKit/WebPage/AppKit Gesture
Tests/ManipulationSurfaceAppKitGesturesTests.swift.
(AppKitGesturesTests.verticalDragOverManipulationSurface(_:reachesContent:)):
(AppKitGesturesTests.horizontalDragOverManipulationSurface):
(AppKitGesturesTests.clickAndHoldOnUnselectableMailListItemFiresContextMenuEventOnlyOnOutlook):
(ManipulationSurface.loadManipulationSurface(_:)):
(ManipulationSurface.manipulationSurfaceEvents() async throws -> (down:
Int:move:up:wheel:translation:)):
Canonical link: https://commits.webkit.org/322351@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
