[webkit-changes] [WebKit/WebKit] c95c0b: [Safer CPP] Address more warnings in Source/WebKit...

Wed, 30 Sep 2026 21:46:37 -0700 

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c95c0ba164f97fb789aa5db695cd7bec1791ad79
      
https://github.com/WebKit/WebKit/commit/c95c0ba164f97fb789aa5db695cd7bec1791ad79
  Author: Chris Dumez <[email protected]>
  Date:   2026-09-30 (Wed, 30 Sep 2026)

  Changed paths:
    M Source/WebCore/history/BackForwardClient.h
    M Source/WebCore/loader/DocumentLoader.h
    M Source/WebKit/Platform/cocoa/PaymentAuthorizationPresenter.mm
    M Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm
    M Source/WebKitLegacy/PlatformCocoa.cmake
    M Source/WebKitLegacy/SaferCPPExpectations/ForwardDeclCheckerExpectations
    M 
Source/WebKitLegacy/SaferCPPExpectations/MemoryUnsafeCastCheckerExpectations
    M 
Source/WebKitLegacy/SaferCPPExpectations/NoUncheckedPtrMemberCheckerExpectations
    M 
Source/WebKitLegacy/SaferCPPExpectations/NoUncountedMemberCheckerExpectations
    M 
Source/WebKitLegacy/SaferCPPExpectations/NoUnretainedMemberCheckerExpectations
    M 
Source/WebKitLegacy/SaferCPPExpectations/RetainPtrCtorAdoptCheckerExpectations
    M 
Source/WebKitLegacy/SaferCPPExpectations/UncheckedCallArgsCheckerExpectations
    M 
Source/WebKitLegacy/SaferCPPExpectations/UncheckedLocalVarsCheckerExpectations
    M 
Source/WebKitLegacy/SaferCPPExpectations/UncountedCallArgsCheckerExpectations
    M 
Source/WebKitLegacy/SaferCPPExpectations/UncountedLocalVarsCheckerExpectations
    M 
Source/WebKitLegacy/SaferCPPExpectations/UnretainedCallArgsCheckerExpectations
    M 
Source/WebKitLegacy/SaferCPPExpectations/UnretainedLambdaCapturesCheckerExpectations
    M 
Source/WebKitLegacy/SaferCPPExpectations/UnretainedLocalVarsCheckerExpectations
    M Source/WebKitLegacy/WebKitLegacy.xcodeproj/project.pbxproj
    M Source/WebKitLegacy/ios/WebCoreSupport/PopupMenuIOS.h
    M Source/WebKitLegacy/ios/WebCoreSupport/WebChromeClientIOS.mm
    M Source/WebKitLegacy/ios/WebCoreSupport/WebFixedPositionContent.mm
    M Source/WebKitLegacy/ios/WebCoreSupport/WebFrameIOS.mm
    M Source/WebKitLegacy/ios/WebCoreSupport/WebVisiblePosition.mm
    M Source/WebKitLegacy/mac/History/BackForwardList.h
    M Source/WebKitLegacy/mac/Misc/WebDownload.h
    M Source/WebKitLegacy/mac/Misc/WebDownload.mm
    M Source/WebKitLegacy/mac/Misc/WebElementDictionary.h
    M Source/WebKitLegacy/mac/Misc/WebElementDictionary.mm
    M Source/WebKitLegacy/mac/Misc/WebKitErrors.h
    R Source/WebKitLegacy/mac/Misc/WebKitErrors.m
    A Source/WebKitLegacy/mac/Misc/WebKitErrors.mm
    M Source/WebKitLegacy/mac/Misc/WebKitNSStringExtras.h
    M Source/WebKitLegacy/mac/Misc/WebKitNSStringExtras.mm
    R Source/WebKitLegacy/mac/Misc/WebNSImageExtras.m
    A Source/WebKitLegacy/mac/Misc/WebNSImageExtras.mm
    M Source/WebKitLegacy/mac/Misc/WebNSObjectExtras.mm
    M Source/WebKitLegacy/mac/Misc/WebNSPasteboardExtras.h
    M Source/WebKitLegacy/mac/Misc/WebNSPasteboardExtras.mm
    R Source/WebKitLegacy/mac/Misc/WebNSViewExtras.m
    A Source/WebKitLegacy/mac/Misc/WebNSViewExtras.mm
    M Source/WebKitLegacy/mac/Misc/WebSharingServicePickerController.h
    M Source/WebKitLegacy/mac/Misc/WebSharingServicePickerController.mm
    M Source/WebKitLegacy/mac/Misc/WebStringTruncator.mm
    M Source/WebKitLegacy/mac/Misc/WebUserContentURLPattern.h
    M Source/WebKitLegacy/mac/Misc/WebUserContentURLPattern.mm
    M Source/WebKitLegacy/mac/Plugins/WebPluginPackage.mm
    M Source/WebKitLegacy/mac/Plugins/WebPluginViewFactory.h
    M Source/WebKitLegacy/mac/Plugins/WebPluginViewFactoryPrivate.h
    M Source/WebKitLegacy/mac/WebCoreSupport/PopupMenuMac.mm
    M Source/WebKitLegacy/mac/WebCoreSupport/WebAlternativeTextClient.h
    M Source/WebKitLegacy/mac/WebCoreSupport/WebChromeClient.mm
    M Source/WebKitLegacy/mac/WebCoreSupport/WebContextMenuClient.mm
    M Source/WebKitLegacy/mac/WebCoreSupport/WebDragClient.h
    M Source/WebKitLegacy/mac/WebCoreSupport/WebDragClient.mm
    M Source/WebKitLegacy/mac/WebCoreSupport/WebEditorClient.h
    M Source/WebKitLegacy/mac/WebCoreSupport/WebEditorClient.mm
    M Source/WebKitLegacy/mac/WebCoreSupport/WebFrameLoaderClient.mm
    M Source/WebKitLegacy/mac/WebCoreSupport/WebGeolocationClient.h
    M Source/WebKitLegacy/mac/WebCoreSupport/WebGeolocationClient.mm
    M Source/WebKitLegacy/mac/WebCoreSupport/WebInspectorClient.mm
    M Source/WebKitLegacy/mac/WebCoreSupport/WebNotificationClient.h
    M Source/WebKitLegacy/mac/WebCoreSupport/WebProgressTrackerClient.h
    M Source/WebKitLegacy/mac/WebCoreSupport/WebProgressTrackerClient.mm
    M Source/WebKitLegacy/mac/WebCoreSupport/WebValidationMessageClient.h
    M Source/WebKitLegacy/mac/WebInspector/WebInspector.h
    M Source/WebKitLegacy/mac/WebInspector/WebInspector.mm
    M Source/WebKitLegacy/mac/WebView/WebDocumentLoaderMac.h
    M Source/WebKitLegacy/mac/WebView/WebPolicyDelegate.h
    M Source/WebKitLegacy/mac/WebView/WebPolicyDelegate.mm
    M Source/WebKitLegacy/mac/WebView/WebPolicyDelegatePrivate.h
    M Source/WebKitLegacy/mac/WebView/WebView.h
    M Source/WebKitLegacy/mac/WebView/WebView.mm
    M Source/WebKitLegacy/mac/WebView/WebViewInternal.h
    M Source/WebKitLegacy/mac/WebView/WebViewPrivate.h

  Log Message:
  -----------
  [Safer CPP] Address more warnings in Source/WebKitLegacy
https://bugs.webkit.org/show_bug.cgi?id=325790

Reviewed by Anne van Kesteren.

Address most static analysis warnings in mac/WebCoreSupport, ios/WebCoreSupport 
and mac/Misc.

Make exported NSString globals `const` so the static analyzer trusts them. Add 
downcast<>
support for WebDocumentLoaderMac and BackForwardList. Rename WebKitErrors.m, 
WebNSImageExtras.m
and WebNSViewExtras.m to .mm so they can use smart pointers.

* Source/WebCore/history/BackForwardClient.h:
* Source/WebCore/loader/DocumentLoader.h:
* Source/WebKitLegacy/*:

Canonical link: https://commits.webkit.org/322353@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications

Reply via email to