Modified: trunk/Tools/ChangeLog (116040 => 116041)
--- trunk/Tools/ChangeLog 2012-05-03 23:39:23 UTC (rev 116040)
+++ trunk/Tools/ChangeLog 2012-05-03 23:41:21 UTC (rev 116041)
@@ -1,3 +1,20 @@
+2012-05-03 Ojan Vafai <o...@chromium.org>
+
+ Remove the percent failed column from the flakiness dashboard
+ https://bugs.webkit.org/show_bug.cgi?id=85552
+
+ Reviewed by Dirk Pranke.
+
+ This column isn't useful enough to justify the visual noise.
+
+ * TestResultServer/static-dashboards/flakiness_dashboard.js:
+ (processMissingAndExtraExpectations):
+ (tableHeaders):
+ (htmlForSingleTestRow):
+ (sortTests):
+ * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
+ (test):
+
2012-05-03 Eric Seidel <e...@webkit.org>
--coverage should not not use the "feature" options system in build-webkit, similarly remove special-casing for WTF_URL
Modified: trunk/Tools/TestResultServer/static-dashboards/flakiness_dashboard.js (116040 => 116041)
--- trunk/Tools/TestResultServer/static-dashboards/flakiness_dashboard.js 2012-05-03 23:39:23 UTC (rev 116040)
+++ trunk/Tools/TestResultServer/static-dashboards/flakiness_dashboard.js 2012-05-03 23:41:21 UTC (rev 116041)
@@ -238,7 +238,6 @@
modifiers: '',
expectations : '',
rawResults: '',
- percentFailed: 0,
// List of all the results the test actually has.
actualResults: []
};
@@ -780,7 +779,6 @@
var numResultsSeen = 0;
var haveSeenNonFlakeResult = false;
var numRealResults = 0;
- var failedCount = 0;
var seenResults = {};
for (var i = 0; i < rawResults.length; i++) {
@@ -788,8 +786,6 @@
numResultsSeen += numResults;
var result = rawResults[i][RLE.VALUE];
- if (isFailingResult(result))
- failedCount += numResults;
var hasMinRuns = numResults >= MIN_RUNS_FOR_FLAKE;
if (haveSeenNonFlakeResult && hasMinRuns)
@@ -811,8 +807,6 @@
resultsForTest.flips = i - 1;
resultsForTest.isFlaky = numRealResults > 1;
- // Calculate the % of times the test failed - how flaky is it?
- resultsForTest.percentFailed = Math.round(failedCount / numResultsSeen * 100);
var missingExpectations = [];
var extraExpectations = [];
@@ -1160,7 +1154,7 @@
if (isLayoutTestResults() || opt_getAll)
headers.push('bugs', 'modifiers', 'expectations');
- headers.push('slowest run', '% fail', 'flakiness (numbers are runtimes in seconds)');
+ headers.push('slowest run', 'flakiness (numbers are runtimes in seconds)');
return headers;
}
@@ -1196,8 +1190,6 @@
html += '<td class=options-container>' + test.expectations;
else if (startsWith(header, 'slowest'))
html += '<td>' + (test.slowestTime ? test.slowestTime + 's' : '');
- else if (startsWith(header, '% fail'))
- html += '<td>' + test.percentFailed;
else if (startsWith(header, 'flakiness'))
html += htmlForTestResults(test, isCrossBuilderView());
}
@@ -1309,9 +1301,6 @@
} else if (column == 'slowest') {
sortFunctionGetter = numericSort;
resultsProperty = 'slowestTime';
- } else if (column == '%') {
- sortFunctionGetter = numericSort;
- resultsProperty = 'percentFailed';
} else {
sortFunctionGetter = alphanumericCompare;
resultsProperty = column;
Modified: trunk/Tools/TestResultServer/static-dashboards/flakiness_dashboard_unittests.js (116040 => 116041)
--- trunk/Tools/TestResultServer/static-dashboards/flakiness_dashboard_unittests.js 2012-05-03 23:39:23 UTC (rev 116040)
+++ trunk/Tools/TestResultServer/static-dashboards/flakiness_dashboard_unittests.js 2012-05-03 23:41:21 UTC (rev 116041)
@@ -366,7 +366,6 @@
'<th sortValue=modifiers><div class=table-header-content><span></span><span class=header-text>modifiers</span></div></th>' +
'<th sortValue=expectations><div class=table-header-content><span></span><span class=header-text>expectations</span></div></th>' +
'<th sortValue=slowest><div class=table-header-content><span></span><span class=header-text>slowest run</span></div></th>' +
- '<th sortValue=%><div class=table-header-content><span></span><span class=header-text>% fail</span></div></th>' +
'<th sortValue=flakiness colspan=10000><div class=table-header-content><span></span><span class=header-text>flakiness (numbers are runtimes in seconds)</span></div></th>' +
'</tr></thead>' +
'<tbody></tbody>' +
@@ -399,7 +398,6 @@
'<th sortValue=modifiers><div class=table-header-content><span></span><span class=header-text>modifiers</span></div></th>' +
'<th sortValue=expectations><div class=table-header-content><span></span><span class=header-text>expectations</span></div></th>' +
'<th sortValue=slowest><div class=table-header-content><span></span><span class=header-text>slowest run</span></div></th>' +
- '<th sortValue=%><div class=table-header-content><span></span><span class=header-text>% fail</span></div></th>' +
'<th sortValue=flakiness colspan=10000><div class=table-header-content><span></span><span class=header-text>flakiness (numbers are runtimes in seconds)</span></div></th>' +
'</tr></thead>' +
'<tbody></tbody>' +
@@ -464,7 +462,7 @@
'<td class=options-container><a href="" class="file-bug">FILE BUG</a>' +
'<td class=options-container>' +
'<td class=options-container>' +
- '<td><td>0<td title="TEXT. Click for more info." class="results F" _onclick_=\'showPopupForBuild(event, "dummyBuilder",0,"foo/exists.html")\'> ' +
+ '<td><td title="TEXT. Click for more info." class="results F merge" _onclick_=\'showPopupForBuild(event, "dummyBuilder",0,"foo/exists.html")\'> ' +
'<td title="IMAGE. Click for more info." class="results I" _onclick_=\'showPopupForBuild(event, "dummyBuilder",1,"foo/exists.html")\'>5';
equal(htmlForSingleTestRow(test), expected);
