Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: e5f751c78bd0c12d362e6cf4a8ff075af7b13021
https://github.com/WebKit/WebKit/commit/e5f751c78bd0c12d362e6cf4a8ff075af7b13021
Author: Yusuke Suzuki <[email protected]>
Date: 2026-10-10 (Sat, 10 Oct 2026)
Changed paths:
M Source/JavaScriptCore/bytecompiler/NodesCodegen.cpp
M Source/JavaScriptCore/parser/ASTBuilder.h
M Source/JavaScriptCore/parser/Nodes.cpp
M Source/JavaScriptCore/parser/Nodes.h
M Source/JavaScriptCore/parser/Parser.cpp
M Source/JavaScriptCore/parser/Parser.h
Log Message:
-----------
[JSC] Use Vector<JSValue> in Parser as GC is deferred
https://bugs.webkit.org/show_bug.cgi?id=326985
rdar://189608129
Reviewed by Dan Hecht.
Let's use Vector<JSValue> as Parser is under DeferGC scope, so it is
safe. We added ASSERT to confirm this. Also we dropped m_numConstants as
it is no longer used.
* Source/JavaScriptCore/bytecompiler/NodesCodegen.cpp:
(JSC::ArrayNode::emitBytecode):
* Source/JavaScriptCore/parser/ASTBuilder.h:
(JSC::ASTBuilder::features const):
(JSC::ASTBuilder::createVoid):
(JSC::ASTBuilder::createArray):
(JSC::ASTBuilder::createDoubleExpr):
(JSC::ASTBuilder::createIntegerExpr):
(JSC::ASTBuilder::createBigInt):
(JSC::ASTBuilder::createString):
(JSC::ASTBuilder::createBoolean):
(JSC::ASTBuilder::createNull):
(JSC::ASTBuilder::numConstants const): Deleted.
(JSC::ASTBuilder::Scope::Scope): Deleted.
(JSC::ASTBuilder::incConstants): Deleted.
* Source/JavaScriptCore/parser/Nodes.cpp:
(JSC::ScopeNode::ScopeNode):
(JSC::ProgramNode::ProgramNode):
(JSC::ModuleProgramNode::ModuleProgramNode):
(JSC::EvalNode::EvalNode):
(JSC::FunctionNode::FunctionNode):
* Source/JavaScriptCore/parser/Nodes.h:
(JSC::ScopeNode::neededConstants): Deleted.
* Source/JavaScriptCore/parser/Parser.cpp:
(JSC::Parser<LexerType>::parseInner):
* Source/JavaScriptCore/parser/Parser.h:
(JSC::Parser<LexerType>::parse):
Canonical link: https://commits.webkit.org/323287@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
