Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 7835dba62c887e26543ad9e812fcbe81124cdf66
https://github.com/WebKit/WebKit/commit/7835dba62c887e26543ad9e812fcbe81124cdf66
Author: BJ Burg <[email protected]>
Date: 2026-10-10 (Sat, 10 Oct 2026)
Changed paths:
M LayoutTests/TestExpectations
M LayoutTests/inspector/timeline/recording-start-stop-timestamps.html
M LayoutTests/inspector/timeline/resources/timeline-event-utilities.js
M LayoutTests/inspector/timeline/timeline-recording-autocapture.html
M LayoutTests/inspector/timeline/timeline-recording.html
M LayoutTests/platform/mac-wk2/TestExpectations
M LayoutTests/platform/mac/TestExpectations
M Source/WebInspectorUI/UserInterface/Controllers/DebuggerManager.js
M Source/WebInspectorUI/UserInterface/Controllers/TimelineManager.js
M Source/WebInspectorUI/UserInterface/Views/SourcesNavigationSidebarPanel.js
M Source/WebInspectorUI/UserInterface/Views/TimelineOverview.js
M Source/WebInspectorUI/UserInterface/Views/TimelineRecordingContentView.js
M Source/WebInspectorUI/UserInterface/Views/TimelineRecordingProgressView.js
M Source/WebInspectorUI/UserInterface/Views/TimelineTabContentView.js
Log Message:
-----------
Revert "REGRESSION(302776@main): Made
inspector/timeline/timeline-event-TimerInstall.html flakey"
https://bugs.webkit.org/show_bug.cgi?id=325215
rdar://187714642
Reviewed by Qianlang Chen.
This reverts commit daecaef2cb817911209fd87b2250903593139b7e (303033@main).
That change deferred the WI.TimelineManager.Event.CapturingStateChanged
dispatch for the Active and Inactive states until after pending backend
dispatches had drained. With the per-instrument count guard already
removed in 302776@main, a second Timeline recording can begin before the
previous recording's deferred Inactive dispatch drains. Listeners then
receive a stale Inactive after the live Active, treat the second recording
as stopped, and stop rendering its records -- so every Timeline recording
after the first shows empty rows. The failure is racy on single-process
pages and consistent across a cross-origin navigation.
Reverting restores the synchronous CapturingStateChanged dispatch and the
_updateCapturingState helper, which resolves the empty-rows regression.
This re-introduces the flakiness in
inspector/timeline/timeline-event-TimerInstall.html that 303033@main had
masked, so that test is skipped here until the underlying capturing-state
event ordering is fixed forward.
* LayoutTests/TestExpectations: Skip the flaky test until the fix-forward lands.
* LayoutTests/platform/mac/TestExpectations: Skip it on mac too, since
inspector/timeline is [ Pass Timeout ] there.
* LayoutTests/platform/mac-wk2/TestExpectations: Turn the existing
[ Pass Crash ] line into a Skip so it doesn't override the mac skip.
* LayoutTests/inspector/timeline/recording-start-stop-timestamps.html:
* LayoutTests/inspector/timeline/resources/timeline-event-utilities.js:
* LayoutTests/inspector/timeline/timeline-recording-autocapture.html:
This test landed after 303033@main and read event.data.capturingState,
which is no longer sent. Read WI.timelineManager.capturingState instead.
* LayoutTests/inspector/timeline/timeline-recording.html:
* Source/WebInspectorUI/UserInterface/Controllers/DebuggerManager.js:
* Source/WebInspectorUI/UserInterface/Controllers/TimelineManager.js:
* Source/WebInspectorUI/UserInterface/Views/SourcesNavigationSidebarPanel.js:
* Source/WebInspectorUI/UserInterface/Views/TimelineOverview.js:
* Source/WebInspectorUI/UserInterface/Views/TimelineRecordingContentView.js:
* Source/WebInspectorUI/UserInterface/Views/TimelineRecordingProgressView.js:
* Source/WebInspectorUI/UserInterface/Views/TimelineTabContentView.js:
Canonical link: https://commits.webkit.org/323301@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
