Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 8395e1e465d298a66c08596741aec47367604bdd
https://github.com/WebKit/WebKit/commit/8395e1e465d298a66c08596741aec47367604bdd
Author: Ryosuke Niwa <[email protected]>
Date: 2026-10-10 (Sat, 10 Oct 2026)
Changed paths:
M
LayoutTests/fast/forms/ios/keydown-in-hidden-contenteditable-with-inputmode-none.html
M LayoutTests/http/tests/site-isolation/key-events.html
M Tools/WebKitTestRunner/TestController.h
M Tools/WebKitTestRunner/ios/TestControllerIOS.mm
M Tools/WebKitTestRunner/ios/UIScriptControllerIOS.mm
Log Message:
-----------
[Site Isolation] http/tests/site-isolation/key-events.html and
type-in-cross-origin-iframe.html are still flaky
https://bugs.webkit.org/show_bug.cgi?id=327034
Reviewed by Abrar Rahman Protyasha and Aditya Keerthi.
322973@main restored the US English QWERTY input mode between tests but
http/tests/site-isolation/key-events.html
and fast/forms/ios/keydown-in-hidden-contenteditable-with-inputmode-none.html
still intermittently receive Cyrillic
characters (e.g. "x" becomes "ч" and "a" becomes "ф").
These tests attach the hardware keyboard in the middle of the test via
UIHelper.setHardwareKeyboardAttached,
which makes UIKit pick an input mode that matches the hardware keyboard after
we had already restored the default
input mode in TestController::platformResetStateToConsistentValues.
Fixed the bug by restoring the default input mode after attaching the hardware
keyboard, and by making these two
tests use the useHardwareKeyboardMode test option so that the hardware keyboard
is attached before the default input
mode is restored.
*
LayoutTests/fast/forms/ios/keydown-in-hidden-contenteditable-with-inputmode-none.html:
* LayoutTests/http/tests/site-isolation/key-events.html:
* Tools/WebKitTestRunner/TestController.h:
* Tools/WebKitTestRunner/ios/TestControllerIOS.mm:
(WTR::TestController::platformResetStateToConsistentValues):
(WTR::TestController::restoreDefaultKeyboardInputModeIfNeeded):
* Tools/WebKitTestRunner/ios/UIScriptControllerIOS.mm:
(WTR::UIScriptControllerIOS::setHardwareKeyboardAttached):
Canonical link: https://commits.webkit.org/323338@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
