Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 6e76315e975ff625ecc15e521a91230cc0d3b24c
https://github.com/WebKit/WebKit/commit/6e76315e975ff625ecc15e521a91230cc0d3b24c
Author: Alan Baradlay <[email protected]>
Date: 2026-10-10 (Sat, 10 Oct 2026)
Changed paths:
M Source/WebCore/layout/formattingContexts/flex/FlexFormattingContext.cpp
M Source/WebCore/layout/formattingContexts/flex/FlexFormattingContext.h
M Source/WebCore/layout/formattingContexts/flex/FlexFormattingUtils.cpp
Log Message:
-----------
[cleanup] Remove redundant copies and declarations in the flex formatting
context
https://bugs.webkit.org/show_bug.cgi?id=327095
<rdar://problem/189707453>
Reviewed by Antti Koivisto.
1. Bind the flex item's min, max and preferred main size style values by
reference instead of copying them in
ensureBlockAxisContentSizeForFlexItemIfNeeded, minMaxMainSizesForFlexItem,
computeUsedMaxMainSize and
computeContentBasedMinMainSize.
2. Remove the forward declaration of FlexLines a few lines above its
definition; nothing in between uses it.
3. Remove the stray semicolon in marginBoxAscentForFlexItem.
No change in behavior.
* Source/WebCore/layout/formattingContexts/flex/FlexFormattingContext.cpp:
(WebCore::FlexFormattingContext::ensureBlockAxisContentSizeForFlexItemIfNeeded):
(WebCore::FlexFormattingContext::minMaxMainSizesForFlexItem):
(WebCore::FlexFormattingContext::computeUsedMaxMainSize):
(WebCore::FlexFormattingContext::computeContentBasedMinMainSize):
* Source/WebCore/layout/formattingContexts/flex/FlexFormattingContext.h:
* Source/WebCore/layout/formattingContexts/flex/FlexFormattingUtils.cpp:
(WebCore::FlexFormattingUtils::marginBoxAscentForFlexItem const):
Canonical link: https://commits.webkit.org/323352@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
