Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 0e835eed8c54741df71026576847b15a2b50e033
https://github.com/WebKit/WebKit/commit/0e835eed8c54741df71026576847b15a2b50e033
Author: Chris Dumez <[email protected]>
Date: 2026-10-11 (Sun, 11 Oct 2026)
Changed paths:
M Source/WebCore/css/CSSBackgroundRepeatValue.h
M Source/WebCore/css/CSSCounterStyleDescriptors.h
M Source/WebCore/css/CSSCounterStyleRegistry.h
M Source/WebCore/css/CSSFunctionValue.h
M Source/WebCore/css/CSSPropertyInitialValues.h
M Source/WebCore/css/CSSValue.h
M Source/WebCore/css/CSSValueKeywords.in
M Source/WebCore/css/CSSValuePool.h
M Source/WebCore/css/StyleProperties.h
M Source/WebCore/css/calc/CSSCalcTree+Parser.cpp
M Source/WebCore/css/calc/CSSCalcTree+Parser.h
M Source/WebCore/css/parser/CSSParserFastPaths.cpp
M Source/WebCore/css/parser/CSSParserToken.cpp
M Source/WebCore/css/parser/CSSPropertyParser.h
M Source/WebCore/css/parser/CSSPropertyParserConsumer+Anchor.h
M Source/WebCore/css/parser/CSSPropertyParserConsumer+Animations.h
M Source/WebCore/css/parser/CSSPropertyParserConsumer+Color.h
M Source/WebCore/css/parser/CSSPropertyParserConsumer+CounterStyles.h
M Source/WebCore/css/parser/CSSPropertyParserConsumer+Font.h
M Source/WebCore/css/parser/CSSPropertyParserConsumer+Grid.h
M Source/WebCore/css/parser/CSSPropertyParserConsumer+Timeline.h
M Source/WebCore/css/scripts/process-css-properties.py
M Source/WebCore/css/scripts/process-css-values.py
M
Source/WebCore/css/scripts/test/TestCSSPropertiesResults/CSSPropertyInitialValuesGeneratedInlines.h
M
Source/WebCore/css/scripts/test/TestCSSPropertiesResults/CSSPropertyNames.gperf
M
Source/WebCore/css/scripts/test/TestCSSPropertiesResults/CSSPropertyParsing.cpp
M Source/WebCore/css/values/color/CSSKeywordColor.h
M Source/WebCore/css/values/primitives/CSSPrimitiveNumericConcepts.h
M Source/WebCore/dom/StyledElement.h
M Source/WebCore/dom/ViewTransition.cpp
M Source/WebCore/editing/ApplyStyleCommand.cpp
M Source/WebCore/editing/EditingStyle.cpp
M Source/WebCore/editing/EditingStyle.h
M Source/WebCore/platform/graphics/FontCascadeDescription.h
M Source/WebCore/rendering/CSSValueKey.h
M Source/WebCore/rendering/RenderTheme.h
M Source/WebCore/rendering/ios/RenderThemeIOS.mm
M Source/WebCore/style/AnchorPositionEvaluator.cpp
M Source/WebCore/style/StyleBuilderCustom.h
M Source/WebCore/style/StyleBuilderState.cpp
M Source/WebCore/style/StyleExtractor.cpp
M Source/WebCore/style/StyleExtractor.h
M Source/WebCore/style/StyleFontSizeFunctions.cpp
M Source/WebCore/style/StyleFontSizeFunctions.h
M Source/WebCore/style/StyleResolveForFont.cpp
M Source/WebCore/style/StyleSubstitutionResolver.h
M Source/WebCore/style/values/animations/StyleSingleAnimationRangeName.h
M Source/WebCore/style/values/primitives/StyleKeyword+Mappings.h
M Source/WebCore/style/values/shapes/StyleShapeForward.h
M Tools/Scripts/webkitpy/style/checkers/cpp.py
M Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py
Log Message:
-----------
Make CSSValueID an enum class
https://bugs.webkit.org/show_bug.cgi?id=326978
Reviewed by Sam Weinig.
Convert CSSValueID from an unscoped enum to `enum class CSSValueID : uint16_t`
with unprefixed enumerators (e.g. CSSValueID::Auto instead of CSSValueAuto).
To keep this patch reviewable, the generator still emits the legacy
CSSValueFoo names as constexpr constants aliasing the new enumerators. Call
sites will be migrated in follow-up patches, after which the constants will be
removed. A new style check (readability/css_value_id) prevents new uses of the
legacy names in the meantime.
This patch only updates code that relied on implicit integer conversion
(arithmetic, boolean tests, indexing, int storage) and the existing
CSSValueID::CSSValueFoo uses. No behavior change.
* Source/WebCore/css/scripts/process-css-values.py:
* Source/WebCore/css/scripts/process-css-properties.py:
* Source/WebCore/css/scripts/test/TestCSSPropertiesResults/*: Rebaselined.
* Source/WebCore/editing/ApplyStyleCommand.cpp:
* Source/WebCore/editing/EditingStyle.cpp:
* Source/WebCore/platform/graphics/FontCascadeDescription.h:
* Source/WebCore/style/StyleFontSizeFunctions.cpp:
(WebCore::Style::fontSizeForKeyword): Take a CSSValueID instead of unsigned.
* Source/WebCore/style/values/primitives/StyleKeyword+Mappings.h:
* Source/WebCore/rendering/CSSValueKey.h:
* Source/WebCore/rendering/RenderTheme.h:
* Source/WebCore/rendering/ios/RenderThemeIOS.mm:
* Source/WebCore/css/...: Update forward declarations to enum class.
* Tools/Scripts/webkitpy/style/checkers/cpp.py:
(check_css_value_id): Added.
* Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py:
(CppStyleTest.test_css_value_id): Added.
Canonical link: https://commits.webkit.org/323378@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
