Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 4fc253b3b03c475575f5f4edd1b1406bec0697c7
https://github.com/WebKit/WebKit/commit/4fc253b3b03c475575f5f4edd1b1406bec0697c7
Author: Tim Horton <[email protected]>
Date: 2026-10-11 (Sun, 11 Oct 2026)
Changed paths:
M Source/WebKit/UIProcess/mac/AppKitGestures/WKAppKitGestureController.mm
M Source/WebKit/UIProcess/mac/AppKitGestures/WKPressGestureRecognizer.h
M Source/WebKit/UIProcess/mac/AppKitGestures/WKPressGestureRecognizer.swift
M Tools/TestWebKitAPI/Tests/WebKit/WebPage/AppKit Gesture
Tests/BasicAppKitGesturesTests.swift
Log Message:
-----------
[AppKit Gestures] Live Text gestures can cause drag and drop gesture to be
deferred indefinitely
https://bugs.webkit.org/show_bug.cgi?id=327118
rdar://189563434
Reviewed by Abrar Rahman Protyasha.
Because press gestures don't inform the client when they fail, we can end up
with
the Live Text deferral gestures stuck deferring everything downstream of them.
Watch for failure, and reset the deferral state if it comes (either before
or after the image analysis results return).
Test: Tools/TestWebKitAPI/Tests/WebKit/WebPage/AppKit Gesture
Tests/BasicAppKitGesturesTests.swift
* Source/WebKit/UIProcess/mac/AppKitGestures/WKAppKitGestureController.mm:
(-[WKAppKitGestureController setUpImageAnalysisGestureRecognizer]):
(-[WKAppKitGestureController _resolveImageAnalysisDeferralsWithOutcome:]):
(-[WKAppKitGestureController pressGestureRecognizerDidFail:]):
(-[WKAppKitGestureController
deferringGestureRecognizer:shouldDeferGesturesForEventThatWillBeginAction:]):
* Source/WebKit/UIProcess/mac/AppKitGestures/WKPressGestureRecognizer.h:
* Source/WebKit/UIProcess/mac/AppKitGestures/WKPressGestureRecognizer.swift:
(WKPressGestureRecognizer.pressDelegate):
(WKPressGestureRecognizer.state):
* Tools/TestWebKitAPI/Tests/WebKit/WebPage/AppKit Gesture
Tests/BasicAppKitGesturesTests.swift:
Canonical link: https://commits.webkit.org/323392@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
