Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: d1111168cc33884a158151387b1b813ebc232a9d
      
https://github.com/WebKit/WebKit/commit/d1111168cc33884a158151387b1b813ebc232a9d
  Author: Anne van Kesteren <[email protected]>
  Date:   2026-10-11 (Sun, 11 Oct 2026)

  Changed paths:
    A 
LayoutTests/accessibility/isolated-tree/mac/base-select-picker-hit-test-expected.txt
    A 
LayoutTests/accessibility/isolated-tree/mac/base-select-picker-hit-test.html
    A LayoutTests/accessibility/mac/base-select-picker-hit-test-expected.txt
    A LayoutTests/accessibility/mac/base-select-picker-hit-test.html
    M Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.cpp

  Log Message:
  -----------
  AX: approximate isolated tree hit testing misses the options of an open base 
appearance picker
https://bugs.webkit.org/show_bug.cgi?id=327154
rdar://189745237

Reviewed by Tyler Wilcock.

AXIsolatedObject::approximateHitTest() skips the children of an object whose 
bounds do not
contain the point. The picker of a base appearance select is a child of the 
select, but it is in
the top layer and can be positioned anywhere, for instance below the select, as 
it is by default.
Hit testing its options outside the bounds of the select then returned the web 
area. Layout tests
always use this hit test, and other clients use it when the main thread does 
not answer in time.

Also check the children of an expanded object, which can have a popup outside 
its bounds, but
still only return the object itself when it contains the point. Its ancestors 
still have to
contain the point.

Tests: accessibility/isolated-tree/mac/base-select-picker-hit-test.html
       accessibility/mac/base-select-picker-hit-test.html

Canonical link: https://commits.webkit.org/323413@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications

Reply via email to