Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 85c8e83b1933f57e78539c39307974712748ae37
https://github.com/WebKit/WebKit/commit/85c8e83b1933f57e78539c39307974712748ae37
Author: Zak Ridouh <[email protected]>
Date: 2026-10-12 (Mon, 12 Oct 2026)
Changed paths:
A
LayoutTests/http/tests/site-isolation/inspector/network/resource-caching-disabled-setting-expected.txt
A
LayoutTests/http/tests/site-isolation/inspector/network/resource-caching-disabled-setting.html
A
LayoutTests/http/tests/site-isolation/inspector/network/resources/.htaccess
A
LayoutTests/http/tests/site-isolation/inspector/network/resources/cacheable-static-resource.txt
A
LayoutTests/inspector/network/resource-caching-disabled-setting-with-worker-expected.txt
A
LayoutTests/inspector/network/resource-caching-disabled-setting-with-worker.html
M Source/WebInspectorUI/UserInterface/Base/Main.js
M Source/WebInspectorUI/UserInterface/Controllers/NetworkManager.js
Log Message:
-----------
[Site Isolation] Web Inspector: Disable Caches throws with workers and never
reaches cross-origin frames
https://bugs.webkit.org/show_bug.cgi?id=325771
rdar://189376044
Reviewed by BJ Burg.
Toggling "Disable Caches" threw "undefined is not an object (evaluating
'target.NetworkAgent.setResourceCachingDisabled')" on any page with a worker,
because the
handler sent the command to every target except frame targets, and worker
targets have no
Network domain. Under Site Isolation the handler also never sent it to the
multiplexing
backend target, which is the only route to cross-origin frame processes, so the
toggle had
no effect on their loads.
Move the handler into NetworkManager, where the Site Isolation state lives, and
send the
command only to targets that support it, plus the backend target when Network
is enabled
there. This also lets the layout tests drive the real code path, since Main.js
is not loaded
in them.
The SI test fetches a static file served with Cache-Control through .htaccess.
A python CGI
resource hung in Apache for minutes on about 1 in 100 runs, which timed the
test out.
Tests: inspector/network/resource-caching-disabled-setting-with-worker.html
http/tests/site-isolation/inspector/network/resource-caching-disabled-setting.html
*
LayoutTests/http/tests/site-isolation/inspector/network/resource-caching-disabled-setting-expected.txt:
Added.
*
LayoutTests/http/tests/site-isolation/inspector/network/resource-caching-disabled-setting.html:
Added.
* LayoutTests/http/tests/site-isolation/inspector/network/resources/.htaccess:
Added.
*
LayoutTests/http/tests/site-isolation/inspector/network/resources/cacheable-static-resource.txt:
Added.
*
LayoutTests/inspector/network/resource-caching-disabled-setting-with-worker-expected.txt:
Added.
*
LayoutTests/inspector/network/resource-caching-disabled-setting-with-worker.html:
Added.
* Source/WebInspectorUI/UserInterface/Base/Main.js:
(WI._resourceCachingDisabledSettingChanged): Moved to NetworkManager.
* Source/WebInspectorUI/UserInterface/Controllers/NetworkManager.js:
(WI.NetworkManager):
(WI.NetworkManager.prototype._handleResourceCachingDisabledSettingChanged):
Canonical link: https://commits.webkit.org/323432@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
