Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: af1c38c8ea02362f0786aacdb01c1140cd3c934b
      
https://github.com/WebKit/WebKit/commit/af1c38c8ea02362f0786aacdb01c1140cd3c934b
  Author: Anne van Kesteren <[email protected]>
  Date:   2026-10-13 (Tue, 13 Oct 2026)

  Changed paths:
    A 
LayoutTests/accessibility/isolated-tree/mac/listbox-set-selected-children-expected.txt
    A 
LayoutTests/accessibility/isolated-tree/mac/listbox-set-selected-children.html
    A LayoutTests/accessibility/mac/listbox-set-selected-children-expected.txt
    A LayoutTests/accessibility/mac/listbox-set-selected-children.html
    M Source/WebCore/accessibility/AccessibilityNodeObject.cpp

  Log Message:
  -----------
  AX: setting the selected children of a list box deselects and reselects 
options that stay selected
https://bugs.webkit.org/show_bug.cgi?id=327388
rdar://189899129

Reviewed by Tyler Wilcock.

AccessibilityNodeObject::setSelectedChildren() first deselected every selected 
option and then
selected the requested ones. When an AX user added an option to the selection 
of a multi-select
list box, the options that stayed selected were therefore also deselected and 
reselected, each with
input and change events. The page saw three selection changes, one of them 
leaving nothing
selected, where a non-AX user selecting the option causes one.

Only deselect the options that are not among the requested ones. Selecting an 
option that is
already selected does nothing.

Tests: accessibility/isolated-tree/mac/listbox-set-selected-children.html
       accessibility/mac/listbox-set-selected-children.html

Canonical link: https://commits.webkit.org/323679@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications

Reply via email to