Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 2398bb0d7145f2e768e2af2ab032a564ca49da0e
https://github.com/WebKit/WebKit/commit/2398bb0d7145f2e768e2af2ab032a564ca49da0e
Author: Chris Dumez <[email protected]>
Date: 2026-10-14 (Wed, 14 Oct 2026)
Changed paths:
M Source/WebCore/SaferCPPExpectations/UncheckedCallArgsCheckerExpectations
M Source/WebCore/SaferCPPExpectations/UncheckedLocalVarsCheckerExpectations
M Source/WebCore/SaferCPPExpectations/UncountedCallArgsCheckerExpectations
M Source/WebCore/SaferCPPExpectations/UnretainedCallArgsCheckerExpectations
M Source/WebCore/SaferCPPExpectations/UnretainedLocalVarsCheckerExpectations
M Source/WebCore/rendering/AttachmentLayout.mm
M Source/WebCore/rendering/RenderAttachment.cpp
M Source/WebCore/rendering/RenderEmbeddedObject.cpp
M Source/WebCore/rendering/RenderFileUploadControl.cpp
M Source/WebCore/rendering/RenderFrameSet.cpp
M Source/WebCore/rendering/RenderListBox.cpp
M Source/WebCore/rendering/RenderMenuList.cpp
M Source/WebCore/rendering/RenderVTTCue.cpp
M Source/WebCore/rendering/RenderVTTCue.h
Log Message:
-----------
[Safer CPP] Address warnings in form control, media and attachment renderers
https://bugs.webkit.org/show_bug.cgi?id=327362
Reviewed by Anne van Kesteren.
Address the safer-cpp static analysis warnings in renderers for rarely used
elements: file inputs, list boxes and menu lists, WebVTT cues, framesets,
attachments and embedded objects. None of these are exercised by the
Speedometer or MotionMark benchmarks.
RenderVTTCue::overlappingObject() and overlappingObjectForRect() now return
a CheckedPtr.
* Source/WebCore/SaferCPPExpectations/UncheckedCallArgsCheckerExpectations:
* Source/WebCore/SaferCPPExpectations/UncheckedLocalVarsCheckerExpectations:
* Source/WebCore/SaferCPPExpectations/UncountedCallArgsCheckerExpectations:
* Source/WebCore/SaferCPPExpectations/UnretainedCallArgsCheckerExpectations:
* Source/WebCore/SaferCPPExpectations/UnretainedLocalVarsCheckerExpectations:
* Source/WebCore/rendering/AttachmentLayout.mm:
(WebCore::AttachmentLayout::layOutTitle):
(WebCore::attachmentActionFont):
(WebCore::attachmentActionColor):
(WebCore::attachmentTitleFont):
(WebCore::attachmentDynamicTypeScaleFactor):
(WebCore::AttachmentLayout::AttachmentLayout):
(WebCore::AttachmentLayout::buildWrappedLines):
* Source/WebCore/rendering/RenderAttachment.cpp:
(WebCore::RenderAttachment::layoutWideLayoutAttachmentOnly):
(WebCore::RenderAttachment::layoutShadowContent):
(WebCore::RenderAttachment::paintWideLayoutAttachmentOnly const):
* Source/WebCore/rendering/RenderEmbeddedObject.cpp:
(WebCore::RenderEmbeddedObject::getReplacementTextGeometry const):
(WebCore::RenderEmbeddedObject::handleUnavailablePluginIndicatorEvent):
* Source/WebCore/rendering/RenderFileUploadControl.cpp:
(WebCore::RenderFileUploadControl::paintControl):
(WebCore::RenderFileUploadControl::computeIntrinsicLogicalWidths const):
(WebCore::RenderFileUploadControl::fileTextValue const):
* Source/WebCore/rendering/RenderFrameSet.cpp:
(WebCore::RenderFrameSet::paintColumnBorder):
(WebCore::RenderFrameSet::paintRowBorder):
(WebCore::RenderFrameSet::paint):
(WebCore::RenderFrameSet::computeEdgeInfo):
(WebCore::RenderFrameSet::layout):
(WebCore::resetFrameRendererAndDescendants):
(WebCore::RenderFrameSet::positionFrames):
(WebCore::RenderFrameSet::setIsResizing):
* Source/WebCore/rendering/RenderListBox.cpp:
(WebCore::RenderListBox::updateFromElement):
(WebCore::RenderListBox::paintItemForeground):
(WebCore::RenderListBox::paintItemBackground):
(WebCore::RenderListBox::itemLogicalHeight const):
(WebCore::RenderListBox::hasScrollableOrRubberbandableAncestor):
(WebCore::RenderListBox::logMockScrollbarsControllerMessage const):
(WebCore::RenderListBox::didStartScrollAnimation):
(WebCore::RenderListBox::destroyScrollbar):
* Source/WebCore/rendering/RenderMenuList.cpp:
(WebCore::RenderMenuList::styleDidChange):
(WebCore::RenderMenuList::updateOptionsWidth):
(WebCore::RenderMenuList::controlClipRect const):
(WebCore::RenderMenuList::computeIntrinsicLogicalWidths const):
(WebCore::RenderMenuList::getItemBackgroundColor const):
(WebCore::RenderMenuList::layout):
* Source/WebCore/rendering/RenderVTTCue.cpp:
(WebCore::RenderVTTCue::initializeLayoutParameters):
(WebCore::RenderVTTCue::isOutside const):
(WebCore::RenderVTTCue::rectIsWithinContainer const):
(WebCore::RenderVTTCue::overlappingObject const):
(WebCore::RenderVTTCue::overlappingObjectForRect const):
(WebCore::RenderVTTCue::moveIfNecessaryToKeepWithinContainer):
(WebCore::RenderVTTCue::findNonOverlappingPosition const):
(WebCore::RenderVTTCue::repositionCueSnapToLinesSet):
(WebCore::RenderVTTCue::repositionGenericCue):
(WebCore::RenderVTTCue::repositionCueSnapToLinesNotSet):
* Source/WebCore/rendering/RenderVTTCue.h:
Canonical link: https://commits.webkit.org/323720@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
