Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 214d23390e8a5b692641fd390e24c9e503bf7c33
https://github.com/WebKit/WebKit/commit/214d23390e8a5b692641fd390e24c9e503bf7c33
Author: Chris Dumez <[email protected]>
Date: 2026-10-14 (Wed, 14 Oct 2026)
Changed paths:
M Source/WebCore/Modules/mediacapabilities/MediaDecodingConfiguration.h
M Source/WebCore/Modules/mediasource/SourceBuffer.cpp
M Source/WebCore/Modules/mediastream/VideoTrackGenerator.cpp
M Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp
M Source/WebCore/Modules/webaudio/AudioNode.cpp
M Source/WebCore/Modules/webaudio/BiquadFilterNode.cpp
M Source/WebCore/SaferCPPExpectations/MemoryUnsafeCastCheckerExpectations
M Source/WebCore/accessibility/AXCoreObject.cpp
M Source/WebCore/accessibility/AXLogger.cpp
M Source/WebCore/accessibility/AXObjectCache.cpp
M Source/WebCore/accessibility/AXTextMarker.cpp
M Source/WebCore/accessibility/AccessibilityNodeObject.cpp
M Source/WebCore/accessibility/AccessibilityObject.cpp
M Source/WebCore/accessibility/AccessibilityObject.h
M Source/WebCore/accessibility/AccessibilityRenderObject.cpp
M Source/WebCore/accessibility/cocoa/AccessibilityObjectCocoa.mm
M Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.cpp
M Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.cpp
M Source/WebCore/accessibility/isolatedtree/mac/AXIsolatedObjectMac.mm
M Source/WebCore/animation/KeyframeEffect.cpp
M Source/WebCore/bindings/js/JSDOMQuadCustom.cpp
M Source/WebCore/bindings/js/JSDOMWindowCustom.cpp
M Source/WebCore/bindings/js/JSEventListener.h
M Source/WebCore/bindings/js/JSIDBObjectStoreCustom.cpp
M Source/WebCore/bindings/js/ReadableStreamDefaultController.h
M Source/WebCore/bindings/scripts/CodeGeneratorJS.pm
M Source/WebCore/css/CSSFontFace.cpp
M Source/WebCore/css/CSSImportRule.cpp
M Source/WebCore/css/CSSKeyframesRule.cpp
M Source/WebCore/css/CSSPrimitiveValue.cpp
M Source/WebCore/css/CSSStyleRule.cpp
M Source/WebCore/css/CSSStyleSheet.cpp
M Source/WebCore/css/SelectorCheckerTestFunctions.h
M Source/WebCore/css/StyleProperties.cpp
M Source/WebCore/css/StyleRule.cpp
M Source/WebCore/css/typedom/CSSStyleValueFactory.cpp
M Source/WebCore/css/typedom/StylePropertyMapReadOnly.cpp
M Source/WebCore/dom/Document.cpp
M Source/WebCore/dom/Document.h
M Source/WebCore/dom/DocumentFragment.cpp
M Source/WebCore/dom/DocumentInlines.h
M Source/WebCore/dom/DocumentMarkers.h
M Source/WebCore/dom/DocumentQuirks.h
M Source/WebCore/dom/Element.cpp
M Source/WebCore/dom/EventTarget.cpp
M Source/WebCore/dom/Node.cpp
M Source/WebCore/dom/Node.h
M Source/WebCore/dom/PositionIterator.cpp
M Source/WebCore/dom/StaticNodeList.cpp
M Source/WebCore/dom/StyledElement.cpp
M Source/WebCore/dom/StyledElement.h
M Source/WebCore/dom/TypedElementDescendantIteratorInlines.h
M Source/WebCore/dom/WindowEventLoop.cpp
M Source/WebCore/editing/Editing.cpp
M Source/WebCore/editing/Editor.cpp
M Source/WebCore/editing/VisiblePosition.cpp
M Source/WebCore/editing/VisibleUnits.cpp
M Source/WebCore/html/DOMTokenList.h
M Source/WebCore/html/FormController.cpp
M Source/WebCore/html/HTMLFieldSetElement.cpp
M Source/WebCore/html/HTMLFormElement.cpp
M Source/WebCore/html/HTMLInputElement.cpp
M Source/WebCore/html/HTMLLabelElement.cpp
M Source/WebCore/html/HTMLMediaElement.cpp
M Source/WebCore/html/HTMLSelectElement.cpp
M Source/WebCore/html/HTMLTableElement.cpp
M Source/WebCore/html/HTMLTextAreaElement.cpp
M Source/WebCore/html/canvas/CanvasRenderingContext2D.cpp
M Source/WebCore/html/track/TrackListBase.cpp
M Source/WebCore/inspector/InspectorOverlay.cpp
M Source/WebCore/inspector/agents/InspectorPageAgent.cpp
M Source/WebCore/layout/LayoutState.cpp
M Source/WebCore/layout/formattingContexts/inline/InlineLineBox.h
M Source/WebCore/layout/formattingContexts/inline/InlineLineBoxBuilder.cpp
M Source/WebCore/layout/integration/LayoutIntegrationBoxGeometryUpdater.cpp
M Source/WebCore/layout/integration/LayoutIntegrationBoxTreeUpdater.cpp
M Source/WebCore/layout/integration/LayoutIntegrationUtils.cpp
M
Source/WebCore/layout/integration/inline/LayoutIntegrationInlineContentPainter.cpp
M Source/WebCore/layout/integration/inline/LayoutIntegrationLineLayout.cpp
M Source/WebCore/loader/cache/CachedResource.cpp
M Source/WebCore/page/ChromeClient.h
M Source/WebCore/page/InteractionRegion.cpp
M Source/WebCore/page/IntersectionObserver.cpp
M Source/WebCore/page/LocalDOMWindow.cpp
M Source/WebCore/page/LocalFrameView.cpp
M Source/WebCore/page/ResizeObservation.cpp
M Source/WebCore/page/csp/ContentSecurityPolicy.cpp
M Source/WebCore/page/scrolling/AsyncScrollingCoordinator.cpp
M Source/WebCore/page/scrolling/ScrollingTreeScrollingNode.cpp
M Source/WebCore/platform/MediaSample.h
M Source/WebCore/platform/ScrollableArea.cpp
M Source/WebCore/platform/SharedBuffer.cpp
M Source/WebCore/platform/SharedBuffer.h
M Source/WebCore/platform/TrackInfo.h
M Source/WebCore/platform/Widget.cpp
M Source/WebCore/platform/graphics/BitmapImageSource.cpp
M Source/WebCore/platform/graphics/Font.h
M Source/WebCore/platform/graphics/FontCascadeFonts.cpp
M Source/WebCore/platform/graphics/GeometryUtilities.cpp
M Source/WebCore/platform/graphics/GradientColorStops.h
M Source/WebCore/platform/graphics/GraphicsLayer.cpp
M Source/WebCore/platform/graphics/Image.cpp
M Source/WebCore/platform/graphics/ImageBuffer.cpp
M Source/WebCore/platform/graphics/LayoutRect.cpp
M Source/WebCore/platform/graphics/Path.cpp
M Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp
M Source/WebCore/platform/graphics/controls/ControlPart.cpp
M
Source/WebCore/platform/graphics/filters/software/FELightingSoftwareApplier.cpp
M Source/WebCore/platform/graphics/transforms/IdentityTransformOperation.h
M Source/WebCore/platform/graphics/transforms/TransformationMatrix.cpp
M Source/WebCore/rendering/BackgroundPainter.cpp
M Source/WebCore/rendering/BorderPainter.cpp
M Source/WebCore/rendering/CounterNode.h
M Source/WebCore/rendering/ImageQualityController.cpp
M Source/WebCore/rendering/LegacyLineClampUpdater.cpp
M Source/WebCore/rendering/NinePieceImagePainter.cpp
M Source/WebCore/rendering/RegionContext.h
M Source/WebCore/rendering/RenderBlock.cpp
M Source/WebCore/rendering/RenderBlockFlow.cpp
M Source/WebCore/rendering/RenderBox.cpp
M Source/WebCore/rendering/RenderBoxModelObject.cpp
M Source/WebCore/rendering/RenderElement.cpp
M Source/WebCore/rendering/RenderFragmentedFlow.cpp
M Source/WebCore/rendering/RenderFragmentedFlow.h
M Source/WebCore/rendering/RenderGrid.cpp
M Source/WebCore/rendering/RenderLayer.cpp
M Source/WebCore/rendering/RenderLayerBacking.cpp
M Source/WebCore/rendering/RenderLayerBackingSVGAdditions.cpp
M Source/WebCore/rendering/RenderLayerCompositor.cpp
M Source/WebCore/rendering/RenderLayerFilters.cpp
M Source/WebCore/rendering/RenderLayerSVGAdditions.cpp
M Source/WebCore/rendering/RenderLayerScrollableArea.cpp
M Source/WebCore/rendering/RenderLineBreak.cpp
M Source/WebCore/rendering/RenderListItem.cpp
M Source/WebCore/rendering/RenderObject.cpp
M Source/WebCore/rendering/RenderObject.h
M Source/WebCore/rendering/RenderReplaced.cpp
M Source/WebCore/rendering/RenderTable.cpp
M Source/WebCore/rendering/RenderText.cpp
M Source/WebCore/rendering/RenderVideo.cpp
M Source/WebCore/rendering/RenderViewTransitionCapture.cpp
M Source/WebCore/rendering/ScrollbarUpdateScope.cpp
M Source/WebCore/rendering/TextBoxPainter.cpp
M Source/WebCore/rendering/TextBoxTrimmer.cpp
M Source/WebCore/rendering/mathml/RenderMathMLFraction.cpp
M Source/WebCore/rendering/mathml/RenderMathMLOperator.h
M Source/WebCore/rendering/shapes/ShapeOutsideInfo.cpp
M Source/WebCore/rendering/svg/RenderSVGContainer.cpp
M Source/WebCore/rendering/svg/RenderSVGModelObject.cpp
M Source/WebCore/rendering/svg/RenderSVGText.cpp
M Source/WebCore/rendering/svg/SVGRenderTreeAsText.cpp
M Source/WebCore/rendering/svg/legacy/LegacyRenderSVGModelObject.cpp
M Source/WebCore/rendering/svg/legacy/LegacyRenderSVGRoot.cpp
M Source/WebCore/style/AnchorPositionEvaluator.cpp
M Source/WebCore/style/ContainerQueryEvaluator.cpp
M Source/WebCore/style/RuleSet.cpp
M Source/WebCore/style/StyleBuilder.cpp
M Source/WebCore/style/StyleBuilderState.cpp
M Source/WebCore/style/StyleDocumentScope.cpp
M Source/WebCore/style/StyleEnvironmentVariables.cpp
M Source/WebCore/style/StyleExtractorCustom.h
M Source/WebCore/style/StyleRelations.cpp
M Source/WebCore/style/StyleResolver.cpp
M Source/WebCore/style/StyleScope.cpp
M Source/WebCore/style/StyleTreeResolver.cpp
M Source/WebCore/style/values/color/StyleOpacity.h
M Source/WebCore/style/values/fill-stroke/StyleStrokeMiterlimit.h
M Source/WebCore/style/values/images/StyleGradient.cpp
M Source/WebCore/style/values/images/kinds/StyleFilterImage.cpp
M Source/WebCore/svg/SVGElement.cpp
M Source/WebCore/svg/SVGFEImageElement.cpp
M Source/WebCore/svg/SVGFontFaceElement.cpp
M Source/WebCore/svg/SVGPathElement.cpp
M Source/WebCore/testing/Internals.cpp
M Source/WebCore/workers/WorkerOrWorkletGlobalScope.h
Log Message:
-----------
[Safer CPP] Address remaining unsafe cast warnings in Source/WebCore
https://bugs.webkit.org/show_bug.cgi?id=327519
Reviewed by Anne van Kesteren.
The 2026-10-06 static analyzer snapshot reports many casts in WebCore as
"Unsafe cast from type 'X' to an unrelated type 'X'", where both types are
the same. These are false positives:
- const_cast, e.g. const_cast<AXCoreObject*>(this) (rdar://189998365).
- Conversions written as constructor calls, e.g. FloatRect(layoutRect),
plus a few same-type static_casts and defaulted operator<=>
(rdar://189998444).
Suppress them with SUPPRESS_MEMORY_UNSAFE_CAST and a FIXME pointing to the
relevant radar. Stop generating the redundant wrapped() override for
JSLegacyParent interfaces, whose base classes already return the right type.
* Source/WebCore/Modules/mediacapabilities/MediaDecodingConfiguration.h:
* Source/WebCore/Modules/mediasource/SourceBuffer.cpp:
* Source/WebCore/Modules/mediastream/VideoTrackGenerator.cpp:
* Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp:
* Source/WebCore/Modules/webaudio/AudioNode.cpp:
* Source/WebCore/Modules/webaudio/BiquadFilterNode.cpp:
* Source/WebCore/SaferCPPExpectations/MemoryUnsafeCastCheckerExpectations:
* Source/WebCore/accessibility/AXCoreObject.cpp:
* Source/WebCore/accessibility/AXLogger.cpp:
* Source/WebCore/accessibility/AXObjectCache.cpp:
* Source/WebCore/accessibility/AXTextMarker.cpp:
* Source/WebCore/accessibility/AccessibilityNodeObject.cpp:
* Source/WebCore/accessibility/AccessibilityObject.cpp:
* Source/WebCore/accessibility/AccessibilityObject.h:
* Source/WebCore/accessibility/AccessibilityRenderObject.cpp:
* Source/WebCore/accessibility/cocoa/AccessibilityObjectCocoa.mm:
* Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.cpp:
* Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.cpp:
* Source/WebCore/accessibility/isolatedtree/mac/AXIsolatedObjectMac.mm:
* Source/WebCore/animation/KeyframeEffect.cpp:
* Source/WebCore/bindings/js/JSDOMQuadCustom.cpp:
* Source/WebCore/bindings/js/JSDOMWindowCustom.cpp:
* Source/WebCore/bindings/js/JSEventListener.h:
* Source/WebCore/bindings/js/JSIDBObjectStoreCustom.cpp:
* Source/WebCore/bindings/js/ReadableStreamDefaultController.h:
* Source/WebCore/bindings/scripts/CodeGeneratorJS.pm:
* Source/WebCore/css/CSSFontFace.cpp:
* Source/WebCore/css/CSSImportRule.cpp:
* Source/WebCore/css/CSSKeyframesRule.cpp:
* Source/WebCore/css/CSSPrimitiveValue.cpp:
* Source/WebCore/css/CSSStyleRule.cpp:
* Source/WebCore/css/CSSStyleSheet.cpp:
* Source/WebCore/css/SelectorCheckerTestFunctions.h:
* Source/WebCore/css/StyleProperties.cpp:
* Source/WebCore/css/StyleRule.cpp:
* Source/WebCore/css/typedom/CSSStyleValueFactory.cpp:
* Source/WebCore/css/typedom/StylePropertyMapReadOnly.cpp:
* Source/WebCore/dom/Document.cpp:
* Source/WebCore/dom/Document.h:
* Source/WebCore/dom/DocumentFragment.cpp:
* Source/WebCore/dom/DocumentInlines.h:
* Source/WebCore/dom/DocumentMarkers.h:
* Source/WebCore/dom/DocumentQuirks.h:
* Source/WebCore/dom/Element.cpp:
* Source/WebCore/dom/EventTarget.cpp:
* Source/WebCore/dom/Node.cpp:
* Source/WebCore/dom/Node.h:
* Source/WebCore/dom/PositionIterator.cpp:
* Source/WebCore/dom/StaticNodeList.cpp:
* Source/WebCore/dom/StyledElement.cpp:
* Source/WebCore/dom/StyledElement.h:
* Source/WebCore/dom/TypedElementDescendantIteratorInlines.h:
* Source/WebCore/dom/WindowEventLoop.cpp:
* Source/WebCore/editing/Editing.cpp:
* Source/WebCore/editing/Editor.cpp:
* Source/WebCore/editing/VisiblePosition.cpp:
* Source/WebCore/editing/VisibleUnits.cpp:
* Source/WebCore/html/DOMTokenList.h:
* Source/WebCore/html/FormController.cpp:
* Source/WebCore/html/HTMLFieldSetElement.cpp:
* Source/WebCore/html/HTMLFormElement.cpp:
* Source/WebCore/html/HTMLInputElement.cpp:
* Source/WebCore/html/HTMLLabelElement.cpp:
* Source/WebCore/html/HTMLMediaElement.cpp:
* Source/WebCore/html/HTMLSelectElement.cpp:
* Source/WebCore/html/HTMLTableElement.cpp:
* Source/WebCore/html/HTMLTextAreaElement.cpp:
* Source/WebCore/html/canvas/CanvasRenderingContext2D.cpp:
* Source/WebCore/html/track/TrackListBase.cpp:
* Source/WebCore/inspector/InspectorOverlay.cpp:
* Source/WebCore/inspector/agents/InspectorPageAgent.cpp:
* Source/WebCore/layout/LayoutState.cpp:
* Source/WebCore/layout/formattingContexts/inline/InlineLineBox.h:
* Source/WebCore/layout/formattingContexts/inline/InlineLineBoxBuilder.cpp:
* Source/WebCore/layout/integration/LayoutIntegrationBoxGeometryUpdater.cpp:
* Source/WebCore/layout/integration/LayoutIntegrationBoxTreeUpdater.cpp:
* Source/WebCore/layout/integration/LayoutIntegrationUtils.cpp:
*
Source/WebCore/layout/integration/inline/LayoutIntegrationInlineContentPainter.cpp:
* Source/WebCore/layout/integration/inline/LayoutIntegrationLineLayout.cpp:
* Source/WebCore/loader/cache/CachedResource.cpp:
* Source/WebCore/page/ChromeClient.h:
* Source/WebCore/page/InteractionRegion.cpp:
* Source/WebCore/page/IntersectionObserver.cpp:
* Source/WebCore/page/LocalDOMWindow.cpp:
* Source/WebCore/page/LocalFrameView.cpp:
* Source/WebCore/page/ResizeObservation.cpp:
* Source/WebCore/page/csp/ContentSecurityPolicy.cpp:
* Source/WebCore/page/scrolling/AsyncScrollingCoordinator.cpp:
* Source/WebCore/page/scrolling/ScrollingTreeScrollingNode.cpp:
* Source/WebCore/platform/MediaSample.h:
* Source/WebCore/platform/ScrollableArea.cpp:
* Source/WebCore/platform/SharedBuffer.cpp:
* Source/WebCore/platform/SharedBuffer.h:
* Source/WebCore/platform/TrackInfo.h:
* Source/WebCore/platform/Widget.cpp:
* Source/WebCore/platform/graphics/BitmapImageSource.cpp:
* Source/WebCore/platform/graphics/Font.h:
* Source/WebCore/platform/graphics/FontCascadeFonts.cpp:
* Source/WebCore/platform/graphics/GeometryUtilities.cpp:
* Source/WebCore/platform/graphics/GradientColorStops.h:
* Source/WebCore/platform/graphics/GraphicsLayer.cpp:
* Source/WebCore/platform/graphics/Image.cpp:
* Source/WebCore/platform/graphics/ImageBuffer.cpp:
* Source/WebCore/platform/graphics/LayoutRect.cpp:
* Source/WebCore/platform/graphics/Path.cpp:
* Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:
* Source/WebCore/platform/graphics/controls/ControlPart.cpp:
*
Source/WebCore/platform/graphics/filters/software/FELightingSoftwareApplier.cpp:
* Source/WebCore/platform/graphics/transforms/IdentityTransformOperation.h:
* Source/WebCore/platform/graphics/transforms/TransformationMatrix.cpp:
* Source/WebCore/rendering/BackgroundPainter.cpp:
* Source/WebCore/rendering/BorderPainter.cpp:
* Source/WebCore/rendering/CounterNode.h:
* Source/WebCore/rendering/ImageQualityController.cpp:
* Source/WebCore/rendering/LegacyLineClampUpdater.cpp:
* Source/WebCore/rendering/NinePieceImagePainter.cpp:
* Source/WebCore/rendering/RegionContext.h:
* Source/WebCore/rendering/RenderBlock.cpp:
* Source/WebCore/rendering/RenderBlockFlow.cpp:
* Source/WebCore/rendering/RenderBox.cpp:
* Source/WebCore/rendering/RenderBoxModelObject.cpp:
* Source/WebCore/rendering/RenderElement.cpp:
* Source/WebCore/rendering/RenderFragmentedFlow.cpp:
* Source/WebCore/rendering/RenderFragmentedFlow.h:
* Source/WebCore/rendering/RenderGrid.cpp:
* Source/WebCore/rendering/RenderLayer.cpp:
* Source/WebCore/rendering/RenderLayerBacking.cpp:
* Source/WebCore/rendering/RenderLayerBackingSVGAdditions.cpp:
* Source/WebCore/rendering/RenderLayerCompositor.cpp:
* Source/WebCore/rendering/RenderLayerFilters.cpp:
* Source/WebCore/rendering/RenderLayerSVGAdditions.cpp:
* Source/WebCore/rendering/RenderLayerScrollableArea.cpp:
* Source/WebCore/rendering/RenderLineBreak.cpp:
* Source/WebCore/rendering/RenderListItem.cpp:
* Source/WebCore/rendering/RenderObject.cpp:
* Source/WebCore/rendering/RenderObject.h:
* Source/WebCore/rendering/RenderReplaced.cpp:
* Source/WebCore/rendering/RenderTable.cpp:
* Source/WebCore/rendering/RenderText.cpp:
* Source/WebCore/rendering/RenderVideo.cpp:
* Source/WebCore/rendering/RenderViewTransitionCapture.cpp:
* Source/WebCore/rendering/ScrollbarUpdateScope.cpp:
* Source/WebCore/rendering/TextBoxPainter.cpp:
* Source/WebCore/rendering/TextBoxTrimmer.cpp:
* Source/WebCore/rendering/mathml/RenderMathMLFraction.cpp:
* Source/WebCore/rendering/mathml/RenderMathMLOperator.h:
* Source/WebCore/rendering/shapes/ShapeOutsideInfo.cpp:
* Source/WebCore/rendering/svg/RenderSVGContainer.cpp:
* Source/WebCore/rendering/svg/RenderSVGModelObject.cpp:
* Source/WebCore/rendering/svg/RenderSVGText.cpp:
* Source/WebCore/rendering/svg/SVGRenderTreeAsText.cpp:
* Source/WebCore/rendering/svg/legacy/LegacyRenderSVGModelObject.cpp:
* Source/WebCore/rendering/svg/legacy/LegacyRenderSVGRoot.cpp:
* Source/WebCore/style/AnchorPositionEvaluator.cpp:
* Source/WebCore/style/ContainerQueryEvaluator.cpp:
* Source/WebCore/style/RuleSet.cpp:
* Source/WebCore/style/StyleBuilder.cpp:
* Source/WebCore/style/StyleBuilderState.cpp:
* Source/WebCore/style/StyleDocumentScope.cpp:
* Source/WebCore/style/StyleEnvironmentVariables.cpp:
* Source/WebCore/style/StyleExtractorCustom.h:
* Source/WebCore/style/StyleRelations.cpp:
* Source/WebCore/style/StyleResolver.cpp:
* Source/WebCore/style/StyleScope.cpp:
* Source/WebCore/style/StyleTreeResolver.cpp:
* Source/WebCore/style/values/color/StyleOpacity.h:
* Source/WebCore/style/values/fill-stroke/StyleStrokeMiterlimit.h:
* Source/WebCore/style/values/images/StyleGradient.cpp:
* Source/WebCore/style/values/images/kinds/StyleFilterImage.cpp:
* Source/WebCore/svg/SVGElement.cpp:
* Source/WebCore/svg/SVGFEImageElement.cpp:
* Source/WebCore/svg/SVGFontFaceElement.cpp:
* Source/WebCore/svg/SVGPathElement.cpp:
* Source/WebCore/testing/Internals.cpp:
* Source/WebCore/workers/WorkerOrWorkletGlobalScope.h:
Canonical link: https://commits.webkit.org/323718@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
