Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 211a6e2bad4ff63d00159c7cc3195df94133fa4d
https://github.com/WebKit/WebKit/commit/211a6e2bad4ff63d00159c7cc3195df94133fa4d
Author: Phinehas Fuachie <[email protected]>
Date: 2026-10-14 (Wed, 14 Oct 2026)
Changed paths:
M
Source/WebCore/Modules/modern-media-controls/media/spatial-video-support.js
M Source/WebCore/html/HTMLVideoElement.cpp
M Source/WebCore/html/HTMLVideoElement.h
M Source/WebCore/html/HTMLVideoElement.idl
Log Message:
-----------
Spatial video camera's reflected and live values are named the wrong way round
https://bugs.webkit.org/show_bug.cgi?id=326885
rdar://189556953
Reviewed by Jer Noble.
yaw, pitch and fieldOfView reflected the x-webkit-* content attributes as
DOMStrings and the live
camera was cameraYaw, cameraPitch and cameraFieldOfView -- the reverse of
defaultMuted and muted,
where the plain name is the live value.
Rename the reflected values defaultYaw, defaultPitch and defaultFieldOfView,
and the live ones yaw,
pitch and fieldOfView. They are doubles now, so the controls read them instead
of parsing the
attributes themselves, and a live value read before a frame has been drawn
falls back to its
declared counterpart rather than zero.
* Source/WebCore/Modules/modern-media-controls/media/spatial-video-support.js:
(SpatialVideoSupport):
(SpatialVideoSupport.prototype._applyDeclaredCameraView):
* Source/WebCore/html/HTMLVideoElement.cpp:
(WebCore::HTMLVideoElement::defaultYaw const):
(WebCore::HTMLVideoElement::defaultPitch const):
(WebCore::HTMLVideoElement::defaultFieldOfView const):
(WebCore::HTMLVideoElement::yaw const):
(WebCore::HTMLVideoElement::pitch const):
(WebCore::HTMLVideoElement::fieldOfView const):
* Source/WebCore/html/HTMLVideoElement.h:
* Source/WebCore/html/HTMLVideoElement.idl:
Canonical link: https://commits.webkit.org/323748@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
