Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 644c032786f147a789366b2eb19ff109b6590e1f
https://github.com/WebKit/WebKit/commit/644c032786f147a789366b2eb19ff109b6590e1f
Author: Abrar Rahman Protyasha <[email protected]>
Date: 2026-10-14 (Wed, 14 Oct 2026)
Changed paths:
M Source/WebCore/editing/Editor.cpp
M Source/WebCore/editing/Editor.h
M Source/WebCore/page/ContextMenuController.cpp
M Source/WebCore/page/ContextMenuController.h
M Tools/TestWebKitAPI/Tests/WebKit/WebPage/AppKit Gesture
Tests/BasicAppKitGesturesTests.swift
Log Message:
-----------
WebCore::Editor::[ignore|learn]Spelling() should have common implementations
https://bugs.webkit.org/show_bug.cgi?id=327471
rdar://189964485
Reviewed by Wenson Hsieh and Ryosuke Niwa.
In this patch, we address some review feedback from 323472@main:
- Editor::[ignore|Learn]Spelling() now share one implementation each,
where they take an optional range and fall back to the selection.
- The spelling/grammar target range and text are now bundled into one
optional struct, so they're always set and reset together.
No change in behavior, but we add a new test that verifies that
choosing Learn Spelling does nothing if the misspelled word changed
(through script, for example) while the context menu was open.
Test:
AppKitGesturesTests.Basic.choosingLearnSpellingAtCaretAfterMisspelledWordChangesLearnsNothing
Canonical link: https://commits.webkit.org/323709@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
