Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: c4afc47da6bd72c819bd37f7f5e704c6d7b8da21
https://github.com/WebKit/WebKit/commit/c4afc47da6bd72c819bd37f7f5e704c6d7b8da21
Author: Yury Semikhatsky <[email protected]>
Date: 2026-10-14 (Wed, 14 Oct 2026)
Changed paths:
A LayoutTests/inspector/page/frame-loader-identifier-expected.txt
A LayoutTests/inspector/page/frame-loader-identifier.html
M Source/WebCore/inspector/InspectorIdentifierRegistry.cpp
M Source/WebCore/inspector/InspectorIdentifierRegistry.h
Log Message:
-----------
Web Inspector: compute loaderId in one place
https://bugs.webkit.org/show_bug.cgi?id=326956
Reviewed by Devin Rousso.
LegacyIdentifierRegistry and BackendIdentifierRegistry have the same loaderId()
and takeLoader() code, each with
its own map for the fallback identifier of a DocumentLoader that has no
navigation ID. Implement them once in
IdentifierRegistry, with a single map.
The fallback is still needed. Substitute data loads (error pages, alternate
HTML), PDF.js and QuickLook URLs skip
the navigation policy check that assigns a navigation ID, and the frontend
matches the Network events of their
main resource with Page.frameNavigated by the loader identifier.
Test: inspector/page/frame-loader-identifier.html
* LayoutTests/inspector/page/frame-loader-identifier-expected.txt: Added.
* LayoutTests/inspector/page/frame-loader-identifier.html: Added.
* Source/WebCore/inspector/InspectorIdentifierRegistry.cpp:
(Inspector::IdentifierRegistry::loaderId):
(Inspector::IdentifierRegistry::takeLoader):
(Inspector::LegacyIdentifierRegistry::loaderId): Deleted.
(Inspector::LegacyIdentifierRegistry::takeLoader): Deleted.
(Inspector::BackendIdentifierRegistry::loaderId): Deleted.
(Inspector::BackendIdentifierRegistry::takeLoader): Deleted.
* Source/WebCore/inspector/InspectorIdentifierRegistry.h:
Canonical link: https://commits.webkit.org/323784@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
