Title: [116126] trunk/Tools
- Revision
- 116126
- Author
- [email protected]
- Date
- 2012-05-04 10:52:29 -0700 (Fri, 04 May 2012)
Log Message
Use destructuring assingment for the return values of the
port.diff_image() method call.
Rubber-stamped by Dirk Pranke.
* Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
(write_test_result):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (116125 => 116126)
--- trunk/Tools/ChangeLog 2012-05-04 17:47:36 UTC (rev 116125)
+++ trunk/Tools/ChangeLog 2012-05-04 17:52:29 UTC (rev 116126)
@@ -1,3 +1,13 @@
+2012-05-04 Zan Dobersek <[email protected]>
+
+ Use destructuring assingment for the return values of the
+ port.diff_image() method call.
+
+ Rubber-stamped by Dirk Pranke.
+
+ * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
+ (write_test_result):
+
2012-05-03 Ojan Vafai <[email protected]>
Store fewer runs by default in the flakiness dashboard
Modified: trunk/Tools/Scripts/webkitpy/layout_tests/controllers/test_result_writer.py (116125 => 116126)
--- trunk/Tools/Scripts/webkitpy/layout_tests/controllers/test_result_writer.py 2012-05-04 17:47:36 UTC (rev 116125)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/controllers/test_result_writer.py 2012-05-04 17:52:29 UTC (rev 116126)
@@ -68,10 +68,10 @@
# FIXME: This work should be done earlier in the pipeline (e.g., when we compare images for non-ref tests).
# FIXME: We should always have 2 images here.
if driver_output.image and expected_driver_output.image:
- diff_result = port.diff_image(driver_output.image, expected_driver_output.image, tolerance=0)
- if diff_result[0]:
- writer.write_image_diff_files(diff_result[0])
- failure.diff_percent = diff_result[1]
+ diff_image, diff_percent = port.diff_image(driver_output.image, expected_driver_output.image, tolerance=0)
+ if diff_image:
+ writer.write_image_diff_files(diff_image)
+ failure.diff_percent = diff_percent
else:
_log.warn('Can not get image diff. ImageDiff program might not work correctly.')
writer.copy_file(failure.reference_filename)
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
