Title: [116350] trunk/Source/WebKit/blackberry
- Revision
- 116350
- Author
- commit-qu...@webkit.org
- Date
- 2012-05-07 13:37:43 -0700 (Mon, 07 May 2012)
Log Message
[BlackBerry] Delete previous buffer when new over-scroll image path is set
https://bugs.webkit.org/show_bug.cgi?id=85812
Patch by Andrew Lo <a...@rim.com> on 2012-05-07
Reviewed by Rob Buis.
When a new over-scroll image path is set, delete old buffer before creating
a new one.
* Api/BackingStore.cpp:
(BlackBerry::WebKit::BackingStorePrivate::ensureOverScrollImage):
Modified Paths
Diff
Modified: trunk/Source/WebKit/blackberry/Api/BackingStore.cpp (116349 => 116350)
--- trunk/Source/WebKit/blackberry/Api/BackingStore.cpp 2012-05-07 20:37:15 UTC (rev 116349)
+++ trunk/Source/WebKit/blackberry/Api/BackingStore.cpp 2012-05-07 20:37:43 UTC (rev 116350)
@@ -1217,11 +1217,12 @@
return false;
}
- // FIXME: Make it orientation and resolution agnostic
+ // FIXME: Make it orientation and resolution agnostic.
+ // For now we fallback to solid color if sizes don't match, later we can implement tiling.
if (bitmap.width() != surfaceSize().width() || bitmap.height() != surfaceSize().height())
return false;
- // FIXME: For now we fallback to solid color if sizes don't match, later we can implement tiling
+ destroyBuffer(s_overScrollImage);
s_overScrollImage = createBuffer(Platform::IntSize(bitmap.width(), bitmap.height()), Platform::Graphics::TemporaryBuffer);
SkCanvas* canvas = Platform::Graphics::lockBufferDrawable(s_overScrollImage);
Modified: trunk/Source/WebKit/blackberry/ChangeLog (116349 => 116350)
--- trunk/Source/WebKit/blackberry/ChangeLog 2012-05-07 20:37:15 UTC (rev 116349)
+++ trunk/Source/WebKit/blackberry/ChangeLog 2012-05-07 20:37:43 UTC (rev 116350)
@@ -1,5 +1,18 @@
2012-05-07 Andrew Lo <a...@rim.com>
+ [BlackBerry] Delete previous buffer when new over-scroll image path is set
+ https://bugs.webkit.org/show_bug.cgi?id=85812
+
+ Reviewed by Rob Buis.
+
+ When a new over-scroll image path is set, delete old buffer before creating
+ a new one.
+
+ * Api/BackingStore.cpp:
+ (BlackBerry::WebKit::BackingStorePrivate::ensureOverScrollImage):
+
+2012-05-07 Andrew Lo <a...@rim.com>
+
[BlackBerry] Over-scroll image path property should be relative to local application directory
https://bugs.webkit.org/show_bug.cgi?id=85814
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
