Title: [116638] trunk/Tools
- Revision
- 116638
- Author
- commit-qu...@webkit.org
- Date
- 2012-05-10 06:42:54 -0700 (Thu, 10 May 2012)
Log Message
[EFL] Memory leaks found in EFL DRT
https://bugs.webkit.org/show_bug.cgi?id=85889
Patch by Sudarsana Nagineni <sudarsana.nagin...@linux.intel.com> on 2012-05-10
Reviewed by Gustavo Noronha Silva.
Fix two memory leaks in EFL's DRT by using JSRetainPtr for JSString
created with JSStringCreateWithUTF8CString.
* DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
(DumpRenderTreeChrome::onWindowObjectCleared):
* DumpRenderTree/efl/EventSender.cpp:
(modifiersFromJSValue):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (116637 => 116638)
--- trunk/Tools/ChangeLog 2012-05-10 13:19:08 UTC (rev 116637)
+++ trunk/Tools/ChangeLog 2012-05-10 13:42:54 UTC (rev 116638)
@@ -1,3 +1,18 @@
+2012-05-10 Sudarsana Nagineni <sudarsana.nagin...@linux.intel.com>
+
+ [EFL] Memory leaks found in EFL DRT
+ https://bugs.webkit.org/show_bug.cgi?id=85889
+
+ Reviewed by Gustavo Noronha Silva.
+
+ Fix two memory leaks in EFL's DRT by using JSRetainPtr for JSString
+ created with JSStringCreateWithUTF8CString.
+
+ * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
+ (DumpRenderTreeChrome::onWindowObjectCleared):
+ * DumpRenderTree/efl/EventSender.cpp:
+ (modifiersFromJSValue):
+
2012-05-10 Alexander Shalamov <alexander.shala...@intel.com>
[EFL] LayoutTestController needs implementation of setTabKeyCyclesThroughElements
Modified: trunk/Tools/DumpRenderTree/efl/DumpRenderTreeChrome.cpp (116637 => 116638)
--- trunk/Tools/DumpRenderTree/efl/DumpRenderTreeChrome.cpp 2012-05-10 13:19:08 UTC (rev 116637)
+++ trunk/Tools/DumpRenderTree/efl/DumpRenderTreeChrome.cpp 2012-05-10 13:42:54 UTC (rev 116638)
@@ -367,7 +367,7 @@
gcController->makeWindowObject(objectClearedInfo->context, objectClearedInfo->windowObject, &exception);
ASSERT(!exception);
- JSRetainPtr<JSStringRef> controllerName(JSStringCreateWithUTF8CString("eventSender"));
+ JSRetainPtr<JSStringRef> controllerName(Adopt, JSStringCreateWithUTF8CString("eventSender"));
JSObjectSetProperty(objectClearedInfo->context, objectClearedInfo->windowObject,
controllerName.get(),
makeEventSender(objectClearedInfo->context, !DumpRenderTreeSupportEfl::frameParent(objectClearedInfo->frame)),
Modified: trunk/Tools/DumpRenderTree/efl/EventSender.cpp (116637 => 116638)
--- trunk/Tools/DumpRenderTree/efl/EventSender.cpp 2012-05-10 13:19:08 UTC (rev 116637)
+++ trunk/Tools/DumpRenderTree/efl/EventSender.cpp 2012-05-10 13:42:54 UTC (rev 116638)
@@ -236,7 +236,8 @@
return EvasKeyModifierNone;
unsigned modifier = 0;
- int modifiersCount = JSValueToNumber(context, JSObjectGetProperty(context, modifiersArray, JSStringCreateWithUTF8CString("length"), 0), 0);
+ JSRetainPtr<JSStringRef> lengthProperty(Adopt, JSStringCreateWithUTF8CString("length"));
+ int modifiersCount = JSValueToNumber(context, JSObjectGetProperty(context, modifiersArray, lengthProperty.get(), 0), 0);
for (int i = 0; i < modifiersCount; ++i)
modifier |= static_cast<unsigned>(modifierFromJSValue(context, JSObjectGetPropertyAtIndex(context, modifiersArray, i, 0)));
return static_cast<EvasKeyModifier>(modifier);
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
