Title: [116743] trunk
- Revision
- 116743
- Author
- ca...@chromium.org
- Date
- 2012-05-11 02:35:00 -0700 (Fri, 11 May 2012)
Log Message
Web Inspector: use div, not span as a parent element for ElementsTreeOutline in Audits panel
https://bugs.webkit.org/show_bug.cgi?id=86188
Reviewed by Yury Semikhatsky.
Source/WebCore:
We need to use <div>, not <span> as a container for ElementsTreeOutline, as latter accesses its parent offsetWidth
within _treeElementFromEvent(), which returns 0 for inline elements.
* inspector/front-end/AuditFormatters.js:
(WebInspector.AuditFormatters.node.onNodeAvailable):
(WebInspector.AuditFormatters.node):
LayoutTests:
* inspector/extensions/extensions-audits-expected.txt: rebaseline to account for extra <div>.
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (116742 => 116743)
--- trunk/LayoutTests/ChangeLog 2012-05-11 09:28:52 UTC (rev 116742)
+++ trunk/LayoutTests/ChangeLog 2012-05-11 09:35:00 UTC (rev 116743)
@@ -1,3 +1,12 @@
+2012-05-11 Andrey Kosyakov <ca...@chromium.org>
+
+ Web Inspector: use div, not span as a parent element for ElementsTreeOutline in Audits panel
+ https://bugs.webkit.org/show_bug.cgi?id=86188
+
+ Reviewed by Yury Semikhatsky.
+
+ * inspector/extensions/extensions-audits-expected.txt: rebaseline to account for extra <div>.
+
2012-05-11 Kent Tamura <tk...@chromium.org>
[Chromium] Test expectation update
Modified: trunk/LayoutTests/inspector/extensions/extensions-audits-expected.txt (116742 => 116743)
--- trunk/LayoutTests/inspector/extensions/extensions-audits-expected.txt 2012-05-11 09:28:52 UTC (rev 116742)
+++ trunk/LayoutTests/inspector/extensions/extensions-audits-expected.txt 2012-05-11 09:35:00 UTC (rev 116743)
@@ -29,15 +29,15 @@
__proto__
:
Object
- <
- span
-
- id
- ="
- test-element
- "
- >
-
+ <
+ span
+
+ id
+ ="
+ test-element
+ "
+ >
+
extensions-audits.html:20
Passed rule
this rule always passes ok
Modified: trunk/Source/WebCore/ChangeLog (116742 => 116743)
--- trunk/Source/WebCore/ChangeLog 2012-05-11 09:28:52 UTC (rev 116742)
+++ trunk/Source/WebCore/ChangeLog 2012-05-11 09:35:00 UTC (rev 116743)
@@ -1,3 +1,17 @@
+2012-05-11 Andrey Kosyakov <ca...@chromium.org>
+
+ Web Inspector: use div, not span as a parent element for ElementsTreeOutline in Audits panel
+ https://bugs.webkit.org/show_bug.cgi?id=86188
+
+ Reviewed by Yury Semikhatsky.
+
+ We need to use <div>, not <span> as a container for ElementsTreeOutline, as latter accesses its parent offsetWidth
+ within _treeElementFromEvent(), which returns 0 for inline elements.
+
+ * inspector/front-end/AuditFormatters.js:
+ (WebInspector.AuditFormatters.node.onNodeAvailable):
+ (WebInspector.AuditFormatters.node):
+
2012-05-11 Antti Koivisto <an...@apple.com>
Inline Node::traverseNextNode
Modified: trunk/Source/WebCore/inspector/front-end/AuditFormatters.js (116742 => 116743)
--- trunk/Source/WebCore/inspector/front-end/AuditFormatters.js 2012-05-11 09:28:52 UTC (rev 116742)
+++ trunk/Source/WebCore/inspector/front-end/AuditFormatters.js 2012-05-11 09:35:00 UTC (rev 116743)
@@ -121,7 +121,7 @@
*/
node: function(_expression_)
{
- var treeOutline = new WebInspector.ElementsTreeOutline(false, false, true);
+ var parentElement = document.createElement("div");
/**
* @param {?number} nodeId
*/
@@ -129,9 +129,11 @@
{
if (!nodeId)
return;
+ var treeOutline = new WebInspector.ElementsTreeOutline(false, false, true);
treeOutline.rootDOMNode = WebInspector.domAgent.nodeForId(nodeId);
treeOutline.element.addStyleClass("outline-disclosure");
treeOutline.setVisible(true);
+ parentElement.appendChild(treeOutline.element);
}
/**
* @param {WebInspector.RemoteObject} remoteObject
@@ -141,7 +143,7 @@
remoteObject.pushNodeToFrontend(onNodeAvailable);
}
WebInspector.AuditFormatters.Utilities.evaluate(_expression_, onEvaluate);
- return treeOutline.element;
+ return parentElement;
}
};
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
