Diff
Modified: trunk/LayoutTests/ChangeLog (116753 => 116754)
--- trunk/LayoutTests/ChangeLog 2012-05-11 12:41:52 UTC (rev 116753)
+++ trunk/LayoutTests/ChangeLog 2012-05-11 12:45:05 UTC (rev 116754)
@@ -1,3 +1,15 @@
+2012-05-11 Sheriff Bot <webkit.review....@gmail.com>
+
+ Unreviewed, rolling out r116527.
+ http://trac.webkit.org/changeset/116527
+ https://bugs.webkit.org/show_bug.cgi?id=86199
+
+ Causing crashes on ClusterFuzz (Requested by inferno-sec on
+ #webkit).
+
+ * scrollbars/scrollbar-percent-padding-crash-expected.txt: Removed.
+ * scrollbars/scrollbar-percent-padding-crash.html: Removed.
+
2012-05-11 Kent Tamura <tk...@chromium.org>
[Chromium] Update wrong expectations.
Deleted: trunk/LayoutTests/scrollbars/scrollbar-percent-padding-crash-expected.txt (116753 => 116754)
--- trunk/LayoutTests/scrollbars/scrollbar-percent-padding-crash-expected.txt 2012-05-11 12:41:52 UTC (rev 116753)
+++ trunk/LayoutTests/scrollbars/scrollbar-percent-padding-crash-expected.txt 2012-05-11 12:45:05 UTC (rev 116754)
@@ -1,3 +0,0 @@
-Test for bug 83889: This tests that there is no crash when using percentage value for scrollbar's padding property. On success you should see a frame with scrollbars and one PASS message in it.
-
-
Deleted: trunk/LayoutTests/scrollbars/scrollbar-percent-padding-crash.html (116753 => 116754)
--- trunk/LayoutTests/scrollbars/scrollbar-percent-padding-crash.html 2012-05-11 12:41:52 UTC (rev 116753)
+++ trunk/LayoutTests/scrollbars/scrollbar-percent-padding-crash.html 2012-05-11 12:45:05 UTC (rev 116754)
@@ -1,24 +0,0 @@
-<!DOCTYPE html>
-<html>
-<head>
-<style>
-::-webkit-scrollbar {
- -webkit-padding-start: 1%; background: #666 -webkit-gradient(linear, left top, right top, from(rgba(255,255,255,0.5)), color-stop(0.5, rgba(255,255,255,0.1)), color-stop(0.5, rgba(0,0,0,0)), to(rgba(0,0,0,0.01)));
-}
-</style>
-<script>
-function runTest() {
- if (window.layoutTestController) {
- layoutTestController.dumpAsText();
- document.body.offsetTop;
- layoutTestController.display();
- }
-};
-</script>
-</head>
-<body _onload_="runTest()">
-<p>Test for <a href="" 83889</a>:
-This tests that there is no crash when using percentage value for scrollbar's padding property. On success you should see a frame with scrollbars and one PASS message in it.
-<div style="height: 1000px;"></div>
-</body>
-</html>
Modified: trunk/Source/WebCore/ChangeLog (116753 => 116754)
--- trunk/Source/WebCore/ChangeLog 2012-05-11 12:41:52 UTC (rev 116753)
+++ trunk/Source/WebCore/ChangeLog 2012-05-11 12:45:05 UTC (rev 116754)
@@ -1,3 +1,16 @@
+2012-05-11 Sheriff Bot <webkit.review....@gmail.com>
+
+ Unreviewed, rolling out r116527.
+ http://trac.webkit.org/changeset/116527
+ https://bugs.webkit.org/show_bug.cgi?id=86199
+
+ Causing crashes on ClusterFuzz (Requested by inferno-sec on
+ #webkit).
+
+ * rendering/RenderScrollbar.cpp:
+ (WebCore::RenderScrollbar::updateScrollbarPart):
+ * rendering/RenderScrollbarPart.h:
+
2012-05-11 Yoshifumi Inoue <yo...@chromium.org>
[Forms] Move ValidityState methods implementation to another place
Modified: trunk/Source/WebCore/rendering/RenderScrollbar.cpp (116753 => 116754)
--- trunk/Source/WebCore/rendering/RenderScrollbar.cpp 2012-05-11 12:41:52 UTC (rev 116753)
+++ trunk/Source/WebCore/rendering/RenderScrollbar.cpp 2012-05-11 12:45:05 UTC (rev 116754)
@@ -270,11 +270,9 @@
RenderScrollbarPart* partRenderer = m_parts.get(partType);
if (!partRenderer && needRenderer) {
partRenderer = new (owningRenderer()->renderArena()) RenderScrollbarPart(owningRenderer()->document(), this, partType);
- partRenderer->setParent(owningRenderer());
m_parts.set(partType, partRenderer);
} else if (partRenderer && !needRenderer) {
m_parts.remove(partType);
- partRenderer->setParent(0);
partRenderer->destroy();
partRenderer = 0;
}
Modified: trunk/Source/WebCore/rendering/RenderScrollbarPart.h (116753 => 116754)
--- trunk/Source/WebCore/rendering/RenderScrollbarPart.h 2012-05-11 12:41:52 UTC (rev 116753)
+++ trunk/Source/WebCore/rendering/RenderScrollbarPart.h 2012-05-11 12:45:05 UTC (rev 116754)
@@ -35,8 +35,6 @@
class RenderScrollbarPart : public RenderBlock {
public:
- friend class RenderScrollbar;
-
RenderScrollbarPart(Node*, RenderScrollbar* = 0, ScrollbarPart = NoPart);
virtual ~RenderScrollbarPart();
