Title: [116762] trunk/Source/WebCore
- Revision
- 116762
- Author
- apav...@chromium.org
- Date
- 2012-05-11 06:42:50 -0700 (Fri, 11 May 2012)
Log Message
Web Inspector: Can't type spaces in "Override User Agent" field
https://bugs.webkit.org/show_bug.cgi?id=86202
Reviewed by Yury Semikhatsky.
* inspector/front-end/HelpScreen.js:
(WebInspector.HelpScreen.prototype.isClosingKey):
(WebInspector.HelpScreen.prototype._onKeyDown):
* inspector/front-end/SettingsScreen.js:
(WebInspector.SettingsScreen.prototype.isClosingKey):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (116761 => 116762)
--- trunk/Source/WebCore/ChangeLog 2012-05-11 13:39:38 UTC (rev 116761)
+++ trunk/Source/WebCore/ChangeLog 2012-05-11 13:42:50 UTC (rev 116762)
@@ -1,3 +1,16 @@
+2012-05-11 Alexander Pavlov <apav...@chromium.org>
+
+ Web Inspector: Can't type spaces in "Override User Agent" field
+ https://bugs.webkit.org/show_bug.cgi?id=86202
+
+ Reviewed by Yury Semikhatsky.
+
+ * inspector/front-end/HelpScreen.js:
+ (WebInspector.HelpScreen.prototype.isClosingKey):
+ (WebInspector.HelpScreen.prototype._onKeyDown):
+ * inspector/front-end/SettingsScreen.js:
+ (WebInspector.SettingsScreen.prototype.isClosingKey):
+
2012-05-11 Dominik Röttsches <dominik.rottsc...@intel.com>
[EFL][DRT] Input Attribute Placeholder RefTests failing
Modified: trunk/Source/WebCore/inspector/front-end/HelpScreen.js (116761 => 116762)
--- trunk/Source/WebCore/inspector/front-end/HelpScreen.js 2012-05-11 13:39:38 UTC (rev 116761)
+++ trunk/Source/WebCore/inspector/front-end/HelpScreen.js 2012-05-11 13:42:50 UTC (rev 116762)
@@ -47,11 +47,6 @@
closeButton.textContent = "\u2716"; // Code stands for HEAVY MULTIPLICATION X.
closeButton.addEventListener("click", this.hide.bind(this), false);
- this._closeKeys = [
- WebInspector.KeyboardShortcut.Keys.Enter.code,
- WebInspector.KeyboardShortcut.Keys.Esc.code,
- WebInspector.KeyboardShortcut.Keys.Space.code,
- ];
}
WebInspector.HelpScreen.visibleScreen_ = null;
@@ -88,9 +83,22 @@
}
},
+ /**
+ * @param {number} keyCode
+ * @return {boolean}
+ */
+ isClosingKey: function(keyCode)
+ {
+ return [
+ WebInspector.KeyboardShortcut.Keys.Enter.code,
+ WebInspector.KeyboardShortcut.Keys.Esc.code,
+ WebInspector.KeyboardShortcut.Keys.Space.code,
+ ].indexOf(keyCode) >= 0;
+ },
+
_onKeyDown: function(event)
{
- if (this._isShown && this._closeKeys.indexOf(event.keyCode) >= 0) {
+ if (this._isShown && this.isClosingKey(event.keyCode)) {
this.hide();
event.consume();
}
Modified: trunk/Source/WebCore/inspector/front-end/SettingsScreen.js (116761 => 116762)
--- trunk/Source/WebCore/inspector/front-end/SettingsScreen.js 2012-05-11 13:39:38 UTC (rev 116761)
+++ trunk/Source/WebCore/inspector/front-end/SettingsScreen.js 2012-05-11 13:42:50 UTC (rev 116762)
@@ -114,7 +114,19 @@
}
WebInspector.SettingsScreen.prototype = {
+
/**
+ * @override
+ */
+ isClosingKey: function(keyCode)
+ {
+ return [
+ WebInspector.KeyboardShortcut.Keys.Enter.code,
+ WebInspector.KeyboardShortcut.Keys.Esc.code,
+ ].indexOf(keyCode) >= 0;
+ },
+
+ /**
* @param {string} name
* @param {boolean=} right
*/
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
