Title: [117435] trunk
- Revision
- 117435
- Author
- commit-qu...@webkit.org
- Date
- 2012-05-17 05:30:11 -0700 (Thu, 17 May 2012)
Log Message
[Qt][WK2] fast/events/page-visibility-* tests fail
https://bugs.webkit.org/show_bug.cgi?id=83263
Patch by Hugo Parente Lima <hugo.l...@openbossa.org> on 2012-05-17
Reviewed by Kenneth Rohde Christiansen.
Tools:
Handle "preview" state and avoid string conversion.
* WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
(WTR::LayoutTestController::setPageVisibility):
LayoutTests:
Unskip two page-visibility tests: iframe-propagation-test.html
and transition-test.html.
* platform/qt-5.0-wk2/Skipped:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (117434 => 117435)
--- trunk/LayoutTests/ChangeLog 2012-05-17 12:27:44 UTC (rev 117434)
+++ trunk/LayoutTests/ChangeLog 2012-05-17 12:30:11 UTC (rev 117435)
@@ -1,3 +1,15 @@
+2012-05-17 Hugo Parente Lima <hugo.l...@openbossa.org>
+
+ [Qt][WK2] fast/events/page-visibility-* tests fail
+ https://bugs.webkit.org/show_bug.cgi?id=83263
+
+ Reviewed by Kenneth Rohde Christiansen.
+
+ Unskip two page-visibility tests: iframe-propagation-test.html
+ and transition-test.html.
+
+ * platform/qt-5.0-wk2/Skipped:
+
2012-05-17 Csaba Osztrogonác <o...@webkit.org>
[Qt] Unreviewed gardening, unksip one more now passing test.
Modified: trunk/LayoutTests/platform/qt-5.0-wk2/Skipped (117434 => 117435)
--- trunk/LayoutTests/platform/qt-5.0-wk2/Skipped 2012-05-17 12:27:44 UTC (rev 117434)
+++ trunk/LayoutTests/platform/qt-5.0-wk2/Skipped 2012-05-17 12:30:11 UTC (rev 117435)
@@ -76,8 +76,6 @@
# Still failing after implementing layoutTestController.setPageVisibility()
# https://bugs.webkit.org/show_bug.cgi?id=83263
fast/events/page-visibility-iframe-move-test.html
-fast/events/page-visibility-iframe-propagation-test.html
-fast/events/page-visibility-transition-test.html
svg/custom/mouse-move-on-svg-container.xhtml
svg/custom/mouse-move-on-svg-root-standalone.svg
Modified: trunk/Tools/ChangeLog (117434 => 117435)
--- trunk/Tools/ChangeLog 2012-05-17 12:27:44 UTC (rev 117434)
+++ trunk/Tools/ChangeLog 2012-05-17 12:30:11 UTC (rev 117435)
@@ -1,3 +1,15 @@
+2012-05-17 Hugo Parente Lima <hugo.l...@openbossa.org>
+
+ [Qt][WK2] fast/events/page-visibility-* tests fail
+ https://bugs.webkit.org/show_bug.cgi?id=83263
+
+ Reviewed by Kenneth Rohde Christiansen.
+
+ Handle "preview" state and avoid string conversion.
+
+ * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
+ (WTR::LayoutTestController::setPageVisibility):
+
2012-05-17 Gyuyoung Kim <gyuyoung....@samsung.com>
Convert setDomainRelaxationForbiddenForURLScheme to use InternalSettings interface
Modified: trunk/Tools/WebKitTestRunner/InjectedBundle/LayoutTestController.cpp (117434 => 117435)
--- trunk/Tools/WebKitTestRunner/InjectedBundle/LayoutTestController.cpp 2012-05-17 12:27:44 UTC (rev 117434)
+++ trunk/Tools/WebKitTestRunner/InjectedBundle/LayoutTestController.cpp 2012-05-17 12:30:11 UTC (rev 117435)
@@ -545,13 +545,14 @@
void LayoutTestController::setPageVisibility(JSStringRef state)
{
- WKStringRef visibilityStateKey = toWK(state).get();
WebCore::PageVisibilityState visibilityState = WebCore::PageVisibilityStateVisible;
- if (WKStringIsEqualToUTF8CString(visibilityStateKey, "hidden"))
+ if (JSStringIsEqualToUTF8CString(state, "hidden"))
visibilityState = WebCore::PageVisibilityStateHidden;
- else if (WKStringIsEqualToUTF8CString(visibilityStateKey, "prerender"))
+ else if (JSStringIsEqualToUTF8CString(state, "prerender"))
visibilityState = WebCore::PageVisibilityStatePrerender;
+ else if (JSStringIsEqualToUTF8CString(state, "preview"))
+ visibilityState = WebCore::PageVisibilityStatePreview;
WKBundleSetPageVisibilityState(InjectedBundle::shared().bundle(), InjectedBundle::shared().pageGroup(), visibilityState, /* isInitialState */ false);
}
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
