Title: [117442] trunk/Source/WebCore
Revision
117442
Author
commit-qu...@webkit.org
Date
2012-05-17 06:32:09 -0700 (Thu, 17 May 2012)

Log Message

Web Inspector: DOM Breakpoints Pane should allow to Remove All the breakpoints
https://bugs.webkit.org/show_bug.cgi?id=86716

Patch by Vivek Galatage <vivekgalat...@gmail.com> on 2012-05-17
Reviewed by Yury Semikhatsky.

Added a new context menu to provide Remove All DOM breakpoint option.

UI Feature. Tests not required.

* English.lproj/localizedStrings.js:
* inspector/front-end/DOMBreakpointsSidebarPane.js:
(WebInspector.DOMBreakpointsSidebarPane.prototype._removeAllBreakpoints):
(WebInspector.DOMBreakpointsSidebarPane.prototype._contextMenu):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (117441 => 117442)


--- trunk/Source/WebCore/ChangeLog	2012-05-17 13:29:51 UTC (rev 117441)
+++ trunk/Source/WebCore/ChangeLog	2012-05-17 13:32:09 UTC (rev 117442)
@@ -1,3 +1,19 @@
+2012-05-17  Vivek Galatage  <vivekgalat...@gmail.com>
+
+        Web Inspector: DOM Breakpoints Pane should allow to Remove All the breakpoints
+        https://bugs.webkit.org/show_bug.cgi?id=86716
+
+        Reviewed by Yury Semikhatsky.
+
+        Added a new context menu to provide Remove All DOM breakpoint option.
+
+        UI Feature. Tests not required.
+
+        * English.lproj/localizedStrings.js:
+        * inspector/front-end/DOMBreakpointsSidebarPane.js:
+        (WebInspector.DOMBreakpointsSidebarPane.prototype._removeAllBreakpoints):
+        (WebInspector.DOMBreakpointsSidebarPane.prototype._contextMenu):
+
 2012-05-17  Ilya Tikhonovsky  <loi...@chromium.org>
 
         Web Inspector: HeapSnapshot: speed-up calculateObjectToWindowDistance

Modified: trunk/Source/WebCore/English.lproj/localizedStrings.js


(Binary files differ)

Modified: trunk/Source/WebCore/inspector/front-end/DOMBreakpointsSidebarPane.js (117441 => 117442)


--- trunk/Source/WebCore/inspector/front-end/DOMBreakpointsSidebarPane.js	2012-05-17 13:29:51 UTC (rev 117441)
+++ trunk/Source/WebCore/inspector/front-end/DOMBreakpointsSidebarPane.js	2012-05-17 13:32:09 UTC (rev 117442)
@@ -211,6 +211,15 @@
             DOMDebuggerAgent.setDOMBreakpoint(node.id, type);
     },
 
+    _removeAllBreakpoints: function()
+    {
+        for (var id in this._breakpointElements) {
+            var element = this._breakpointElements[id];
+            this._removeBreakpoint(element._node, element._type);
+        }
+        this._saveBreakpoints();
+    },
+
     _removeBreakpoint: function(node, type)
     {
         var breakpointId = this._createBreakpointId(node.id, type);
@@ -233,6 +242,7 @@
             this._saveBreakpoints();
         }
         contextMenu.appendItem(WebInspector.UIString("Remove Breakpoint"), removeBreakpoint.bind(this));
+        contextMenu.appendItem(WebInspector.UIString(WebInspector.useLowerCaseMenuTitles() ? "Remove all DOM breakpoints" : "Remove All DOM Breakpoints"), this._removeAllBreakpoints.bind(this));
         contextMenu.show(event);
     },
 
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to