Title: [117450] trunk/Source/WebCore
- Revision
- 117450
- Author
- yu...@chromium.org
- Date
- 2012-05-17 08:21:08 -0700 (Thu, 17 May 2012)
Log Message
[Chromium] Web Inspector: assertion failure when inspecting a shared worker in debug mode
https://bugs.webkit.org/show_bug.cgi?id=86726
Reviewed by Pavel Feldman.
No need to keep RefPtr to WorkerThread in a task that will be executed on
that thread, raw pointer can be used instead.
* inspector/WorkerDebuggerAgent.cpp:
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (117449 => 117450)
--- trunk/Source/WebCore/ChangeLog 2012-05-17 15:19:03 UTC (rev 117449)
+++ trunk/Source/WebCore/ChangeLog 2012-05-17 15:21:08 UTC (rev 117450)
@@ -1,3 +1,15 @@
+2012-05-17 Yury Semikhatsky <yu...@chromium.org>
+
+ [Chromium] Web Inspector: assertion failure when inspecting a shared worker in debug mode
+ https://bugs.webkit.org/show_bug.cgi?id=86726
+
+ Reviewed by Pavel Feldman.
+
+ No need to keep RefPtr to WorkerThread in a task that will be executed on
+ that thread, raw pointer can be used instead.
+
+ * inspector/WorkerDebuggerAgent.cpp:
+
2012-05-17 Kentaro Hara <hara...@chromium.org>
[V8][Refactoring] Support an optional 'message' argument for throwTypeError()
Modified: trunk/Source/WebCore/inspector/WorkerDebuggerAgent.cpp (117449 => 117450)
--- trunk/Source/WebCore/inspector/WorkerDebuggerAgent.cpp 2012-05-17 15:19:03 UTC (rev 117449)
+++ trunk/Source/WebCore/inspector/WorkerDebuggerAgent.cpp 2012-05-17 15:21:08 UTC (rev 117450)
@@ -67,12 +67,12 @@
{
// Process all queued debugger commands. It is safe to use m_workerContext here
// because it is alive if RunWorkerLoop is not terminated, otherwise it will
- // just be ignored.
+ // just be ignored. WorkerThread is certainly alive if this task is being executed.
while (MessageQueueMessageReceived == m_thread->runLoop().runInMode(m_workerContext, WorkerDebuggerAgent::debuggerTaskMode, WorkerRunLoop::DontWaitForMessage)) { }
}
private:
- RefPtr<WorkerThread> m_thread;
+ WorkerThread* m_thread;
WorkerContext* m_workerContext;
};
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
