Title: [117584] trunk/Source/WebKit/efl
- Revision
- 117584
- Author
- [email protected]
- Date
- 2012-05-18 06:55:08 -0700 (Fri, 18 May 2012)
Log Message
[EFL] Text input events are emitted for nodes that do not allow editing.
https://bugs.webkit.org/show_bug.cgi?id=86836
Patch by Mikhail Pozdnyakov <[email protected]> on 2012-05-18
Reviewed by Kenneth Rohde Christiansen.
Text input events are not anymore emitted for nodes that do not allow editing.
This can be checked with fast/events/key-events-in-input-button.html test output.
* WebCoreSupport/EditorClientEfl.cpp:
(WebCore::EditorClientEfl::handleEditingKeyboardEvent): Returns false if the node cannot edit.
Modified Paths
Diff
Modified: trunk/Source/WebKit/efl/ChangeLog (117583 => 117584)
--- trunk/Source/WebKit/efl/ChangeLog 2012-05-18 13:46:47 UTC (rev 117583)
+++ trunk/Source/WebKit/efl/ChangeLog 2012-05-18 13:55:08 UTC (rev 117584)
@@ -1,3 +1,16 @@
+2012-05-18 Mikhail Pozdnyakov <[email protected]>
+
+ [EFL] Text input events are emitted for nodes that do not allow editing.
+ https://bugs.webkit.org/show_bug.cgi?id=86836
+
+ Reviewed by Kenneth Rohde Christiansen.
+
+ Text input events are not anymore emitted for nodes that do not allow editing.
+ This can be checked with fast/events/key-events-in-input-button.html test output.
+
+ * WebCoreSupport/EditorClientEfl.cpp:
+ (WebCore::EditorClientEfl::handleEditingKeyboardEvent): Returns false if the node cannot edit.
+
2012-05-18 MORITA Hajime <[email protected]>
https://bugs.webkit.org/show_bug.cgi?id=85515
Modified: trunk/Source/WebKit/efl/WebCoreSupport/EditorClientEfl.cpp (117583 => 117584)
--- trunk/Source/WebKit/efl/WebCoreSupport/EditorClientEfl.cpp 2012-05-18 13:46:47 UTC (rev 117583)
+++ trunk/Source/WebKit/efl/WebCoreSupport/EditorClientEfl.cpp 2012-05-18 13:55:08 UTC (rev 117584)
@@ -441,6 +441,10 @@
if (command.execute(event))
return true;
+ // Don't allow text insertion for nodes that cannot edit.
+ if (!frame->editor()->canEdit())
+ return false;
+
// Don't insert null or control characters as they can result in unexpected behaviour
if (event->charCode() < ' ')
return false;
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
