Title: [117965] trunk/Source/WebCore
- Revision
- 117965
- Author
- vse...@chromium.org
- Date
- 2012-05-22 06:50:35 -0700 (Tue, 22 May 2012)
Log Message
Web Inspector: _javascript_ breakpoints disappear when Ctrl+S is pressed for the script without changes.
https://bugs.webkit.org/show_bug.cgi?id=87121
Reviewed by Pavel Feldman.
_javascript_SourceFrame and StylesSourceFrame should not commit working copy unless UISourceCode is dirty.
* inspector/front-end/_javascript_SourceFrame.js:
(WebInspector._javascript_SourceFrame.prototype.commitEditing):
* inspector/front-end/StylesPanel.js:
(WebInspector.StyleSourceFrame.prototype.commitEditing):
* inspector/front-end/UISourceCode.js:
(WebInspector.UISourceCode.prototype.commitWorkingCopy):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (117964 => 117965)
--- trunk/Source/WebCore/ChangeLog 2012-05-22 13:47:11 UTC (rev 117964)
+++ trunk/Source/WebCore/ChangeLog 2012-05-22 13:50:35 UTC (rev 117965)
@@ -1,3 +1,19 @@
+2012-05-22 Vsevolod Vlasov <vse...@chromium.org>
+
+ Web Inspector: _javascript_ breakpoints disappear when Ctrl+S is pressed for the script without changes.
+ https://bugs.webkit.org/show_bug.cgi?id=87121
+
+ Reviewed by Pavel Feldman.
+
+ _javascript_SourceFrame and StylesSourceFrame should not commit working copy unless UISourceCode is dirty.
+
+ * inspector/front-end/_javascript_SourceFrame.js:
+ (WebInspector._javascript_SourceFrame.prototype.commitEditing):
+ * inspector/front-end/StylesPanel.js:
+ (WebInspector.StyleSourceFrame.prototype.commitEditing):
+ * inspector/front-end/UISourceCode.js:
+ (WebInspector.UISourceCode.prototype.commitWorkingCopy):
+
2012-05-22 Ilya Tikhonovsky <loi...@chromium.org>
Web Inspector: HeapSnapshot: speed-up calculateRetainedSize functon.
Modified: trunk/Source/WebCore/inspector/front-end/_javascript_SourceFrame.js (117964 => 117965)
--- trunk/Source/WebCore/inspector/front-end/_javascript_SourceFrame.js 2012-05-22 13:47:11 UTC (rev 117964)
+++ trunk/Source/WebCore/inspector/front-end/_javascript_SourceFrame.js 2012-05-22 13:50:35 UTC (rev 117965)
@@ -92,6 +92,9 @@
*/
commitEditing: function(text)
{
+ if (!this._uiSourceCode.isDirty())
+ return;
+
this._isCommittingEditing = true;
this._uiSourceCode.commitWorkingCopy(this._didEditContent.bind(this));
},
Modified: trunk/Source/WebCore/inspector/front-end/StylesPanel.js (117964 => 117965)
--- trunk/Source/WebCore/inspector/front-end/StylesPanel.js 2012-05-22 13:47:11 UTC (rev 117964)
+++ trunk/Source/WebCore/inspector/front-end/StylesPanel.js 2012-05-22 13:50:35 UTC (rev 117965)
@@ -145,6 +145,9 @@
*/
commitEditing: function(text)
{
+ if (!this._styleSource.isDirty())
+ return;
+
this._isCommittingEditing = true;
this._styleSource.commitWorkingCopy(this._didEditContent.bind(this));
},
Modified: trunk/Source/WebCore/inspector/front-end/UISourceCode.js (117964 => 117965)
--- trunk/Source/WebCore/inspector/front-end/UISourceCode.js 2012-05-22 13:47:11 UTC (rev 117964)
+++ trunk/Source/WebCore/inspector/front-end/UISourceCode.js 2012-05-22 13:50:35 UTC (rev 117965)
@@ -211,11 +211,6 @@
callback(error);
}
- if (!this.isDirty()) {
- callback(null);
- return;
- }
-
var newContent = this._workingCopy;
this._committingWorkingCopy = true;
this.workingCopyCommitted(innerCallback.bind(this));
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
