Title: [118198] trunk/Tools
Revision
118198
Author
kev...@webkit.org
Date
2012-05-23 10:32:29 -0700 (Wed, 23 May 2012)

Log Message

[wx] In wxWebKit release builds on MSW, keep release settings but also build the 
debug symbols for easier debugging.
https://bugs.webkit.org/show_bug.cgi?id=87151

Reviewed by Kevin Ollivier.

Modified Paths

Diff

Modified: trunk/Tools/ChangeLog (118197 => 118198)


--- trunk/Tools/ChangeLog	2012-05-23 17:31:26 UTC (rev 118197)
+++ trunk/Tools/ChangeLog	2012-05-23 17:32:29 UTC (rev 118198)
@@ -1,3 +1,14 @@
+2012-05-23  Malcolm MacLeod <malcolm.macl...@tshwanedje.com>
+
+        [wx] In wxWebKit release builds on MSW, keep release settings but also build the 
+        debug symbols for easier debugging.
+        https://bugs.webkit.org/show_bug.cgi?id=87151
+
+        Reviewed by Kevin Ollivier.
+
+        * waf/build/settings.py:
+        (common_configure):
+
 2012-05-23  Carlos Garcia Campos  <cgar...@igalia.com>
 
         Unreviewed. Move myself to reviewers.

Modified: trunk/Tools/waf/build/settings.py (118197 => 118198)


--- trunk/Tools/waf/build/settings.py	2012-05-23 17:31:26 UTC (rev 118197)
+++ trunk/Tools/waf/build/settings.py	2012-05-23 17:32:29 UTC (rev 118198)
@@ -353,7 +353,11 @@
             conf.env.append_value('LIBPATH', os.path.join(msvclibs_dir, 'lib'))
             # wx settings
             global config
-            is_debug = (config == 'Debug')
+            is_debug = (config == 'Debug')            
+            # generate debug symbols even in release mode, as it helps debugging.
+            if not is_debug:
+                conf.env.append_value('CXXFLAGS', '/Zi')
+                conf.env.append_value('LINKFLAGS', '/debug')
             wxdefines, wxincludes, wxlibs, wxlibpaths = get_wxmsw_settings(wx_root, shared=True, unicode=True, debug=is_debug, wxPython=Options.options.wxpython)
             conf.env['CXXDEFINES_WX'] = wxdefines
             conf.env['CPPPATH_WX'] = wxincludes
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to