Title: [118615] trunk/Source/WebKit2
- Revision
- 118615
- Author
- m...@apple.com
- Date
- 2012-05-26 15:08:43 -0700 (Sat, 26 May 2012)
Log Message
REGRESSION (r116720): Subframe PDF scrolls extremely slowly
https://bugs.webkit.org/show_bug.cgi?id=87557
<rdar://problem/11499408>
Reviewed by Anders Carlsson.
It's not possible to make an automated test for this.
* WebProcess/Plugins/PDF/BuiltInPDFView.mm:
(WebKit::BuiltInPDFView::wantsWheelEvents): Return true instead of false and delete
misleading comment. While the built-in PDF view would get added to the set of scrollable
areas anyway, there are some code paths that check wantsWheelEvents explicitly, so it seems
necessary to reutrn true.
Modified Paths
Diff
Modified: trunk/Source/WebKit2/ChangeLog (118614 => 118615)
--- trunk/Source/WebKit2/ChangeLog 2012-05-26 21:25:29 UTC (rev 118614)
+++ trunk/Source/WebKit2/ChangeLog 2012-05-26 22:08:43 UTC (rev 118615)
@@ -1,3 +1,19 @@
+2012-05-25 Maciej Stachowiak <m...@apple.com>
+
+ REGRESSION (r116720): Subframe PDF scrolls extremely slowly
+ https://bugs.webkit.org/show_bug.cgi?id=87557
+ <rdar://problem/11499408>
+
+ Reviewed by Anders Carlsson.
+
+ It's not possible to make an automated test for this.
+
+ * WebProcess/Plugins/PDF/BuiltInPDFView.mm:
+ (WebKit::BuiltInPDFView::wantsWheelEvents): Return true instead of false and delete
+ misleading comment. While the built-in PDF view would get added to the set of scrollable
+ areas anyway, there are some code paths that check wantsWheelEvents explicitly, so it seems
+ necessary to reutrn true.
+
2012-05-25 Brady Eidson <beid...@apple.com>
https://bugs.webkit.org/show_bug.cgi?id=87418
Modified: trunk/Source/WebKit2/WebProcess/Plugins/PDF/BuiltInPDFView.mm (118614 => 118615)
--- trunk/Source/WebKit2/WebProcess/Plugins/PDF/BuiltInPDFView.mm 2012-05-26 21:25:29 UTC (rev 118614)
+++ trunk/Source/WebKit2/WebProcess/Plugins/PDF/BuiltInPDFView.mm 2012-05-26 22:08:43 UTC (rev 118615)
@@ -473,8 +473,7 @@
bool BuiltInPDFView::wantsWheelEvents()
{
- // We return false here even though we do want wheel events, because we add ourselves to the scrollable area set in updateScrollbars().
- return false;
+ return true;
}
void BuiltInPDFView::geometryDidChange(const IntSize& pluginSize, const IntRect& clipRect, const AffineTransform& pluginToRootViewTransform)
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
