Title: [118995] trunk/Source/_javascript_Core
- Revision
- 118995
- Author
- oli...@apple.com
- Date
- 2012-05-30 16:47:27 -0700 (Wed, 30 May 2012)
Log Message
Really provide error information with the inspector disabled
https://bugs.webkit.org/show_bug.cgi?id=87910
Reviewed by Filip Pizlo.
Don't bother checking for anything other than pre-existing error info.
In the absence of complete line number information you'll only get the
line a function starts on, but at least it's something.
* interpreter/Interpreter.cpp:
(JSC::Interpreter::throwException):
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (118994 => 118995)
--- trunk/Source/_javascript_Core/ChangeLog 2012-05-30 23:35:34 UTC (rev 118994)
+++ trunk/Source/_javascript_Core/ChangeLog 2012-05-30 23:47:27 UTC (rev 118995)
@@ -1,3 +1,17 @@
+2012-05-30 Oliver Hunt <oli...@apple.com>
+
+ Really provide error information with the inspector disabled
+ https://bugs.webkit.org/show_bug.cgi?id=87910
+
+ Reviewed by Filip Pizlo.
+
+ Don't bother checking for anything other than pre-existing error info.
+ In the absence of complete line number information you'll only get the
+ line a function starts on, but at least it's something.
+
+ * interpreter/Interpreter.cpp:
+ (JSC::Interpreter::throwException):
+
2012-05-30 Filip Pizlo <fpi...@apple.com>
LLInt broken on x86-32 with JIT turned off
Modified: trunk/Source/_javascript_Core/interpreter/Interpreter.cpp (118994 => 118995)
--- trunk/Source/_javascript_Core/interpreter/Interpreter.cpp 2012-05-30 23:35:34 UTC (rev 118994)
+++ trunk/Source/_javascript_Core/interpreter/Interpreter.cpp 2012-05-30 23:47:27 UTC (rev 118995)
@@ -1024,7 +1024,7 @@
if (exception->isErrorInstance() && static_cast<ErrorInstance*>(exception)->appendSourceToMessage())
appendSourceToError(callFrame, static_cast<ErrorInstance*>(exception), bytecodeOffset);
- if (codeBlock->hasLineInfo() && !hasErrorInfo(callFrame, exception)) {
+ if (!hasErrorInfo(callFrame, exception)) {
// FIXME: should only really be adding these properties to VM generated exceptions,
// but the inspector currently requires these for all thrown objects.
addErrorInfo(callFrame, exception, codeBlock->lineNumberForBytecodeOffset(bytecodeOffset), codeBlock->ownerExecutable()->source());
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
