Title: [119998] trunk
Revision
119998
Author
commit-qu...@webkit.org
Date
2012-06-11 12:45:20 -0700 (Mon, 11 Jun 2012)

Log Message

[EFL] REGRESSION (r119788): tests rely on pathToLocalResource are failing after r119788
https://bugs.webkit.org/show_bug.cgi?id=88661

Patch by Sudarsana Nagineni <sudarsana.nagin...@linux.intel.com> on 2012-06-11
Reviewed by Dirk Pranke.

Tools:

Pass string length explicitly when creating String object from
non-null-terminated UChar* returned by characters().

* DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
(LayoutTestController::pathToLocalResource):

LayoutTests:

Unskip test cases which rely on pathToLocalResource().

* platform/efl/TestExpectations:

Modified Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (119997 => 119998)


--- trunk/LayoutTests/ChangeLog	2012-06-11 18:54:52 UTC (rev 119997)
+++ trunk/LayoutTests/ChangeLog	2012-06-11 19:45:20 UTC (rev 119998)
@@ -1,3 +1,14 @@
+2012-06-11  Sudarsana Nagineni  <sudarsana.nagin...@linux.intel.com>
+
+        [EFL] REGRESSION (r119788): tests rely on pathToLocalResource are failing after r119788
+        https://bugs.webkit.org/show_bug.cgi?id=88661
+
+        Reviewed by Dirk Pranke.
+
+        Unskip test cases which rely on pathToLocalResource().
+
+        * platform/efl/TestExpectations:
+
 2012-06-11  Pravin D  <pravind....@gmail.com>
 
         Relative pos. input fields in columns vanish when you start typing in them

Modified: trunk/LayoutTests/platform/efl/TestExpectations (119997 => 119998)


--- trunk/LayoutTests/platform/efl/TestExpectations	2012-06-11 18:54:52 UTC (rev 119997)
+++ trunk/LayoutTests/platform/efl/TestExpectations	2012-06-11 19:45:20 UTC (rev 119998)
@@ -684,24 +684,6 @@
 BUGWK86633 : editing/spelling/spelling-linebreak.html = TEXT
 BUGWK86633 : editing/spelling/spelling-unified-emulation.html = TEXT
 
-// Tests that rely on pathToLocalResource are failing after r119788
-BUGWK88661 SKIP : fast/dom/frame-loading-via-document-write.html = FAIL
-BUGWK88661 SKIP : fast/loader/local-CSS-from-local.html = FAIL
-BUGWK88661 SKIP : fast/loader/local-_javascript_-from-local.html = FAIL
-BUGWK88661 SKIP : fast/loader/local-iFrame-source-from-local.html = FAIL
-BUGWK88661 SKIP : fast/loader/local-image-from-local.html = FAIL
-BUGWK88661 SKIP : http/tests/plugins/post-url-file.html = FAIL
-BUGWK88661 SKIP : http/tests/security/frame-loading-via-document-write.html = FAIL
-BUGWK88661 SKIP : http/tests/security/local-CSS-from-remote.html = FAIL
-BUGWK88661 SKIP : http/tests/security/local-_javascript_-from-remote.html = FAIL
-BUGWK88661 SKIP : http/tests/security/local-iFrame-from-remote.html = FAIL
-BUGWK88661 SKIP : http/tests/security/local-image-from-remote-whitelisted.html = FAIL
-BUGWK88661 SKIP : http/tests/security/local-image-from-remote.html = FAIL
-BUGWK88661 SKIP : http/tests/security/local-user-CSS-from-remote.html = FAIL
-BUGWK88661 SKIP : http/tests/security/local-video-poster-from-remote.html = FAIL
-BUGWK88661 SKIP : http/tests/security/local-video-source-from-remote.html = FAIL
-BUGWK88661 SKIP : http/tests/security/local-video-src-from-remote.html = FAIL
-
 // Failing after r119268 on GTK and EFL
 BUGWK88138 : http/tests/media/video-buffered.html = TEXT
 

Modified: trunk/Tools/ChangeLog (119997 => 119998)


--- trunk/Tools/ChangeLog	2012-06-11 18:54:52 UTC (rev 119997)
+++ trunk/Tools/ChangeLog	2012-06-11 19:45:20 UTC (rev 119998)
@@ -1,3 +1,16 @@
+2012-06-11  Sudarsana Nagineni  <sudarsana.nagin...@linux.intel.com>
+
+        [EFL] REGRESSION (r119788): tests rely on pathToLocalResource are failing after r119788
+        https://bugs.webkit.org/show_bug.cgi?id=88661
+
+        Reviewed by Dirk Pranke.
+
+        Pass string length explicitly when creating String object from
+        non-null-terminated UChar* returned by characters().
+
+        * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
+        (LayoutTestController::pathToLocalResource):
+
 2012-06-11  David Dorwin  <ddor...@chromium.org>
 
         [chromium] Provide access to the WebPlugin created by the helper plugin widget

Modified: trunk/Tools/DumpRenderTree/efl/LayoutTestControllerEfl.cpp (119997 => 119998)


--- trunk/Tools/DumpRenderTree/efl/LayoutTestControllerEfl.cpp	2012-06-11 18:54:52 UTC (rev 119997)
+++ trunk/Tools/DumpRenderTree/efl/LayoutTestControllerEfl.cpp	2012-06-11 19:45:20 UTC (rev 119998)
@@ -178,7 +178,7 @@
 
 JSStringRef LayoutTestController::pathToLocalResource(JSContextRef context, JSStringRef url)
 {
-    String requestedUrl(url->characters());
+    String requestedUrl(url->characters(), url->length());
     String resourceRoot;
     String requestedRoot;
 
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to