Title: [120128] trunk/Source/WebKit/chromium
- Revision
- 120128
- Author
- dan...@chromium.org
- Date
- 2012-06-12 15:02:51 -0700 (Tue, 12 Jun 2012)
Log Message
[chromium] Set contentBounds() on impl layers in CCLayerTreeHostCommonTests
https://bugs.webkit.org/show_bug.cgi?id=88903
Reviewed by Adrienne Walker.
Without setting the contentBounds() on impl layers, the visibleLayerRect
will be wrong. This is not the case for main-thread layers, which most
of the tests in this file use. But this is a potential serious confusion
for future test implementors so I'd like to make it explicit now.
* tests/CCLayerTreeHostCommonTest.cpp:
Modified Paths
Diff
Modified: trunk/Source/WebKit/chromium/ChangeLog (120127 => 120128)
--- trunk/Source/WebKit/chromium/ChangeLog 2012-06-12 21:57:05 UTC (rev 120127)
+++ trunk/Source/WebKit/chromium/ChangeLog 2012-06-12 22:02:51 UTC (rev 120128)
@@ -1,5 +1,19 @@
2012-06-12 Dana Jansens <dan...@chromium.org>
+ [chromium] Set contentBounds() on impl layers in CCLayerTreeHostCommonTests
+ https://bugs.webkit.org/show_bug.cgi?id=88903
+
+ Reviewed by Adrienne Walker.
+
+ Without setting the contentBounds() on impl layers, the visibleLayerRect
+ will be wrong. This is not the case for main-thread layers, which most
+ of the tests in this file use. But this is a potential serious confusion
+ for future test implementors so I'd like to make it explicit now.
+
+ * tests/CCLayerTreeHostCommonTest.cpp:
+
+2012-06-12 Dana Jansens <dan...@chromium.org>
+
[chromium] Return empty visibleLayerRect for layers with empty content bounds
https://bugs.webkit.org/show_bug.cgi?id=88901
Modified: trunk/Source/WebKit/chromium/tests/CCLayerTreeHostCommonTest.cpp (120127 => 120128)
--- trunk/Source/WebKit/chromium/tests/CCLayerTreeHostCommonTest.cpp 2012-06-12 21:57:05 UTC (rev 120127)
+++ trunk/Source/WebKit/chromium/tests/CCLayerTreeHostCommonTest.cpp 2012-06-12 22:02:51 UTC (rev 120128)
@@ -67,6 +67,7 @@
void setLayerPropertiesForTesting(CCLayerImpl* layer, const WebTransformationMatrix& transform, const WebTransformationMatrix& sublayerTransform, const FloatPoint& anchor, const FloatPoint& position, const IntSize& bounds, bool preserves3D)
{
setLayerPropertiesForTesting<CCLayerImpl>(layer, transform, sublayerTransform, anchor, position, bounds, preserves3D);
+ layer->setContentBounds(bounds);
}
void executeCalculateDrawTransformsAndVisibility(LayerChromium* rootLayer)
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
