Title: [120453] trunk/Source/WebCore
- Revision
- 120453
- Author
- commit-qu...@webkit.org
- Date
- 2012-06-15 07:17:29 -0700 (Fri, 15 Jun 2012)
Log Message
[BlackBerry] media volume slider in wrong position (master_38 regression)
https://bugs.webkit.org/show_bug.cgi?id=89165
Patch by Max Feil <mf...@rim.com> on 2012-06-15
Reviewed by Antonio Gomes.
Due to upstream simplification of the volume slider (webkit.org
bug 82150) it now appears in the wrong location below the
media controls. The programmatic controls sizing we do in
RenderThemeBlackBerry.cpp relies on absolute positioning of the
volume slider container, so the best way to fix this is to set
the bottom offset.
No new tests since this is a regression fix. BlackBerry media
controls are manually tested.
* platform/blackberry/RenderThemeBlackBerry.cpp:
(WebCore::RenderThemeBlackBerry::adjustMediaControlStyle):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (120452 => 120453)
--- trunk/Source/WebCore/ChangeLog 2012-06-15 14:14:43 UTC (rev 120452)
+++ trunk/Source/WebCore/ChangeLog 2012-06-15 14:17:29 UTC (rev 120453)
@@ -1,3 +1,23 @@
+2012-06-15 Max Feil <mf...@rim.com>
+
+ [BlackBerry] media volume slider in wrong position (master_38 regression)
+ https://bugs.webkit.org/show_bug.cgi?id=89165
+
+ Reviewed by Antonio Gomes.
+
+ Due to upstream simplification of the volume slider (webkit.org
+ bug 82150) it now appears in the wrong location below the
+ media controls. The programmatic controls sizing we do in
+ RenderThemeBlackBerry.cpp relies on absolute positioning of the
+ volume slider container, so the best way to fix this is to set
+ the bottom offset.
+
+ No new tests since this is a regression fix. BlackBerry media
+ controls are manually tested.
+
+ * platform/blackberry/RenderThemeBlackBerry.cpp:
+ (WebCore::RenderThemeBlackBerry::adjustMediaControlStyle):
+
2012-06-15 'Pavel Feldman' <pfeld...@chromium.org>
Not reviewed: remove garbage line from inspector view in docked-to-right mode.
Modified: trunk/Source/WebCore/platform/blackberry/RenderThemeBlackBerry.cpp (120452 => 120453)
--- trunk/Source/WebCore/platform/blackberry/RenderThemeBlackBerry.cpp 2012-06-15 14:14:43 UTC (rev 120452)
+++ trunk/Source/WebCore/platform/blackberry/RenderThemeBlackBerry.cpp 2012-06-15 14:17:29 UTC (rev 120453)
@@ -776,6 +776,7 @@
case MediaVolumeSliderContainerPart:
style->setWidth(controlsHeight);
style->setHeight(volumeHeight);
+ style->setBottom(controlsHeight);
break;
default:
break;
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
