Title: [121248] trunk/Tools
- Revision
- 121248
- Author
- jocelyn.turco...@nokia.com
- Date
- 2012-06-26 03:16:05 -0700 (Tue, 26 Jun 2012)
Log Message
Add a note about hostname completion not working well with --cc completion
Reviewed by Simon Hausmann.
Hostname completion tries to resolve anything after an @ sign which is present
in the completed list of contributor emails to CC.
* Scripts/webkit-tools-completion.sh:
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (121247 => 121248)
--- trunk/Tools/ChangeLog 2012-06-26 10:11:28 UTC (rev 121247)
+++ trunk/Tools/ChangeLog 2012-06-26 10:16:05 UTC (rev 121248)
@@ -1,3 +1,14 @@
+2012-06-25 Jocelyn Turcotte <turcott...@gmail.com>
+
+ Add a note about hostname completion not working well with --cc completion
+
+ Reviewed by Simon Hausmann.
+
+ Hostname completion tries to resolve anything after an @ sign which is present
+ in the completed list of contributor emails to CC.
+
+ * Scripts/webkit-tools-completion.sh:
+
2012-06-26 Sheriff Bot <webkit.review....@gmail.com>
Unreviewed, rolling out r121244.
Modified: trunk/Tools/Scripts/webkit-tools-completion.sh (121247 => 121248)
--- trunk/Tools/Scripts/webkit-tools-completion.sh 2012-06-26 10:11:28 UTC (rev 121247)
+++ trunk/Tools/Scripts/webkit-tools-completion.sh 2012-06-26 10:16:05 UTC (rev 121248)
@@ -39,6 +39,7 @@
__webkit-patch_upload_cc_generate_reply()
{
+ # Note: This won't work well if hostname completion is enabled, disable it with: shopt -u hostcomplete
# Completion is done on tokens and our comma-separated list is one single token, so we have to do completion on the whole list each time.
# Return a \n separated list for each possible bugzilla email completion of the substring following the last comma.
# Redirect strerr to /dev/null to prevent noise in the shell if this ever breaks somehow.
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
