Title: [121571] trunk/Tools
- Revision
- 121571
- Author
- [email protected]
- Date
- 2012-06-29 10:29:42 -0700 (Fri, 29 Jun 2012)
Log Message
Add support for --force parameter to run-performance-tests
https://bugs.webkit.org/show_bug.cgi?id=90279
Reviewed by Dirk Pranke.
It's helpful to be able to run tests from the Skipped list of the performance tests.
* Scripts/webkitpy/performance_tests/perftestsrunner.py:
(PerfTestsRunner._parse_args):
(PerfTestsRunner._collect_tests):
* Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py: Add test.
(test_collect_tests_with_skipped_list):
Modified Paths
Property Changed
Diff
Modified: trunk/Tools/ChangeLog (121570 => 121571)
--- trunk/Tools/ChangeLog 2012-06-29 17:20:19 UTC (rev 121570)
+++ trunk/Tools/ChangeLog 2012-06-29 17:29:42 UTC (rev 121571)
@@ -1,3 +1,18 @@
+2012-06-29 Zoltan Horvath <[email protected]>
+
+ Add support for --force parameter to run-performance-tests
+ https://bugs.webkit.org/show_bug.cgi?id=90279
+
+ Reviewed by Dirk Pranke.
+
+ It's helpful to be able to run tests from the Skipped list of the performance tests.
+
+ * Scripts/webkitpy/performance_tests/perftestsrunner.py:
+ (PerfTestsRunner._parse_args):
+ (PerfTestsRunner._collect_tests):
+ * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py: Add test.
+ (test_collect_tests_with_skipped_list):
+
2012-06-29 Tony Chang <[email protected]>
[GTK] Enable CSS grid layout LayoutTests on GTK+
Modified: trunk/Tools/Scripts/webkitpy/performance_tests/perftestsrunner.py (121570 => 121571)
--- trunk/Tools/Scripts/webkitpy/performance_tests/perftestsrunner.py 2012-06-29 17:20:19 UTC (rev 121570)
+++ trunk/Tools/Scripts/webkitpy/performance_tests/perftestsrunner.py 2012-06-29 17:29:42 UTC (rev 121571)
@@ -101,6 +101,8 @@
help="Use WebKitTestRunner rather than DumpRenderTree."),
optparse.make_option("--replay", dest="replay", action="" default=False,
help="Run replay tests."),
+ optparse.make_option("--force", dest="skipped", action="" default=False,
+ help="Run all tests, including the ones in the Skipped list."),
]
return optparse.OptionParser(option_list=(perf_option_list)).parse_args(args)
@@ -128,7 +130,7 @@
tests = []
for path in test_files:
relative_path = self._port.relative_perf_test_filename(path).replace('\\', '/')
- if self._port.skips_perf_test(relative_path):
+ if self._port.skips_perf_test(relative_path) and not self._options.skipped:
continue
test = PerfTestFactory.create_perf_test(self._port, relative_path, path)
tests.append(test)
Property changes on: trunk/Tools/Scripts/webkitpy/performance_tests/perftestsrunner.py
___________________________________________________________________
Added: svn:executable
Modified: trunk/Tools/Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py (121570 => 121571)
--- trunk/Tools/Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py 2012-06-29 17:20:19 UTC (rev 121570)
+++ trunk/Tools/Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py 2012-06-29 17:29:42 UTC (rev 121571)
@@ -397,6 +397,17 @@
port.skipped_perf_tests = lambda: ['inspector/unsupported_test1.html', 'unsupported']
self.assertEqual(self._collect_tests_and_sort_test_name(runner), ['inspector/test1.html', 'inspector/test2.html'])
+ def test_collect_tests_with_skipped_list(self):
+ runner, port = self.create_runner(args=['--force'])
+
+ self._add_file(runner, 'inspector', 'test1.html')
+ self._add_file(runner, 'inspector', 'unsupported_test1.html')
+ self._add_file(runner, 'inspector', 'test2.html')
+ self._add_file(runner, 'inspector/resources', 'resource_file.html')
+ self._add_file(runner, 'unsupported', 'unsupported_test2.html')
+ port.skipped_perf_tests = lambda: ['inspector/unsupported_test1.html', 'unsupported']
+ self.assertEqual(self._collect_tests_and_sort_test_name(runner), ['inspector/test1.html', 'inspector/test2.html', 'inspector/unsupported_test1.html', 'unsupported/unsupported_test2.html'])
+
def test_collect_tests_with_page_load_svg(self):
runner, port = self.create_runner()
self._add_file(runner, 'PageLoad', 'some-svg-test.svg')
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
