Title: [121755] trunk/Source/WebKit/win
- Revision
- 121755
- Author
- [email protected]
- Date
- 2012-07-03 03:25:36 -0700 (Tue, 03 Jul 2012)
Log Message
[CSS Regions] Enabling regions on Windows lead to crash-on-launch for WebKit.exe
https://bugs.webkit.org/show_bug.cgi?id=90435
Patch by Mihai Balan <[email protected]> on 2012-07-03
Reviewed by Csaba Osztrogonác.
Initial patch for enabling regions led to WebKit crashing on launch. Moving the
IDL declarations for CSS regions getter/setter at the end of the file solves the
problem. As per http://trac.webkit.org/changeset/95650 seems it has to do with
binary compatibility.
* Interfaces/IWebPreferences.idl: Mover getter/setter for CSS regions at the end of file
Modified Paths
Diff
Modified: trunk/Source/WebKit/win/ChangeLog (121754 => 121755)
--- trunk/Source/WebKit/win/ChangeLog 2012-07-03 10:12:47 UTC (rev 121754)
+++ trunk/Source/WebKit/win/ChangeLog 2012-07-03 10:25:36 UTC (rev 121755)
@@ -1,3 +1,17 @@
+2012-07-03 Mihai Balan <[email protected]>
+
+ [CSS Regions] Enabling regions on Windows lead to crash-on-launch for WebKit.exe
+ https://bugs.webkit.org/show_bug.cgi?id=90435
+
+ Reviewed by Csaba Osztrogonác.
+
+ Initial patch for enabling regions led to WebKit crashing on launch. Moving the
+ IDL declarations for CSS regions getter/setter at the end of the file solves the
+ problem. As per http://trac.webkit.org/changeset/95650 seems it has to do with
+ binary compatibility.
+
+ * Interfaces/IWebPreferences.idl: Mover getter/setter for CSS regions at the end of file
+
2012-07-02 Benjamin Poulain <[email protected]>
Do not do any logging initialization when logging is disabled
Modified: trunk/Source/WebKit/win/Interfaces/IWebPreferences.idl (121754 => 121755)
--- trunk/Source/WebKit/win/Interfaces/IWebPreferences.idl 2012-07-03 10:12:47 UTC (rev 121754)
+++ trunk/Source/WebKit/win/Interfaces/IWebPreferences.idl 2012-07-03 10:25:36 UTC (rev 121755)
@@ -124,9 +124,6 @@
HRESULT arePlugInsEnabled([out, retval] BOOL* enabled);
HRESULT setPlugInsEnabled([in] BOOL enabled);
- HRESULT isCSSRegionsEnabled([out, retval] BOOL* enabled);
- HRESULT setCSSRegionsEnabled([in] BOOL enabled);
-
HRESULT allowsAnimatedImages([out, retval] BOOL* enabled);
HRESULT setAllowsAnimatedImages([in] BOOL enabled);
HRESULT allowAnimatedImageLooping([out, retval] BOOL* enabled);
@@ -210,4 +207,7 @@
HRESULT setShouldDisplayTextDescriptions(BOOL shouldDisplayTextDescriptions);
HRESULT shouldDisplayTextDescriptions(BOOL *shouldDisplayTextDescriptions);
+
+ HRESULT isCSSRegionsEnabled([out, retval] BOOL* enabled);
+ HRESULT setCSSRegionsEnabled([in] BOOL enabled);
}
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
