Title: [121776] trunk/Tools
- Revision
- 121776
- Author
- [email protected]
- Date
- 2012-07-03 09:15:24 -0700 (Tue, 03 Jul 2012)
Log Message
-Wunused-private-field cleanup, linux edition
https://bugs.webkit.org/show_bug.cgi?id=90463
Reviewed by Stephen White.
* DumpRenderTree/chromium/DRTDevToolsAgent.h:
* DumpRenderTree/chromium/GamepadController.h:
(GamepadController):
* DumpRenderTree/chromium/NotificationPresenter.h:
(NotificationPresenter::NotificationPresenter):
(NotificationPresenter):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (121775 => 121776)
--- trunk/Tools/ChangeLog 2012-07-03 16:04:50 UTC (rev 121775)
+++ trunk/Tools/ChangeLog 2012-07-03 16:15:24 UTC (rev 121776)
@@ -1,3 +1,17 @@
+2012-07-03 Nico Weber <[email protected]>
+
+ -Wunused-private-field cleanup, linux edition
+ https://bugs.webkit.org/show_bug.cgi?id=90463
+
+ Reviewed by Stephen White.
+
+ * DumpRenderTree/chromium/DRTDevToolsAgent.h:
+ * DumpRenderTree/chromium/GamepadController.h:
+ (GamepadController):
+ * DumpRenderTree/chromium/NotificationPresenter.h:
+ (NotificationPresenter::NotificationPresenter):
+ (NotificationPresenter):
+
2012-07-03 Sheriff Bot <[email protected]>
Unreviewed, rolling out r121766.
Modified: trunk/Tools/DumpRenderTree/chromium/DRTDevToolsAgent.h (121775 => 121776)
--- trunk/Tools/DumpRenderTree/chromium/DRTDevToolsAgent.h 2012-07-03 16:04:50 UTC (rev 121775)
+++ trunk/Tools/DumpRenderTree/chromium/DRTDevToolsAgent.h 2012-07-03 16:15:24 UTC (rev 121776)
@@ -88,7 +88,6 @@
TaskList m_taskList;
DRTDevToolsClient* m_drtDevToolsClient;
int m_routingID;
- WebKit::WebDevToolsAgent* m_webDevToolsAgent;
WebKit::WebView* m_webView;
};
Modified: trunk/Tools/DumpRenderTree/chromium/GamepadController.cpp (121775 => 121776)
--- trunk/Tools/DumpRenderTree/chromium/GamepadController.cpp 2012-07-03 16:04:50 UTC (rev 121775)
+++ trunk/Tools/DumpRenderTree/chromium/GamepadController.cpp 2012-07-03 16:15:24 UTC (rev 121776)
@@ -35,8 +35,7 @@
using namespace WebKit;
-GamepadController::GamepadController(TestShell* shell)
- : m_shell(shell)
+GamepadController::GamepadController(TestShell*)
{
bindMethod("connect", &GamepadController::connect);
bindMethod("disconnect", &GamepadController::disconnect);
Modified: trunk/Tools/DumpRenderTree/chromium/GamepadController.h (121775 => 121776)
--- trunk/Tools/DumpRenderTree/chromium/GamepadController.h 2012-07-03 16:04:50 UTC (rev 121775)
+++ trunk/Tools/DumpRenderTree/chromium/GamepadController.h 2012-07-03 16:15:24 UTC (rev 121776)
@@ -59,8 +59,6 @@
void setAxisData(const CppArgumentList&, CppVariant*);
void fallbackCallback(const CppArgumentList&, CppVariant*);
- TestShell* m_shell;
-
WebKit::WebGamepads internalData;
};
Modified: trunk/Tools/DumpRenderTree/chromium/NotificationPresenter.h (121775 => 121776)
--- trunk/Tools/DumpRenderTree/chromium/NotificationPresenter.h 2012-07-03 16:04:50 UTC (rev 121775)
+++ trunk/Tools/DumpRenderTree/chromium/NotificationPresenter.h 2012-07-03 16:15:24 UTC (rev 121776)
@@ -43,7 +43,7 @@
// A class that implements WebNotificationPresenter for DRT.
class NotificationPresenter : public WebKit::WebNotificationPresenter {
public:
- explicit NotificationPresenter(TestShell* shell) : m_shell(shell) { }
+ explicit NotificationPresenter(TestShell*) { }
virtual ~NotificationPresenter();
// Called by the LayoutTestController to simulate a user granting permission.
@@ -62,9 +62,6 @@
void reset() { m_allowedOrigins.clear(); }
private:
- // Non-owned pointer. The NotificationPresenter is owned by the test shell.
- TestShell* m_shell;
-
// Set of allowed origins.
HashSet<WTF::String> m_allowedOrigins;
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes