Title: [121972] trunk/Source/WebKit2
Revision
121972
Author
commit-qu...@webkit.org
Date
2012-07-06 07:49:53 -0700 (Fri, 06 Jul 2012)

Log Message

ProcessLauncher's WorkQueue's name is too long on Windows
https://bugs.webkit.org/show_bug.cgi?id=44041

Patch by Dominik Röttsches <dominik.rottsc...@intel.com> on 2012-07-06
Reviewed by Andreas Kling.

Shorten thread name for process launcher so that we can silence the warning
for thread names getting truncated under VisualStudio -
see createThread() in  Threading.cpp.

* UIProcess/Launcher/ProcessLauncher.cpp:
(WebKit::processLauncherWorkQueue):

Modified Paths

Diff

Modified: trunk/Source/WebKit2/ChangeLog (121971 => 121972)


--- trunk/Source/WebKit2/ChangeLog	2012-07-06 14:37:57 UTC (rev 121971)
+++ trunk/Source/WebKit2/ChangeLog	2012-07-06 14:49:53 UTC (rev 121972)
@@ -1,3 +1,17 @@
+2012-07-06  Dominik Röttsches  <dominik.rottsc...@intel.com>
+
+        ProcessLauncher's WorkQueue's name is too long on Windows
+        https://bugs.webkit.org/show_bug.cgi?id=44041
+
+        Reviewed by Andreas Kling.
+
+        Shorten thread name for process launcher so that we can silence the warning
+        for thread names getting truncated under VisualStudio -
+        see createThread() in  Threading.cpp.
+
+        * UIProcess/Launcher/ProcessLauncher.cpp:
+        (WebKit::processLauncherWorkQueue):
+
 2012-07-06  Christophe Dumez  <christophe.du...@intel.com>
 
         [EFL] WebKit-EFL headers do not build with gcc < 4.6

Modified: trunk/Source/WebKit2/UIProcess/Launcher/ProcessLauncher.cpp (121971 => 121972)


--- trunk/Source/WebKit2/UIProcess/Launcher/ProcessLauncher.cpp	2012-07-06 14:37:57 UTC (rev 121971)
+++ trunk/Source/WebKit2/UIProcess/Launcher/ProcessLauncher.cpp	2012-07-06 14:49:53 UTC (rev 121972)
@@ -33,7 +33,9 @@
 
 static WorkQueue& processLauncherWorkQueue()
 {
-    DEFINE_STATIC_LOCAL(WorkQueue, processLauncherWorkQueue, ("com.apple.WebKit.ProcessLauncher"));
+    // Give in to VisualStudio and its 31 character thread name limit and shorten the thread name to ProcLauncher instead of class name.
+    // See createThread() in Threading.cpp.
+    DEFINE_STATIC_LOCAL(WorkQueue, processLauncherWorkQueue, ("com.apple.WebKit.ProcLauncher"));
     return processLauncherWorkQueue;
 }
 
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to